All of lore.kernel.org
 help / color / mirror / Atom feed
From: <mythripk@ti.com>
To: tomi.valkeinen@ti.com, linux-omap@vger.kernel.org
Cc: Mythri P K <mythripk@ti.com>
Subject: [PATCH 03/10] OMAP4: DSS: HDMI: Use specific HDMI timings structure
Date: Thu, 8 Sep 2011 19:06:20 +0530	[thread overview]
Message-ID: <1315488987-4546-4-git-send-email-mythripk@ti.com> (raw)
In-Reply-To: <1315488987-4546-3-git-send-email-mythripk@ti.com>

From: Mythri P K <mythripk@ti.com>

As hdmi has few additional parameters such as vsync and hsync
polarity which is missing in DSS timing structure, define HDMI timings
structure for hdmi to use instead of OMAP DSS timing structure.


Signed-off-by: Mythri P K <mythripk@ti.com>
---
 drivers/video/omap2/dss/hdmi.c |   23 ++++++++++++++++++++---
 drivers/video/omap2/dss/hdmi.h |   15 ++++++++++++++-
 2 files changed, 34 insertions(+), 4 deletions(-)

diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
index 47e9f4a..c387bf4 100644
--- a/drivers/video/omap2/dss/hdmi.c
+++ b/drivers/video/omap2/dss/hdmi.c
@@ -534,6 +534,21 @@ static int read_edid(struct hdmi_ip_data *ip_data, u8 *pedid, u16 max_length)
 	return 0;
 }
 
+static void copy_hdmi_to_dss_timings(
+		const struct hdmi_video_timings *hdmi_timings,
+		struct omap_video_timings *timings)
+{
+	timings->x_res = hdmi_timings->x_res;
+	timings->y_res = hdmi_timings->y_res;
+	timings->pixel_clock = hdmi_timings->pixel_clock;
+	timings->hbp = hdmi_timings->hbp;
+	timings->hfp = hdmi_timings->hfp;
+	timings->hsw = hdmi_timings->hsw;
+	timings->vbp = hdmi_timings->vbp;
+	timings->vfp = hdmi_timings->vfp;
+	timings->vsw = hdmi_timings->vsw;
+}
+
 static int get_timings_index(void)
 {
 	int code;
@@ -558,7 +573,7 @@ static struct hdmi_cm hdmi_get_code(struct omap_video_timings *timing)
 {
 	int i = 0, code = -1, temp_vsync = 0, temp_hsync = 0;
 	int timing_vsync = 0, timing_hsync = 0;
-	struct omap_video_timings temp;
+	struct hdmi_video_timings temp;
 	struct hdmi_cm cm = {-1};
 	DSSDBG("hdmi_get_code\n");
 
@@ -716,7 +731,8 @@ static void hdmi_read_edid(struct omap_video_timings *dp)
 
 	code = get_timings_index();
 
-	*dp = cea_vesa_timings[code].timings;
+	copy_hdmi_to_dss_timings(&cea_vesa_timings[code].timings, dp);
+
 }
 
 static void hdmi_core_init(struct hdmi_core_video_config *video_cfg,
@@ -1178,7 +1194,8 @@ static int hdmi_power_on(struct omap_dss_device *dssdev)
 		hdmi_read_edid(p);
 	}
 	code = get_timings_index();
-	dssdev->panel.timings = cea_vesa_timings[code].timings;
+	copy_hdmi_to_dss_timings(&cea_vesa_timings[code].timings,
+			&dssdev->panel.timings);
 	update_hdmi_timings(&hdmi.ip_data.cfg, p, code);
 
 	phy = p->pixel_clock;
diff --git a/drivers/video/omap2/dss/hdmi.h b/drivers/video/omap2/dss/hdmi.h
index d2913f8..02342f6 100644
--- a/drivers/video/omap2/dss/hdmi.h
+++ b/drivers/video/omap2/dss/hdmi.h
@@ -198,9 +198,22 @@ struct hdmi_reg { u16 idx; };
 #define REG_GET(base, idx, start, end) \
 	FLD_GET(hdmi_read_reg(base, idx), start, end)
 
+struct hdmi_video_timings {
+	u16 x_res;
+	u16 y_res;
+	/* Unit: KHz */
+	u32 pixel_clock;
+	u16 hsw;
+	u16 hfp;
+	u16 hbp;
+	u16 vsw;
+	u16 vfp;
+	u16 vbp;
+};
+
 /* HDMI timing structure */
 struct hdmi_timings {
-	struct omap_video_timings timings;
+	struct hdmi_video_timings timings;
 	int vsync_pol;
 	int hsync_pol;
 };
-- 
1.7.5.4


  reply	other threads:[~2011-09-08 13:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08 13:36 [PATCH 00/10] OMAP4: DSS2: HDMI: Split hdmi.c in DSS to seperate mythripk
2011-09-08 13:36 ` [PATCH 01/10] OMAP4: DSS: HDMI: HDMI clean up to pass base_address mythripk
2011-09-08 13:36   ` [PATCH 02/10] OMAP4: DSS: HDMI: Move pll and video configuration mythripk
2011-09-08 13:36     ` mythripk [this message]
2011-09-08 13:36       ` [PATCH 04/10] OMAP4: DSS: HDMI: Move HDMI IP independent generic header mythripk
2011-09-08 13:36         ` [PATCH 05/10] OMAP4 : DSS : HDMI : Move the EDID definition from HDMI mythripk
2011-09-08 13:36           ` [PATCH 06/10] OMAP4: DSS2: HDMI: Split the current HDMI driver to move mythripk
2011-09-08 13:36             ` [PATCH 07/10]OMAP4: DSS2: HDMI: Move the HDMI IP dependent audio mythripk
2011-09-08 13:36               ` [PATCH 08/10] OMAP4: DSS: HDMI: Rename the functions in HDMI IP library mythripk
2011-09-08 13:36                 ` [PATCH 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call mythripk
2011-09-08 13:36                   ` [PATCH 10/10] OMAP4: DSS: Rename hdmi_omap4_panel.c to hdmi_panel.c mythripk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315488987-4546-4-git-send-email-mythripk@ti.com \
    --to=mythripk@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.