All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yaakov (Cygwin/X)" <yselkowitz@users.sourceforge.net>
To: mmarek@suse.cz
Cc: linux-kbuild@vger.kernel.org
Subject: [PATCH] xconfig: use pkgconfig to find moc
Date: Wed,  4 Jul 2012 15:23:29 -0500	[thread overview]
Message-ID: <1341433409-5764-1-git-send-email-yselkowitz@users.sourceforge.net> (raw)
In-Reply-To: <20120704163351.GB12094@sepie.suse.cz>

From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>

Various schemes exist to allow parallel installations of multiple major
versions of Qt (4.x with the previous 3.x and/or the upcoming 5.x).
QtCore.pc includes a moc_location variable which should be a more reliable
way to find moc.

Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
---
 scripts/kconfig/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 7966265..5e2176c 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -260,8 +260,8 @@ $(obj)/.tmp_qtcheck:
 	else \
 	  cflags="\$$(shell pkg-config QtCore QtGui Qt3Support --cflags)"; \
 	  libs="\$$(shell pkg-config QtCore QtGui Qt3Support --libs)"; \
-	  binpath="\$$(shell pkg-config QtCore --variable=prefix)"; \
-	  moc="$$binpath/bin/moc"; \
+	  moc="\$$(shell pkg-config QtCore --variable=moc_location)"; \
+	  [ -n "$$moc" ] || moc="\$$(shell pkg-config QtCore --variable=prefix)/bin/moc"; \
 	fi; \
 	echo "KC_QT_CFLAGS=$$cflags" > $@; \
 	echo "KC_QT_LIBS=$$libs" >> $@; \
-- 
1.7.9


  reply	other threads:[~2012-07-04 20:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-11 22:56 [PATCH] xconfig: use pkgconfig to find moc Yaakov (Cygwin/X)
2012-07-04 16:33 ` Michal Marek
2012-07-04 20:23   ` Yaakov (Cygwin/X) [this message]
2012-07-13 12:37     ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341433409-5764-1-git-send-email-yselkowitz@users.sourceforge.net \
    --to=yselkowitz@users.sourceforge.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.