From: "Christian König" <deathsimple@vodafone.de>
To: dri-devel@lists.freedesktop.org
Subject: [PATCH 03/15] drm/radeon: fix fence related segfault in CS
Date: Thu, 12 Jul 2012 18:12:42 +0200 [thread overview]
Message-ID: <1342109574-8107-4-git-send-email-deathsimple@vodafone.de> (raw)
In-Reply-To: <1342109574-8107-1-git-send-email-deathsimple@vodafone.de>
Don't return success if scheduling the IB fails, otherwise
we end up with an oops in ttm_eu_fence_buffer_objects.
Signed-off-by: Christian König <deathsimple@vodafone.de>
Reviewed-by: Jerome Glisse <jglisse@redhat.com>
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/radeon/radeon_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
index f1b7527..d5aec09 100644
--- a/drivers/gpu/drm/radeon/radeon_cs.c
+++ b/drivers/gpu/drm/radeon/radeon_cs.c
@@ -358,7 +358,7 @@ static int radeon_cs_ib_chunk(struct radeon_device *rdev,
if (r) {
DRM_ERROR("Failed to schedule IB !\n");
}
- return 0;
+ return r;
}
static int radeon_bo_vm_update_pte(struct radeon_cs_parser *parser,
--
1.7.9.5
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2012-07-12 16:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 16:12 Ring saving patches round 3 Christian König
2012-07-12 16:12 ` [PATCH 01/15] drm/radeon: add error handling to fence_wait_empty_locked Christian König
2012-07-12 16:12 ` [PATCH 02/15] drm/radeon: add error handling to radeon_vm_unbind_locked Christian König
2012-07-12 16:12 ` Christian König [this message]
2012-07-12 16:12 ` [PATCH 04/15] drm/radeon: add an exclusive lock for GPU reset v2 Christian König
2012-07-12 16:12 ` [PATCH 05/15] drm/radeon: fix ring commit padding Christian König
2012-07-12 16:12 ` [PATCH 06/15] drm/radeon: fix fence value access Christian König
2012-07-12 16:12 ` [PATCH 07/15] drm/radeon: fix fence init after resume Christian König
2012-07-12 16:12 ` [PATCH 08/15] drm/radeon: remove FIXME comment from chipset suspend Christian König
2012-07-12 16:12 ` [PATCH 09/15] drm/radeon: make cp init on cayman more robust Christian König
2012-07-12 16:12 ` [PATCH 10/15] drm/radeon: remove ip_pool start/suspend Christian König
2012-07-12 16:12 ` [PATCH 11/15] drm/radeon: remove r600_blit_suspend Christian König
2012-07-12 16:12 ` [PATCH 12/15] drm/radeon: remove vm_manager start/suspend Christian König
2012-07-12 16:12 ` [PATCH 13/15] drm/radeon: move radeon_ib_ring_tests out of chipset code Christian König
2012-07-12 16:12 ` [PATCH 14/15] drm/radeon: record what is next valid wptr for each ring v3 Christian König
2012-07-12 16:36 ` Alex Deucher
2012-07-13 9:09 ` Christian König
2012-07-13 12:27 ` Alex Deucher
2012-07-13 13:46 ` Christian König
2012-07-13 13:57 ` Alex Deucher
2012-07-16 23:13 ` Alex Deucher
2012-07-17 8:49 ` Christian König
2012-07-17 12:51 ` Alex Deucher
2012-07-17 14:17 ` Jerome Glisse
2012-07-17 14:37 ` Christian König
2012-07-12 16:12 ` [PATCH 15/15] drm/radeon: implement ring saving on reset v4 Christian König
-- strict thread matches above, loose matches on Subject: below --
2012-07-10 12:51 [PATCH 01/15] drm/radeon: add error handling to fence_wait_empty_locked Christian König
2012-07-10 12:51 ` [PATCH 03/15] drm/radeon: fix fence related segfault in CS Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342109574-8107-4-git-send-email-deathsimple@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.