All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: dri-devel@lists.freedesktop.org, airlied@gmail.com
Subject: [PATCH 1/2] drm/radeon: fix fence related segfault in CS
Date: Tue, 31 Jul 2012 13:48:50 +0200	[thread overview]
Message-ID: <1343735331-4922-1-git-send-email-deathsimple@vodafone.de> (raw)

Don't return success if scheduling the IB fails, otherwise
we end up with an oops in ttm_eu_fence_buffer_objects.

Signed-off-by: Christian König <deathsimple@vodafone.de>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/radeon/radeon_cs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
index 142f894..17238f4 100644
--- a/drivers/gpu/drm/radeon/radeon_cs.c
+++ b/drivers/gpu/drm/radeon/radeon_cs.c
@@ -377,7 +377,7 @@ static int radeon_cs_ib_chunk(struct radeon_device *rdev,
 	if (r) {
 		DRM_ERROR("Failed to schedule IB !\n");
 	}
-	return 0;
+	return r;
 }
 
 static int radeon_bo_vm_update_pte(struct radeon_cs_parser *parser,
-- 
1.7.9.5

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2012-07-31 11:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-31 11:48 Christian König [this message]
2012-07-31 11:48 ` [PATCH 2/2] drm/radeon: fix bank tiling parameters on SI Christian König
2012-07-31 14:02   ` Alex Deucher
2012-07-31 14:21     ` Christian König
2012-07-31 14:42       ` Alex Deucher
2012-07-31 15:07         ` [PATCH 1/2] drm/radeon: fix bank tiling parameters on evergreen alexdeucher
2012-07-31 15:07           ` [PATCH 2/2] drm/radeon: fix bank tiling parameters on cayman alexdeucher
2012-07-31 15:21         ` [PATCH 2/2] drm/radeon: fix bank tiling parameters on SI Christian König
2012-07-31 14:47 ` [PATCH 1/2] drm/radeon: fix fence related segfault in CS Michel Dänzer
2012-07-31 15:05   ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343735331-4922-1-git-send-email-deathsimple@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.