All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: kvm-ppc@vger.kernel.org
Cc: KVM list <kvm@vger.kernel.org>,
	Liu Yu-B13201 <Yu.Liu@freescale.com>,
	Liu Yu <yu.liu@freescale.com>,
	Stuart Yoder <stuart.yoder@freescale.com>
Subject: [PATCH 04/38] KVM: PPC: Add support for ePAPR idle hcall in host kernel
Date: Wed, 15 Aug 2012 01:04:09 +0200	[thread overview]
Message-ID: <1344985483-7440-5-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1344985483-7440-1-git-send-email-agraf@suse.de>

From: Liu Yu-B13201 <Yu.Liu@freescale.com>

And add a new flag definition in kvm_ppc_pvinfo to indicate
whether the host supports the EV_IDLE hcall.

Signed-off-by: Liu Yu <yu.liu@freescale.com>
[stuart.yoder@freescale.com: cleanup,fixes for conditions allowing idle]
Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
[agraf: fix typo]
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 Documentation/virtual/kvm/api.txt |    7 +++++--
 arch/powerpc/include/asm/Kbuild   |    1 +
 arch/powerpc/kvm/powerpc.c        |   10 ++++++++--
 include/linux/kvm.h               |    2 ++
 4 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
index bf33aaa..a37ec45 100644
--- a/Documentation/virtual/kvm/api.txt
+++ b/Documentation/virtual/kvm/api.txt
@@ -1190,12 +1190,15 @@ struct kvm_ppc_pvinfo {
 This ioctl fetches PV specific information that need to be passed to the guest
 using the device tree or other means from vm context.
 
-For now the only implemented piece of information distributed here is an array
-of 4 instructions that make up a hypercall.
+The hcall array defines 4 instructions that make up a hypercall.
 
 If any additional field gets added to this structure later on, a bit for that
 additional piece of information will be set in the flags bitmap.
 
+The flags bitmap is defined as:
+
+   /* the host supports the ePAPR idle hcall
+   #define KVM_PPC_PVINFO_FLAGS_EV_IDLE   (1<<0)
 
 4.48 KVM_ASSIGN_PCI_DEVICE
 
diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
index 7e313f1..13d6b7b 100644
--- a/arch/powerpc/include/asm/Kbuild
+++ b/arch/powerpc/include/asm/Kbuild
@@ -34,5 +34,6 @@ header-y += termios.h
 header-y += types.h
 header-y += ucontext.h
 header-y += unistd.h
+header-y += epapr_hcalls.h
 
 generic-y += rwsem.h
diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
index 4ff2f27..6645cc7 100644
--- a/arch/powerpc/kvm/powerpc.c
+++ b/arch/powerpc/kvm/powerpc.c
@@ -38,8 +38,7 @@
 
 int kvm_arch_vcpu_runnable(struct kvm_vcpu *v)
 {
-	return !(v->arch.shared->msr & MSR_WE) ||
-	       !!(v->arch.pending_exceptions) ||
+	return !!(v->arch.pending_exceptions) ||
 	       v->requests;
 }
 
@@ -86,6 +85,11 @@ int kvmppc_kvm_pv(struct kvm_vcpu *vcpu)
 
 		/* Second return value is in r4 */
 		break;
+	case EV_HCALL_TOKEN(EV_IDLE):
+		r = EV_SUCCESS;
+		kvm_vcpu_block(vcpu);
+		clear_bit(KVM_REQ_UNHALT, &vcpu->requests);
+		break;
 	default:
 		r = EV_UNIMPLEMENTED;
 		break;
@@ -775,6 +779,8 @@ static int kvm_vm_ioctl_get_pvinfo(struct kvm_ppc_pvinfo *pvinfo)
 	pvinfo->hcall[3] = inst_nop;
 #endif
 
+	pvinfo->flags = KVM_PPC_PVINFO_FLAGS_EV_IDLE;
+
 	return 0;
 }
 
diff --git a/include/linux/kvm.h b/include/linux/kvm.h
index 2ce09aa..c03e59e 100644
--- a/include/linux/kvm.h
+++ b/include/linux/kvm.h
@@ -473,6 +473,8 @@ struct kvm_ppc_smmu_info {
 	struct kvm_ppc_one_seg_page_size sps[KVM_PPC_PAGE_SIZES_MAX_SZ];
 };
 
+#define KVM_PPC_PVINFO_FLAGS_EV_IDLE   (1<<0)
+
 #define KVMIO 0xAE
 
 /* machine type bits, to be used as argument to KVM_CREATE_VM */
-- 
1.6.0.2


WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: kvm-ppc@vger.kernel.org
Cc: KVM list <kvm@vger.kernel.org>,
	Liu Yu-B13201 <Yu.Liu@freescale.com>,
	Liu Yu <yu.liu@freescale.com>,
	Stuart Yoder <stuart.yoder@freescale.com>
Subject: [PATCH 04/38] KVM: PPC: Add support for ePAPR idle hcall in host kernel
Date: Tue, 14 Aug 2012 23:04:09 +0000	[thread overview]
Message-ID: <1344985483-7440-5-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1344985483-7440-1-git-send-email-agraf@suse.de>

From: Liu Yu-B13201 <Yu.Liu@freescale.com>

And add a new flag definition in kvm_ppc_pvinfo to indicate
whether the host supports the EV_IDLE hcall.

Signed-off-by: Liu Yu <yu.liu@freescale.com>
[stuart.yoder@freescale.com: cleanup,fixes for conditions allowing idle]
Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
[agraf: fix typo]
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 Documentation/virtual/kvm/api.txt |    7 +++++--
 arch/powerpc/include/asm/Kbuild   |    1 +
 arch/powerpc/kvm/powerpc.c        |   10 ++++++++--
 include/linux/kvm.h               |    2 ++
 4 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
index bf33aaa..a37ec45 100644
--- a/Documentation/virtual/kvm/api.txt
+++ b/Documentation/virtual/kvm/api.txt
@@ -1190,12 +1190,15 @@ struct kvm_ppc_pvinfo {
 This ioctl fetches PV specific information that need to be passed to the guest
 using the device tree or other means from vm context.
 
-For now the only implemented piece of information distributed here is an array
-of 4 instructions that make up a hypercall.
+The hcall array defines 4 instructions that make up a hypercall.
 
 If any additional field gets added to this structure later on, a bit for that
 additional piece of information will be set in the flags bitmap.
 
+The flags bitmap is defined as:
+
+   /* the host supports the ePAPR idle hcall
+   #define KVM_PPC_PVINFO_FLAGS_EV_IDLE   (1<<0)
 
 4.48 KVM_ASSIGN_PCI_DEVICE
 
diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
index 7e313f1..13d6b7b 100644
--- a/arch/powerpc/include/asm/Kbuild
+++ b/arch/powerpc/include/asm/Kbuild
@@ -34,5 +34,6 @@ header-y += termios.h
 header-y += types.h
 header-y += ucontext.h
 header-y += unistd.h
+header-y += epapr_hcalls.h
 
 generic-y += rwsem.h
diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
index 4ff2f27..6645cc7 100644
--- a/arch/powerpc/kvm/powerpc.c
+++ b/arch/powerpc/kvm/powerpc.c
@@ -38,8 +38,7 @@
 
 int kvm_arch_vcpu_runnable(struct kvm_vcpu *v)
 {
-	return !(v->arch.shared->msr & MSR_WE) ||
-	       !!(v->arch.pending_exceptions) ||
+	return !!(v->arch.pending_exceptions) ||
 	       v->requests;
 }
 
@@ -86,6 +85,11 @@ int kvmppc_kvm_pv(struct kvm_vcpu *vcpu)
 
 		/* Second return value is in r4 */
 		break;
+	case EV_HCALL_TOKEN(EV_IDLE):
+		r = EV_SUCCESS;
+		kvm_vcpu_block(vcpu);
+		clear_bit(KVM_REQ_UNHALT, &vcpu->requests);
+		break;
 	default:
 		r = EV_UNIMPLEMENTED;
 		break;
@@ -775,6 +779,8 @@ static int kvm_vm_ioctl_get_pvinfo(struct kvm_ppc_pvinfo *pvinfo)
 	pvinfo->hcall[3] = inst_nop;
 #endif
 
+	pvinfo->flags = KVM_PPC_PVINFO_FLAGS_EV_IDLE;
+
 	return 0;
 }
 
diff --git a/include/linux/kvm.h b/include/linux/kvm.h
index 2ce09aa..c03e59e 100644
--- a/include/linux/kvm.h
+++ b/include/linux/kvm.h
@@ -473,6 +473,8 @@ struct kvm_ppc_smmu_info {
 	struct kvm_ppc_one_seg_page_size sps[KVM_PPC_PAGE_SIZES_MAX_SZ];
 };
 
+#define KVM_PPC_PVINFO_FLAGS_EV_IDLE   (1<<0)
+
 #define KVMIO 0xAE
 
 /* machine type bits, to be used as argument to KVM_CREATE_VM */
-- 
1.6.0.2


  parent reply	other threads:[~2012-08-14 23:04 UTC|newest]

Thread overview: 150+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14 23:04 [PULL 00/38] ppc patch queue 2012-08-15 Alexander Graf
2012-08-14 23:04 ` Alexander Graf
2012-08-14 23:04 ` [PATCH 01/38] PPC: epapr: create define for return code value of success Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 02/38] KVM: PPC: use definitions in epapr header for hcalls Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 03/38] KVM: PPC: add pvinfo for hcall opcodes on e500mc/e5500 Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` Alexander Graf [this message]
2012-08-14 23:04   ` [PATCH 04/38] KVM: PPC: Add support for ePAPR idle hcall in host kernel Alexander Graf
2012-08-14 23:04 ` [PATCH 05/38] KVM: PPC: ev_idle hcall support for e500 guests Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 06/38] PPC: select EPAPR_PARAVIRT for all users of epapr hcalls Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 07/38] powerpc/fsl-soc: use CONFIG_EPAPR_PARAVIRT for hcalls Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 08/38] PPC: Don't use hardcoded opcode for ePAPR hcall invocation Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 09/38] KVM: PPC: PR: Use generic tracepoint for guest exit Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 10/38] KVM: PPC: Expose SYNC cap based on mmu notifiers Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 11/38] KVM: PPC: BookE: Expose remote TLB flushes in debugfs Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 12/38] KVM: PPC: E500: Fix clear_tlb_refs Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 13/38] KVM: PPC: Book3S HV: Fix incorrect branch in H_CEDE code Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 14/38] KVM: PPC: Quieten message about allocating linear regions Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 15/38] powerpc/epapr: export epapr_hypercall_start Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 16/38] KVM: PPC: BookE: Add check_requests helper function Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-15  0:10   ` Scott Wood
2012-08-15  0:10     ` Scott Wood
2012-08-15  0:13     ` Alexander Graf
2012-08-15  0:13       ` Alexander Graf
2012-08-15  0:20       ` Scott Wood
2012-08-15  0:20         ` Scott Wood
2012-08-15 18:28     ` Marcelo Tosatti
2012-08-15 18:28       ` Marcelo Tosatti
2012-08-14 23:04 ` [PATCH 17/38] KVM: PPC: BookE: Add support for vcpu->mode Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-15  0:17   ` Scott Wood
2012-08-15  0:17     ` Scott Wood
2012-08-15  0:26     ` Alexander Graf
2012-08-15  0:26       ` Alexander Graf
2012-08-15  1:17       ` Scott Wood
2012-08-15  1:17         ` Scott Wood
2012-08-15  9:29         ` Alexander Graf
2012-08-15  9:29           ` Alexander Graf
2012-08-21  1:41           ` Scott Wood
2012-08-21  1:41             ` Scott Wood
2012-08-15  1:25   ` Scott Wood
2012-08-15  1:25     ` Scott Wood
2012-08-14 23:04 ` [PATCH 18/38] KVM: PPC: E500: Implement MMU notifiers Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-15  1:20   ` Scott Wood
2012-08-15  1:20     ` Scott Wood
2012-08-15  9:38     ` Alexander Graf
2012-08-15  9:38       ` Alexander Graf
2012-08-14 23:04 ` [PATCH 19/38] KVM: PPC: Add cache flush on page map Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-15  1:23   ` Scott Wood
2012-08-15  1:23     ` Scott Wood
2012-08-15  9:52     ` Alexander Graf
2012-08-15  9:52       ` Alexander Graf
2012-08-15 17:26       ` Scott Wood
2012-08-15 17:26         ` Scott Wood
2012-08-15 17:27         ` Alexander Graf
2012-08-15 17:27           ` Alexander Graf
2012-08-15 17:47           ` Scott Wood
2012-08-15 17:47             ` Scott Wood
2012-08-15 18:01             ` Alexander Graf
2012-08-15 18:01               ` Alexander Graf
2012-08-15 18:16               ` Scott Wood
2012-08-15 18:16                 ` Scott Wood
2012-08-15 18:27                 ` Alexander Graf
2012-08-15 18:27                   ` Alexander Graf
2012-08-15 18:29                   ` Alexander Graf
2012-08-15 18:29                     ` Alexander Graf
2012-08-15 18:33                     ` Scott Wood
2012-08-15 18:33                       ` Scott Wood
2012-08-15 18:51                       ` Alexander Graf
2012-08-15 18:51                         ` Alexander Graf
2012-08-15 18:56                         ` Scott Wood
2012-08-15 18:56                           ` Scott Wood
2012-08-15 18:58                           ` Alexander Graf
2012-08-15 18:58                             ` Alexander Graf
2012-08-15 19:05                             ` Scott Wood
2012-08-15 19:05                               ` Scott Wood
2012-08-15 19:29                               ` Alexander Graf
2012-08-15 19:29                                 ` Alexander Graf
2012-08-15 19:53                                 ` Scott Wood
2012-08-15 19:53                                   ` Scott Wood
2012-08-14 23:04 ` [PATCH 20/38] KVM: PPC: BookE: Add some more trace points Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 21/38] KVM: PPC: BookE: No duplicate request != 0 check Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 22/38] KVM: PPC: Use same kvmppc_prepare_to_enter code for booke and book3s_pr Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 23/38] KVM: PPC: Book3s: PR: Add (dumb) MMU Notifier support Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 24/38] KVM: PPC: BookE: Drop redundant vcpu->mode set Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 25/38] KVM: PPC: Book3S: PR: Only do resched check once per exit Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 26/38] KVM: PPC: Exit guest context while handling exit Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 27/38] KVM: PPC: Book3S: PR: Indicate we're out of guest mode Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 28/38] KVM: PPC: Consistentify vcpu exit path Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 29/38] KVM: PPC: Book3S: PR: Rework irq disabling Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-17 21:47   ` Benjamin Herrenschmidt
2012-08-17 21:47     ` Benjamin Herrenschmidt
2012-09-28  0:52     ` Alexander Graf
2012-09-28  0:52       ` Alexander Graf
2012-08-14 23:04 ` [PATCH 30/38] KVM: PPC: Move kvm_guest_enter call into generic code Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 31/38] KVM: PPC: Ignore EXITING_GUEST_MODE mode Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 32/38] KVM: PPC: Add return value in prepare_to_enter Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 33/38] KVM: PPC: Add return value to core_check_requests Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 34/38] KVM: PPC: booke: Add watchdog emulation Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 35/38] booke: Added ONE_REG interface for IAC/DAC debug registers Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:44   ` Scott Wood
2012-08-14 23:44     ` Scott Wood
2012-08-14 23:47     ` Alexander Graf
2012-08-14 23:47       ` Alexander Graf
2012-08-15  0:06       ` Scott Wood
2012-08-15  0:06         ` Scott Wood
2012-08-14 23:04 ` [PATCH 36/38] KVM: PPC: 44x: Initialize PVR Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 37/38] KVM: PPC: BookE: Add MCSR SPR support Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-14 23:04 ` [PATCH 38/38] ppc: e500_tlb memset clears nothing Alexander Graf
2012-08-14 23:04   ` Alexander Graf
2012-08-15 10:07   ` Avi Kivity
2012-08-15 10:07     ` Avi Kivity
2012-08-15 10:09     ` Alexander Graf
2012-08-15 10:09       ` Alexander Graf
2012-08-15 10:10       ` Avi Kivity
2012-08-15 10:10         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344985483-7440-5-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=Yu.Liu@freescale.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=stuart.yoder@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.