From: Mike Turquette <mturquette@linaro.org> To: <linux-kernel@vger.kernel.org> Cc: <shawn.guo@linaro.org>, <linus.walleij@linaro.org>, <rob.herring@calxeda.com>, <pdeschrijver@nvidia.com>, <pgaikwad@nvidia.com>, <viresh.kumar@linaro.org>, <rnayak@ti.com>, <paul@pwsan.com>, <broonie@opensource.wolfsonmicro.com>, <ccross@android.com>, <linux-arm-kernel@lists.infradead.org>, <myungjoo.ham@samsung.com>, <rajagopal.venkat@linaro.org>, Mike Turquette <mturquette@linaro.org> Subject: [PATCH v2 4/4] [RFC] omap3+: clk: dpll: call clk_prepare directly Date: Wed, 15 Aug 2012 16:43:34 -0700 [thread overview] Message-ID: <1345074214-17531-5-git-send-email-mturquette@linaro.org> (raw) In-Reply-To: <1345074214-17531-1-git-send-email-mturquette@linaro.org> In the commit titled "clk: new locking scheme for reentrancy" it became possible for nested calls to the clock api. The OMAP3+ DPLL .set_rate callback has been using the __clk_prepare and __clk_unprepare calls as a way around this limitation, but these calls are no longer needed with the aforementioned patch. Convert the .set_rate callback to use clk_prepare and clk_unprepare directly. Signed-off-by: Mike Turquette <mturquette@linaro.org> --- arch/arm/mach-omap2/dpll3xxx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c index ee18d00..1cc3ec8 100644 --- a/arch/arm/mach-omap2/dpll3xxx.c +++ b/arch/arm/mach-omap2/dpll3xxx.c @@ -436,9 +436,9 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate, if (!dd) return -EINVAL; - __clk_prepare(dd->clk_bypass); + clk_prepare(dd->clk_bypass); clk_enable(dd->clk_bypass); - __clk_prepare(dd->clk_ref); + clk_prepare(dd->clk_ref); clk_enable(dd->clk_ref); if (__clk_get_rate(dd->clk_bypass) == rate && @@ -483,9 +483,9 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate, __clk_reparent(hw->clk, new_parent); clk_disable(dd->clk_ref); - __clk_unprepare(dd->clk_ref); + clk_unprepare(dd->clk_ref); clk_disable(dd->clk_bypass); - __clk_unprepare(dd->clk_bypass); + clk_unprepare(dd->clk_bypass); return 0; } -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Mike Turquette) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 4/4] [RFC] omap3+: clk: dpll: call clk_prepare directly Date: Wed, 15 Aug 2012 16:43:34 -0700 [thread overview] Message-ID: <1345074214-17531-5-git-send-email-mturquette@linaro.org> (raw) In-Reply-To: <1345074214-17531-1-git-send-email-mturquette@linaro.org> In the commit titled "clk: new locking scheme for reentrancy" it became possible for nested calls to the clock api. The OMAP3+ DPLL .set_rate callback has been using the __clk_prepare and __clk_unprepare calls as a way around this limitation, but these calls are no longer needed with the aforementioned patch. Convert the .set_rate callback to use clk_prepare and clk_unprepare directly. Signed-off-by: Mike Turquette <mturquette@linaro.org> --- arch/arm/mach-omap2/dpll3xxx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c index ee18d00..1cc3ec8 100644 --- a/arch/arm/mach-omap2/dpll3xxx.c +++ b/arch/arm/mach-omap2/dpll3xxx.c @@ -436,9 +436,9 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate, if (!dd) return -EINVAL; - __clk_prepare(dd->clk_bypass); + clk_prepare(dd->clk_bypass); clk_enable(dd->clk_bypass); - __clk_prepare(dd->clk_ref); + clk_prepare(dd->clk_ref); clk_enable(dd->clk_ref); if (__clk_get_rate(dd->clk_bypass) == rate && @@ -483,9 +483,9 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate, __clk_reparent(hw->clk, new_parent); clk_disable(dd->clk_ref); - __clk_unprepare(dd->clk_ref); + clk_unprepare(dd->clk_ref); clk_disable(dd->clk_bypass); - __clk_unprepare(dd->clk_bypass); + clk_unprepare(dd->clk_bypass); return 0; } -- 1.7.9.5
next prev parent reply other threads:[~2012-08-15 23:44 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-15 23:43 [PATCH v2 0/4] [RFC] reentrancy in the common clk framework Mike Turquette 2012-08-15 23:43 ` Mike Turquette 2012-08-15 23:43 ` [PATCH v2 1/4] [RFC] clk: new locking scheme for reentrancy Mike Turquette 2012-08-15 23:43 ` Mike Turquette 2012-08-27 17:05 ` Pankaj Jangra 2012-08-27 17:05 ` Pankaj Jangra 2012-08-29 21:41 ` Mike Turquette 2012-09-04 14:25 ` Shawn Guo 2012-09-04 14:25 ` Shawn Guo 2012-08-15 23:43 ` [PATCH v2 2/4] [RFC] clk: notifier handler for dynamic voltage scaling Mike Turquette 2012-08-15 23:43 ` Mike Turquette 2012-08-15 23:43 ` [PATCH v2 3/4] [RFC] cpufreq: omap: scale regulator from clk notifier Mike Turquette 2012-08-15 23:43 ` Mike Turquette 2012-08-15 23:43 ` Mike Turquette [this message] 2012-08-15 23:43 ` [PATCH v2 4/4] [RFC] omap3+: clk: dpll: call clk_prepare directly Mike Turquette
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1345074214-17531-5-git-send-email-mturquette@linaro.org \ --to=mturquette@linaro.org \ --cc=broonie@opensource.wolfsonmicro.com \ --cc=ccross@android.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=myungjoo.ham@samsung.com \ --cc=paul@pwsan.com \ --cc=pdeschrijver@nvidia.com \ --cc=pgaikwad@nvidia.com \ --cc=rajagopal.venkat@linaro.org \ --cc=rnayak@ti.com \ --cc=rob.herring@calxeda.com \ --cc=shawn.guo@linaro.org \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.