From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org, kvm@vger.kernel.org,
jbottomley@parallels.com,
"Richard W.M. Jones" <rjones@redhat.com>
Subject: [PATCH for 3.6 2/3] virtio-scsi: initialize scatterlist structure for events
Date: Tue, 28 Aug 2012 13:59:13 +0200 [thread overview]
Message-ID: <1346155154-12915-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1346155154-12915-1-git-send-email-pbonzini@redhat.com>
From: Richard W.M. Jones <rjones@redhat.com>
The sg struct for events is used without being initialized. This
triggers a BUG_ON if CONFIG_DEBUG_SG is defined.
This was reported at https://bugzilla.redhat.com/show_bug.cgi?id=847548.
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
drivers/scsi/virtio_scsi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 3e79a2f..7554d78 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
struct scatterlist sg;
unsigned long flags;
- sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
+ sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);
--
1.7.1
next prev parent reply other threads:[~2012-08-28 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 11:59 [PATCH for 3.6 0/3] urgent virtio-scsi fixes Paolo Bonzini
2012-08-28 11:59 ` Paolo Bonzini [this message]
2012-08-29 10:39 ` [PATCH for 3.6 1/3] virtio-scsi: fix copying of sg_list in the presence of of HighMem pages Paolo Bonzini
2012-08-29 10:39 ` [PATCH for 3.6 3/3] virtio-scsi: fix LUNs greater than 255 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346155154-12915-3-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=jbottomley@parallels.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.