All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Senna Tschudin <peter.senna@gmail.com>
To: svenkatr@ti.com
Cc: cjb@laptop.org, linux-mmc@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Peter Senna Tschudin <peter.senna@gmail.com>
Subject: [PATCH 3/4] drivers/mmc/host/omap_hsmmc.c: fix error return code
Date: Mon, 17 Sep 2012 10:15:27 +0200	[thread overview]
Message-ID: <1347869728-2696-3-git-send-email-peter.senna@gmail.com> (raw)
In-Reply-To: <1347869728-2696-1-git-send-email-peter.senna@gmail.com>

From: Peter Senna Tschudin <peter.senna@gmail.com>

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
 drivers/mmc/host/omap_hsmmc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index e59ac62..c8a2b36 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1893,6 +1893,7 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev)
 		if (pdata->init(&pdev->dev) != 0) {
 			dev_dbg(mmc_dev(host->mmc),
 				"Unable to configure MMC IRQs\n");
+			ret = -ENXIO;
 			goto err_irq_cd_init;
 		}
 	}
-- 
1.7.11.4


WARNING: multiple messages have this Message-ID (diff)
From: Peter Senna Tschudin <peter.senna@gmail.com>
To: svenkatr@ti.com
Cc: cjb@laptop.org, linux-mmc@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Peter Senna Tschudin <peter.senna@gmail.com>
Subject: [PATCH 3/4] drivers/mmc/host/omap_hsmmc.c: fix error return code
Date: Mon, 17 Sep 2012 08:15:27 +0000	[thread overview]
Message-ID: <1347869728-2696-3-git-send-email-peter.senna@gmail.com> (raw)
In-Reply-To: <1347869728-2696-1-git-send-email-peter.senna@gmail.com>

From: Peter Senna Tschudin <peter.senna@gmail.com>

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
 drivers/mmc/host/omap_hsmmc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index e59ac62..c8a2b36 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1893,6 +1893,7 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev)
 		if (pdata->init(&pdev->dev) != 0) {
 			dev_dbg(mmc_dev(host->mmc),
 				"Unable to configure MMC IRQs\n");
+			ret = -ENXIO;
 			goto err_irq_cd_init;
 		}
 	}
-- 
1.7.11.4


  parent reply	other threads:[~2012-09-17  8:16 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-17  8:15 [PATCH 1/4] drivers/mmc/host/dw_mmc.c: fix error return code Peter Senna Tschudin
2012-09-17  8:15 ` Peter Senna Tschudin
2012-09-17  8:15 ` [PATCH 2/4] drivers/mmc/host/omap.c: " Peter Senna Tschudin
2012-09-17  8:15   ` Peter Senna Tschudin
2012-09-17  8:15 ` Peter Senna Tschudin [this message]
2012-09-17  8:15   ` [PATCH 3/4] drivers/mmc/host/omap_hsmmc.c: " Peter Senna Tschudin
2012-09-17 18:11   ` S, Venkatraman
2012-09-17 18:23     ` S, Venkatraman
2012-09-17  8:15 ` [PATCH 4/4] drivers/mmc/host/mxs-mmc.c: " Peter Senna Tschudin
2012-09-17  8:15   ` Peter Senna Tschudin
2012-09-17 10:09   ` Marek Vasut
2012-09-17 10:09     ` Marek Vasut
2012-09-19  2:25   ` Shawn Guo
2012-09-19  2:25     ` Shawn Guo
2012-09-19  2:25     ` Shawn Guo
2012-09-17  9:18 ` [PATCH 1/4] drivers/mmc/host/dw_mmc.c: " Will Newton
2012-09-17  9:18   ` Will Newton
2012-09-17  9:54 ` Seungwon Jeon
2012-09-17  9:54   ` Seungwon Jeon
2012-09-17 11:35   ` Peter Senna Tschudin
2012-09-17 11:35     ` Peter Senna Tschudin
2012-09-17 12:20 ` [PATCH v2 " Peter Senna Tschudin
2012-09-17 12:20   ` Peter Senna Tschudin
2012-09-18 10:13   ` Seungwon Jeon
2012-09-18 10:13     ` Seungwon Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347869728-2696-3-git-send-email-peter.senna@gmail.com \
    --to=peter.senna@gmail.com \
    --cc=cjb@laptop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=svenkatr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.