From: Sourav Poddar <sourav.poddar@ti.com>
To: <gregkh@linuxfoundation.org>
Cc: <alan@linux.intel.com>, <tony@atomide.com>, <khilman@ti.com>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<santosh.shilimkar@ti.com>, <balbi@ti.com>, <paul@pwsan.com>,
Sourav Poddar <sourav.poddar@ti.com>
Subject: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.
Date: Tue, 18 Sep 2012 18:10:50 +0530 [thread overview]
Message-ID: <1347972050-3509-1-git-send-email-sourav.poddar@ti.com> (raw)
Greg's tty-next is not booting on 2420 based N800. The failure is
observed at serial init itself. The reason might be that n800 tries to
resume even though it is not suspended before.
Reported-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
This patch is developed on top of greg's tty-next branch
CommitId: e740d8f tty: serial: Samsung: Fix return value +
the following patch which I have already posted to the mailing list.
http://comments.gmane.org/gmane.linux.ports.arm.omap/84729
drivers/tty/serial/omap-serial.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 3c05c5e..bc355f2 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -110,6 +110,7 @@ struct uart_omap_port {
u32 calc_latency;
struct work_struct qos_work;
struct pinctrl *pins;
+ unsigned int suspended:1;
};
#define to_uart_omap_port(p) ((container_of((p), struct uart_omap_port, port)))
@@ -1545,14 +1546,20 @@ static int serial_omap_runtime_suspend(struct device *dev)
up->latency = PM_QOS_CPU_DMA_LAT_DEFAULT_VALUE;
schedule_work(&up->qos_work);
+ up->suspended = true;
+
return 0;
}
static int serial_omap_runtime_resume(struct device *dev)
{
struct uart_omap_port *up = dev_get_drvdata(dev);
+ u32 loss_cnt;
+
+ if (!up->suspended)
+ return 0;
- u32 loss_cnt = serial_omap_get_context_loss_count(up);
+ loss_cnt = serial_omap_get_context_loss_count(up);
if (up->context_loss_cnt != loss_cnt)
serial_omap_restore_context(up);
@@ -1560,6 +1567,8 @@ static int serial_omap_runtime_resume(struct device *dev)
up->latency = up->calc_latency;
schedule_work(&up->qos_work);
+ up->suspended = false;
+
return 0;
}
#endif
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Sourav Poddar <sourav.poddar@ti.com>
To: gregkh@linuxfoundation.org
Cc: alan@linux.intel.com, tony@atomide.com, khilman@ti.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
santosh.shilimkar@ti.com, balbi@ti.com, paul@pwsan.com,
Sourav Poddar <sourav.poddar@ti.com>
Subject: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.
Date: Tue, 18 Sep 2012 18:10:50 +0530 [thread overview]
Message-ID: <1347972050-3509-1-git-send-email-sourav.poddar@ti.com> (raw)
Greg's tty-next is not booting on 2420 based N800. The failure is
observed at serial init itself. The reason might be that n800 tries to
resume even though it is not suspended before.
Reported-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
This patch is developed on top of greg's tty-next branch
CommitId: e740d8f tty: serial: Samsung: Fix return value +
the following patch which I have already posted to the mailing list.
http://comments.gmane.org/gmane.linux.ports.arm.omap/84729
drivers/tty/serial/omap-serial.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 3c05c5e..bc355f2 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -110,6 +110,7 @@ struct uart_omap_port {
u32 calc_latency;
struct work_struct qos_work;
struct pinctrl *pins;
+ unsigned int suspended:1;
};
#define to_uart_omap_port(p) ((container_of((p), struct uart_omap_port, port)))
@@ -1545,14 +1546,20 @@ static int serial_omap_runtime_suspend(struct device *dev)
up->latency = PM_QOS_CPU_DMA_LAT_DEFAULT_VALUE;
schedule_work(&up->qos_work);
+ up->suspended = true;
+
return 0;
}
static int serial_omap_runtime_resume(struct device *dev)
{
struct uart_omap_port *up = dev_get_drvdata(dev);
+ u32 loss_cnt;
+
+ if (!up->suspended)
+ return 0;
- u32 loss_cnt = serial_omap_get_context_loss_count(up);
+ loss_cnt = serial_omap_get_context_loss_count(up);
if (up->context_loss_cnt != loss_cnt)
serial_omap_restore_context(up);
@@ -1560,6 +1567,8 @@ static int serial_omap_runtime_resume(struct device *dev)
up->latency = up->calc_latency;
schedule_work(&up->qos_work);
+ up->suspended = false;
+
return 0;
}
#endif
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: sourav.poddar@ti.com (Sourav Poddar)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.
Date: Tue, 18 Sep 2012 18:10:50 +0530 [thread overview]
Message-ID: <1347972050-3509-1-git-send-email-sourav.poddar@ti.com> (raw)
Greg's tty-next is not booting on 2420 based N800. The failure is
observed at serial init itself. The reason might be that n800 tries to
resume even though it is not suspended before.
Reported-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
This patch is developed on top of greg's tty-next branch
CommitId: e740d8f tty: serial: Samsung: Fix return value +
the following patch which I have already posted to the mailing list.
http://comments.gmane.org/gmane.linux.ports.arm.omap/84729
drivers/tty/serial/omap-serial.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 3c05c5e..bc355f2 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -110,6 +110,7 @@ struct uart_omap_port {
u32 calc_latency;
struct work_struct qos_work;
struct pinctrl *pins;
+ unsigned int suspended:1;
};
#define to_uart_omap_port(p) ((container_of((p), struct uart_omap_port, port)))
@@ -1545,14 +1546,20 @@ static int serial_omap_runtime_suspend(struct device *dev)
up->latency = PM_QOS_CPU_DMA_LAT_DEFAULT_VALUE;
schedule_work(&up->qos_work);
+ up->suspended = true;
+
return 0;
}
static int serial_omap_runtime_resume(struct device *dev)
{
struct uart_omap_port *up = dev_get_drvdata(dev);
+ u32 loss_cnt;
+
+ if (!up->suspended)
+ return 0;
- u32 loss_cnt = serial_omap_get_context_loss_count(up);
+ loss_cnt = serial_omap_get_context_loss_count(up);
if (up->context_loss_cnt != loss_cnt)
serial_omap_restore_context(up);
@@ -1560,6 +1567,8 @@ static int serial_omap_runtime_resume(struct device *dev)
up->latency = up->calc_latency;
schedule_work(&up->qos_work);
+ up->suspended = false;
+
return 0;
}
#endif
--
1.7.1
next reply other threads:[~2012-09-18 12:41 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 12:40 Sourav Poddar [this message]
2012-09-18 12:40 ` [RFT/PATCH] serial: omap: prevent resume if device is not suspended Sourav Poddar
2012-09-18 12:40 ` Sourav Poddar
2012-09-18 14:02 ` Felipe Balbi
2012-09-18 14:02 ` Felipe Balbi
2012-09-18 22:57 ` Paul Walmsley
2012-09-18 22:57 ` Paul Walmsley
2012-09-19 11:52 ` Grazvydas Ignotas
2012-09-19 11:52 ` Grazvydas Ignotas
2012-09-19 11:52 ` Grazvydas Ignotas
2012-09-19 11:59 ` Felipe Balbi
2012-09-19 11:59 ` Felipe Balbi
2012-09-25 12:29 ` Jassi Brar
2012-09-25 12:29 ` Jassi Brar
2012-09-25 8:22 ` Poddar, Sourav
2012-09-25 8:22 ` Poddar, Sourav
2012-09-25 8:30 ` Russell King - ARM Linux
2012-09-25 8:30 ` Russell King - ARM Linux
2012-09-25 8:31 ` Felipe Balbi
2012-09-25 8:31 ` Felipe Balbi
2012-09-25 9:12 ` Russell King - ARM Linux
2012-09-25 9:12 ` Russell King - ARM Linux
2012-09-25 9:11 ` Felipe Balbi
2012-09-25 9:11 ` Felipe Balbi
2012-09-25 9:21 ` Russell King - ARM Linux
2012-09-25 9:21 ` Russell King - ARM Linux
2012-09-25 9:48 ` Felipe Balbi
2012-09-25 9:48 ` Felipe Balbi
2012-09-25 10:29 ` Russell King - ARM Linux
2012-09-25 10:29 ` Russell King - ARM Linux
2012-09-25 10:37 ` Felipe Balbi
2012-09-25 10:37 ` Felipe Balbi
2012-09-25 11:07 ` Russell King - ARM Linux
2012-09-25 11:07 ` Russell King - ARM Linux
2012-09-25 11:12 ` Felipe Balbi
2012-09-25 11:12 ` Felipe Balbi
2012-09-25 11:32 ` Russell King - ARM Linux
2012-09-25 11:32 ` Russell King - ARM Linux
2012-09-25 9:56 ` Poddar, Sourav
2012-09-25 9:56 ` Poddar, Sourav
2012-09-25 10:59 ` Russell King - ARM Linux
2012-09-25 10:59 ` Russell King - ARM Linux
2012-10-03 0:33 ` Kevin Hilman
2012-10-03 0:33 ` Kevin Hilman
2012-10-03 0:33 ` Kevin Hilman
2012-10-11 18:28 ` Paul Walmsley
2012-10-11 18:28 ` Paul Walmsley
2012-10-12 16:24 ` Sourav
2012-10-12 16:24 ` Sourav
2012-10-12 16:24 ` Sourav
2012-10-12 16:35 ` Kevin Hilman
2012-10-12 16:35 ` Kevin Hilman
2012-10-12 16:35 ` Kevin Hilman
2012-10-12 16:42 ` Russell King - ARM Linux
2012-10-12 16:42 ` Russell King - ARM Linux
2012-10-12 17:29 ` Poddar, Sourav
2012-10-12 17:29 ` Poddar, Sourav
2012-10-12 17:29 ` Poddar, Sourav
2012-10-12 18:49 ` Russell King - ARM Linux
2012-10-12 18:49 ` Russell King - ARM Linux
2012-10-12 18:49 ` Russell King - ARM Linux
2012-10-12 17:59 ` Kevin Hilman
2012-10-12 17:59 ` Kevin Hilman
2012-10-12 18:54 ` Russell King - ARM Linux
2012-10-12 18:54 ` Russell King - ARM Linux
2012-10-12 20:32 ` Kevin Hilman
2012-10-12 20:32 ` Kevin Hilman
2012-10-12 21:51 ` Tony Lindgren
2012-10-12 21:51 ` Tony Lindgren
2012-10-15 22:37 ` Kevin Hilman
2012-10-15 22:37 ` Kevin Hilman
2012-09-25 11:15 ` Russell King - ARM Linux
2012-09-25 11:15 ` Russell King - ARM Linux
2012-09-26 20:30 ` Greg KH
2012-09-26 20:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347972050-3509-1-git-send-email-sourav.poddar@ti.com \
--to=sourav.poddar@ti.com \
--cc=alan@linux.intel.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.