All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Santos <daniel.santos@pobox.com>
To: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-sparse@vger.kernel.org,
	Akinobu Mita <akinobu.mita@gmail.com>,
	Andi Kleen <ak@linux.intel.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christopher Li <sparse@chrisli.org>,
	David Daney <david.daney@cavium.com>,
	David Howells <dhowells@redhat.com>,
	David Rientjes <rientjes@google.com>,
	David Woodhouse <David.Woodhouse@intel.com>,
	Don Zickus <dzickus@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Cc: Daniel Santos <daniel.santos@pobox.com>
Subject: [PATCH v6 3/25] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro
Date: Thu, 27 Sep 2012 20:54:19 -0500	[thread overview]
Message-ID: <1348797281-25021-4-git-send-email-daniel.santos@pobox.com> (raw)
In-Reply-To: <1348797281-25021-1-git-send-email-daniel.santos@pobox.com>

Throughout compiler*.h, many version checks are made.  These can be
simplified by using the macro that gcc's documentation recommends.
However, my primary reason for adding this is that I need bug-check
macros that are enabled at certain gcc versions and it's cleaner to use
this macro than the tradition method:

if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ => 2)

If you add patch level, it gets this ugly:

if __GNUC__ > 4 || (__GNUC__ == 4 && (__GNUC_MINOR__ > 2 || \
   __GNUC_MINOR__ == 2 __GNUC_PATCHLEVEL__ >= 1))

As opposed to:

if GCC_VERSION >= 40201

While having separate headers for gcc 3 & 4 eliminates some of this
verbosity, they can still be cleaned up by this.

See also:
http://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html

Signed-off-by: Daniel Santos <daniel.santos@pobox.com>
---
 include/linux/compiler-gcc.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 6a6d7ae..24545cd 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -5,6 +5,9 @@
 /*
  * Common definitions for all gcc versions go here.
  */
+#define GCC_VERSION (__GNUC__ * 10000 \
+		   + __GNUC_MINOR__ * 100 \
+		   + __GNUC_PATCHLEVEL__)
 
 
 /* Optimization barrier */
-- 
1.7.3.4


  parent reply	other threads:[~2012-09-28  1:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-28  1:54 [PATCH v6 0/25] Generic Red-Black Trees Daniel Santos
2012-09-28  1:54 ` [PATCH v6 1/25] compiler-gcc4.h: Correct verion check for __compiletime_error Daniel Santos
2012-09-28  1:54 ` [PATCH v6 2/25] compiler-gcc4.h: Reorder macros based upon gcc ver Daniel Santos
2012-09-28  1:54 ` Daniel Santos [this message]
2012-09-28  1:54 ` [PATCH v6 4/25] compiler-gcc{3,4}.h: Use GCC_VERSION macro Daniel Santos
2012-10-01 19:39   ` Andrew Morton
2012-10-01 20:32     ` Josh Triplett
2012-10-01 20:43       ` Daniel Santos
2012-09-28  1:54 ` [PATCH v6 5/25] compiler{,-gcc4}.h: Remove duplicate macros Daniel Santos
2012-09-28  1:54 ` [PATCH v6 6/25] bug.h: Replace __linktime_error with __compiletime_error Daniel Santos
2012-09-28  1:54 ` [PATCH v6 7/25] compiler{,-gcc4}.h: Introduce __flatten function attribute Daniel Santos
2012-10-01 19:43 ` [PATCH v6 0/25] Generic Red-Black Trees Andrew Morton
2012-10-01 20:41   ` Daniel Santos
2012-10-01 20:47     ` Andrew Morton
2012-10-03 15:18       ` Daniel Santos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348797281-25021-4-git-send-email-daniel.santos@pobox.com \
    --to=daniel.santos@pobox.com \
    --cc=David.Woodhouse@intel.com \
    --cc=aarcange@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david.daney@cavium.com \
    --cc=dhowells@redhat.com \
    --cc=dzickus@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=sparse@chrisli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.