From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: sage@inktank.com, ceph-devel@vger.kernel.org
Cc: "Yan, Zheng" <zheng.z.yan@intel.com>
Subject: [PATCH 12/12] mds: Avoid creating unnecessary snaprealm
Date: Tue, 2 Oct 2012 16:55:52 +0800 [thread overview]
Message-ID: <1349168152-13281-12-git-send-email-zheng.z.yan@intel.com> (raw)
In-Reply-To: <1349168152-13281-1-git-send-email-zheng.z.yan@intel.com>
From: "Yan, Zheng" <zheng.z.yan@intel.com>
When moving directory between snaprealms, we can avoid creating snaprealm
if the directory doesn't has its own snaprealm and directory was created
after both realms' newest snapshot.
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
---
src/mds/Server.cc | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index e16800e..b706b5a 100644
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -4577,7 +4577,8 @@ void Server::_unlink_local(MDRequest *mdr, CDentry *dn, CDentry *straydn)
mdcache->predirty_journal_parents(mdr, &le->metablob, in, straydn->get_dir(), PREDIRTY_PRIMARY|PREDIRTY_DIR, 1);
// project snaprealm, too
- in->project_past_snaprealm_parent(straydn->get_dir()->inode->find_snaprealm());
+ if (in->snaprealm || follows + 1 > dn->first)
+ in->project_past_snaprealm_parent(straydn->get_dir()->inode->find_snaprealm());
le->metablob.add_primary_dentry(straydn, true, in);
} else {
@@ -5247,11 +5248,16 @@ void Server::handle_client_rename(MDRequest *mdr)
}
// moving between snaprealms?
- if (srcdnl->is_primary() && !srci->snaprealm &&
- srci->find_snaprealm() != destdn->get_dir()->inode->find_snaprealm()) {
- dout(10) << " renaming between snaprealms, creating snaprealm for " << *srci << dendl;
- mds->mdcache->snaprealm_create(mdr, srci);
- return;
+ if (srcdnl->is_primary() && srci->is_multiversion() && !srci->snaprealm) {
+ SnapRealm *srcrealm = srci->find_snaprealm();
+ SnapRealm *destrealm = destdn->get_dir()->inode->find_snaprealm();
+ if (srcrealm != destrealm &&
+ (srcrealm->get_newest_seq() + 1 > srcdn->first ||
+ destrealm->get_newest_seq() + 1 > srcdn->first)) {
+ dout(10) << " renaming between snaprealms, creating snaprealm for " << *srci << dendl;
+ mds->mdcache->snaprealm_create(mdr, srci);
+ return;
+ }
}
assert(g_conf->mds_kill_rename_at != 1);
@@ -5650,6 +5656,7 @@ void Server::_rename_prepare(MDRequest *mdr,
if (destdn->is_auth())
mdcache->predirty_journal_parents(mdr, metablob, srci, destdn->get_dir(), flags, 1);
+ SnapRealm *src_realm = srci->find_snaprealm();
SnapRealm *dest_realm = destdn->get_dir()->inode->find_snaprealm();
snapid_t next_dest_snap = dest_realm->get_newest_seq() + 1;
@@ -5659,7 +5666,8 @@ void Server::_rename_prepare(MDRequest *mdr,
if (destdnl->is_primary()) {
if (destdn->is_auth()) {
// project snaprealm, too
- oldin->project_past_snaprealm_parent(straydn->get_dir()->inode->find_snaprealm());
+ if (oldin->snaprealm || src_realm->get_newest_seq() + 1 > srcdn->first)
+ oldin->project_past_snaprealm_parent(straydn->get_dir()->inode->find_snaprealm());
straydn->first = MAX(oldin->first, next_dest_snap);
metablob->add_primary_dentry(straydn, true, oldin);
}
@@ -5703,7 +5711,8 @@ void Server::_rename_prepare(MDRequest *mdr,
}
} else if (srcdnl->is_primary()) {
// project snap parent update?
- if (destdn->is_auth() && srci->snaprealm)
+ if (destdn->is_auth() &&
+ (srci->snaprealm || src_realm->get_newest_seq() + 1 > srcdn->first))
srci->project_past_snaprealm_parent(dest_realm);
if (destdn->is_auth() && !destdnl->is_null())
--
1.7.11.4
next prev parent reply other threads:[~2012-10-02 8:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 8:55 [PATCH 01/12] mds: Don't drop client request from MDS Yan, Zheng
2012-10-02 8:55 ` [PATCH 02/12] mds: Consider stopping MDS when finding peer inode Yan, Zheng
2012-10-02 8:55 ` [PATCH 03/12] mds: Add finish callback to waiting_for_base_ino wait queue Yan, Zheng
2012-10-02 8:55 ` [PATCH 04/12] mds: Allow rename request for stray migration/reintegration Yan, Zheng
2012-10-02 8:55 ` [PATCH 05/12] mds: Fix xlock imports Yan, Zheng
2012-10-02 8:55 ` [PATCH 06/12] mds: Set metablob.renamed_dirino in do_rename_rollback() Yan, Zheng
2012-10-02 8:55 ` [PATCH 07/12] mds: Avoid save unnecessary parent snaprealm Yan, Zheng
2012-10-02 8:55 ` [PATCH 08/12] mds: Allow export subtrees in other MDS' stray directory Yan, Zheng
2012-10-02 8:55 ` [PATCH 09/12] mds: Properly update dirty dir fragstat during log replay Yan, Zheng
2012-10-02 8:55 ` [PATCH 10/12] mds: Trim non auth subtree directory Yan, Zheng
2012-10-02 8:55 ` [PATCH 11/12] mds: Properly re-calculate mdsdir inode's auth bit Yan, Zheng
2012-10-02 8:55 ` Yan, Zheng [this message]
2012-10-02 18:31 ` [PATCH 12/12] mds: Avoid creating unnecessary snaprealm Sage Weil
2012-10-02 23:45 ` Yan, Zheng
2012-10-03 0:12 ` Sage Weil
2012-10-03 11:44 ` Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349168152-13281-12-git-send-email-zheng.z.yan@intel.com \
--to=zheng.z.yan@intel.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.