[RFC 2/4] drm: make memset/calloc for _vblank_time more robust

From: Imre Deak <imre.deak@intel.com>
To: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Kristian Høgsberg" <krh@bitplanet.net>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [RFC 2/4] drm: make memset/calloc for _vblank_time more robust
Date: Fri,  5 Oct 2012 16:37:00 +0300	[thread overview]
Message-ID: <1349444222-22274-3-git-send-email-imre.deak@intel.com> (raw)
In-Reply-To: <1349444222-22274-1-git-send-email-imre.deak@intel.com>

Using sizeof(*var) instead of sizeof(var_type) allows changing var_type
w/o breaking callers that depend on the size.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/drm_irq.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
index 076c4a8..77f6577 100644
--- a/drivers/gpu/drm/drm_irq.c
+++ b/drivers/gpu/drm/drm_irq.c
@@ -90,7 +90,7 @@ int drm_irq_by_busid(struct drm_device *dev, void *data,
 static void clear_vblank_timestamps(struct drm_device *dev, int crtc)
 {
 	memset(&dev->_vblank_time[crtc * DRM_VBLANKTIME_RBSIZE], 0,
-		DRM_VBLANKTIME_RBSIZE * sizeof(struct timeval));
+		DRM_VBLANKTIME_RBSIZE * sizeof(dev->_vblank_time[0]));
 }
 
 /*
@@ -248,7 +248,7 @@ int drm_vblank_init(struct drm_device *dev, int num_crtcs)
 		goto err;
 
 	dev->_vblank_time = kcalloc(num_crtcs * DRM_VBLANKTIME_RBSIZE,
-				    sizeof(struct timeval), GFP_KERNEL);
+				    sizeof(dev->_vblank_time[0]), GFP_KERNEL);
 	if (!dev->_vblank_time)
 		goto err;
 
-- 
1.7.9.5
