All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Patil, Rachna" <rachna@ti.com>
To: <linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>,
	<linux-iio@vger.kernel.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Dmitry Torokhov <dtor@mail.ru>,
	Jonathan Cameron <jic23@cam.ac.uk>,
	"Patil, Rachna" <rachna@ti.com>
Subject: [PATCH RESEND 4/8] input: TSC: ti_tscadc: Remove definition of End Of Interrupt register
Date: Tue, 16 Oct 2012 12:55:41 +0530	[thread overview]
Message-ID: <1350372345-27108-5-git-send-email-rachna@ti.com> (raw)
In-Reply-To: <1350372345-27108-1-git-send-email-rachna@ti.com>

The touchscreen IP uses level sensitive interrupts rather
than edge sensitive interrupts and therefore the is no need
to use the EOI register to have the module re-strobe the
interrupt line if there pending interrupts exist.

Signed-off-by: Patil, Rachna <rachna@ti.com>
---
 drivers/input/touchscreen/ti_tscadc.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/input/touchscreen/ti_tscadc.c b/drivers/input/touchscreen/ti_tscadc.c
index 2cc19b0..ec0a442 100644
--- a/drivers/input/touchscreen/ti_tscadc.c
+++ b/drivers/input/touchscreen/ti_tscadc.c
@@ -27,7 +27,6 @@
 #include <linux/input/ti_tscadc.h>
 #include <linux/delay.h>
 
-#define REG_IRQEOI		0x020
 #define REG_RAWIRQSTATUS	0x024
 #define REG_IRQSTATUS		0x028
 #define REG_IRQENABLE		0x02C
@@ -330,8 +329,6 @@ static irqreturn_t tscadc_irq(int irq, void *dev)
 	}
 
 	tscadc_writel(ts_dev, REG_IRQSTATUS, irqclr);
-	/* check pending interrupts */
-	tscadc_writel(ts_dev, REG_IRQEOI, 0x0);
 
 	tscadc_writel(ts_dev, REG_SE, STPENB_STEPENB);
 	return IRQ_HANDLED;
-- 
1.7.0.4


WARNING: multiple messages have this Message-ID (diff)
From: "Patil, Rachna" <rachna@ti.com>
To: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	linux-iio@vger.kernel.org
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Dmitry Torokhov <dtor@mail.ru>,
	Jonathan Cameron <jic23@cam.ac.uk>,
	"Patil, Rachna" <rachna@ti.com>
Subject: [PATCH RESEND 4/8] input: TSC: ti_tscadc: Remove definition of End Of Interrupt register
Date: Tue, 16 Oct 2012 12:55:41 +0530	[thread overview]
Message-ID: <1350372345-27108-5-git-send-email-rachna@ti.com> (raw)
In-Reply-To: <1350372345-27108-1-git-send-email-rachna@ti.com>

The touchscreen IP uses level sensitive interrupts rather
than edge sensitive interrupts and therefore the is no need
to use the EOI register to have the module re-strobe the
interrupt line if there pending interrupts exist.

Signed-off-by: Patil, Rachna <rachna@ti.com>
---
 drivers/input/touchscreen/ti_tscadc.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/input/touchscreen/ti_tscadc.c b/drivers/input/touchscreen/ti_tscadc.c
index 2cc19b0..ec0a442 100644
--- a/drivers/input/touchscreen/ti_tscadc.c
+++ b/drivers/input/touchscreen/ti_tscadc.c
@@ -27,7 +27,6 @@
 #include <linux/input/ti_tscadc.h>
 #include <linux/delay.h>
 
-#define REG_IRQEOI		0x020
 #define REG_RAWIRQSTATUS	0x024
 #define REG_IRQSTATUS		0x028
 #define REG_IRQENABLE		0x02C
@@ -330,8 +329,6 @@ static irqreturn_t tscadc_irq(int irq, void *dev)
 	}
 
 	tscadc_writel(ts_dev, REG_IRQSTATUS, irqclr);
-	/* check pending interrupts */
-	tscadc_writel(ts_dev, REG_IRQEOI, 0x0);
 
 	tscadc_writel(ts_dev, REG_SE, STPENB_STEPENB);
 	return IRQ_HANDLED;
-- 
1.7.0.4

  parent reply	other threads:[~2012-10-16  7:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16  7:25 [PATCH RESEND 0/8] TI Touchscreen driver updates and Support for TSC/ADC MFD driver Patil, Rachna
2012-10-16  7:25 ` Patil, Rachna
2012-10-16  7:25 ` [PATCH RESEND 1/8] input: TSC: ti_tscadc: Correct register usage Patil, Rachna
2012-10-16  7:25   ` Patil, Rachna
2012-10-16  7:25 ` [PATCH RESEND 2/8] input: TSC: ti_tscadc: Add Step configuration as platform data Patil, Rachna
2012-10-16  7:25   ` Patil, Rachna
2012-10-16  7:25 ` [PATCH RESEND 3/8] input: TSC: ti_tscadc: set FIFO0 threshold Interrupt Patil, Rachna
2012-10-16  7:25   ` Patil, Rachna
2012-10-16  7:25 ` Patil, Rachna [this message]
2012-10-16  7:25   ` [PATCH RESEND 4/8] input: TSC: ti_tscadc: Remove definition of End Of Interrupt register Patil, Rachna
2012-10-16  7:25 ` [PATCH RESEND 5/8] input: TSC: ti_tscadc: Rename the existing touchscreen driver Patil, Rachna
2012-10-16  7:25   ` Patil, Rachna
2012-10-16  7:25 ` [PATCH RESEND 6/8] MFD: ti_tscadc: Add support for TI's TSC/ADC MFDevice Patil, Rachna
2012-10-16  7:25   ` Patil, Rachna
2012-10-16  7:25 ` [PATCH RESEND 7/8] input: TSC: ti_tsc: Convert TSC into a MFDevice Patil, Rachna
2012-10-16  7:25   ` Patil, Rachna
2012-10-16  7:25 ` [PATCH RESEND 8/8] IIO : ADC: tiadc: Add support of TI's ADC driver Patil, Rachna
2012-10-16  7:25   ` Patil, Rachna
2012-10-16 17:42 ` [PATCH RESEND 0/8] TI Touchscreen driver updates and Support for TSC/ADC MFD driver Dmitry Torokhov
2012-10-17  6:11   ` Patil, Rachna
2012-10-29  7:13   ` Patil, Rachna
2012-10-29  7:13     ` Patil, Rachna
2012-10-22 10:46 ` Patil, Rachna
2012-11-05 22:55 ` Samuel Ortiz
2012-11-05 22:55   ` Samuel Ortiz
2012-11-06  4:47   ` Patil, Rachna
2012-11-06  4:47     ` Patil, Rachna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350372345-27108-5-git-send-email-rachna@ti.com \
    --to=rachna@ti.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dtor@mail.ru \
    --cc=jic23@cam.ac.uk \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.