All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: xen-devel@lists.xen.org
Cc: "David Vrabel" <david.vrabel@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [PATCH 5/5] xen-kbdfront: handle backend CLOSED without CLOSING
Date: Thu, 18 Oct 2012 11:03:38 +0100	[thread overview]
Message-ID: <1350554618-14582-5-git-send-email-david.vrabel@citrix.com> (raw)
In-Reply-To: <507FD39F.4060601@citrix.com>

From: David Vrabel <david.vrabel@citrix.com>

Backend drivers shouldn't transistion to CLOSED unless the frontend is
CLOSED.  If a backend does transition to CLOSED too soon then the
frontend may not see the CLOSING state and will not properly shutdown.

So, treat an unexpected backend CLOSED state the same as CLOSING.

Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
Cc: linux-input@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/misc/xen-kbdfront.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
index 02ca868..6f7d990 100644
--- a/drivers/input/misc/xen-kbdfront.c
+++ b/drivers/input/misc/xen-kbdfront.c
@@ -311,7 +311,6 @@ static void xenkbd_backend_changed(struct xenbus_device *dev,
 	case XenbusStateReconfiguring:
 	case XenbusStateReconfigured:
 	case XenbusStateUnknown:
-	case XenbusStateClosed:
 		break;
 
 	case XenbusStateInitWait:
@@ -350,6 +349,10 @@ InitWait:
 
 		break;
 
+	case XenbusStateClosed:
+		if (dev->state == XenbusStateClosed)
+			break;
+		/* Missed the backend's CLOSING state -- fallthrough */
 	case XenbusStateClosing:
 		xenbus_frontend_closed(dev);
 		break;
-- 
1.7.2.5


  parent reply	other threads:[~2012-10-18 10:04 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18 10:02 [PATCH 0/5] drivers: xen frontend devices should handle missed backend CLOSING David Vrabel
2012-10-18 10:02 ` David Vrabel
2012-10-18 10:02 ` David Vrabel
2012-10-18 10:03 ` [PATCH 1/5] xen-netfront: handle backend CLOSED without CLOSING David Vrabel
2012-10-18 10:03 ` David Vrabel
2012-10-18 10:03 ` [PATCH 2/5] xen-blkfront: " David Vrabel
2012-10-18 10:03 ` David Vrabel
2012-10-18 10:03 ` [PATCH 3/5] xen-pcifront: " David Vrabel
2012-10-18 10:03 ` David Vrabel
2012-10-19 12:59   ` Konrad Rzeszutek Wilk
2012-10-19 12:59   ` Konrad Rzeszutek Wilk
2012-11-30 18:41     ` Bjorn Helgaas
2012-11-30 21:42       ` Bjorn Helgaas
2012-11-30 22:39         ` Konrad Rzeszutek Wilk
2012-11-30 22:39         ` Konrad Rzeszutek Wilk
2012-11-30 21:42       ` Bjorn Helgaas
2012-11-30 18:41     ` Bjorn Helgaas
2012-10-18 10:03 ` [PATCH 4/5] xen-fbfront: " David Vrabel
2012-10-18 10:03   ` David Vrabel
2012-10-19 13:00   ` Konrad Rzeszutek Wilk
2012-10-19 13:00     ` Konrad Rzeszutek Wilk
2012-10-23  4:50     ` Florian Tobias Schandinat
2012-10-23  4:50       ` Florian Tobias Schandinat
2012-10-23  4:50     ` Florian Tobias Schandinat
2012-10-19 13:00   ` Konrad Rzeszutek Wilk
2012-10-18 10:03 ` David Vrabel
2012-10-18 10:03 ` [PATCH 5/5] xen-kbdfront: " David Vrabel
2012-10-18 10:03 ` David Vrabel [this message]
2012-10-19 13:00   ` Konrad Rzeszutek Wilk
2012-10-19 13:00   ` Konrad Rzeszutek Wilk
2012-10-19 13:00     ` Konrad Rzeszutek Wilk
2012-10-19 16:34     ` Dmitry Torokhov
2012-10-19 16:34     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350554618-14582-5-git-send-email-david.vrabel@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.