All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sourav Poddar <sourav.poddar@ti.com>
To: <tony@atomide.com>, <b-cousson@ti.com>
Cc: <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree-discuss@lists.ozlabs.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-input@vger.kernel.org>,
	Sourav Poddar <sourav.poddar@ti.com>, Felipe Balbi <balbi@ti.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [PATCHv2] Input: omap4-keypad: Add pinctrl support
Date: Mon, 22 Oct 2012 18:43:00 +0530	[thread overview]
Message-ID: <1350911580-20307-1-git-send-email-sourav.poddar@ti.com> (raw)

Adapt keypad to use pinctrl framework.

Tested on omap4430 sdp with 3.7-rc1 kernel.

Cc: Felipe Balbi <balbi@ti.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
v1->v2
- Added "PROBE_DEFER" check 
 drivers/input/keyboard/omap4-keypad.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c
index c05f98c..502b832 100644
--- a/drivers/input/keyboard/omap4-keypad.c
+++ b/drivers/input/keyboard/omap4-keypad.c
@@ -31,6 +31,7 @@
 #include <linux/input.h>
 #include <linux/slab.h>
 #include <linux/pm_runtime.h>
+#include <linux/pinctrl/consumer.h>
 
 #include <linux/platform_data/omap4-keypad.h>
 
@@ -76,6 +77,7 @@ enum {
 
 struct omap4_keypad {
 	struct input_dev *input;
+	struct pinctrl	*pins;
 
 	void __iomem *base;
 	unsigned int irq;
@@ -298,6 +300,15 @@ static int __devinit omap4_keypad_probe(struct platform_device *pdev)
 		goto err_release_mem;
 	}
 
+	keypad_data->pins = devm_pinctrl_get_select_default(&pdev->dev);
+	if (IS_ERR(keypad_data->pins)) {
+		if (PTR_ERR(keypad_data->pins) == -EPROBE_DEFER)
+			return -EPROBE_DEFER;
+
+		dev_warn(&pdev->dev, "did not get pins for keypad error: %li\n",
+					PTR_ERR(keypad_data->pins));
+		keypad_data->pins = NULL;
+	}
 
 	/*
 	 * Enable clocks for the keypad module so that we can read
-- 
1.7.1


WARNING: multiple messages have this Message-ID (diff)
From: Sourav Poddar <sourav.poddar@ti.com>
To: tony@atomide.com, b-cousson@ti.com
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	linux-input@vger.kernel.org, Sourav Poddar <sourav.poddar@ti.com>,
	Felipe Balbi <balbi@ti.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [PATCHv2] Input: omap4-keypad: Add pinctrl support
Date: Mon, 22 Oct 2012 18:43:00 +0530	[thread overview]
Message-ID: <1350911580-20307-1-git-send-email-sourav.poddar@ti.com> (raw)

Adapt keypad to use pinctrl framework.

Tested on omap4430 sdp with 3.7-rc1 kernel.

Cc: Felipe Balbi <balbi@ti.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
v1->v2
- Added "PROBE_DEFER" check 
 drivers/input/keyboard/omap4-keypad.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c
index c05f98c..502b832 100644
--- a/drivers/input/keyboard/omap4-keypad.c
+++ b/drivers/input/keyboard/omap4-keypad.c
@@ -31,6 +31,7 @@
 #include <linux/input.h>
 #include <linux/slab.h>
 #include <linux/pm_runtime.h>
+#include <linux/pinctrl/consumer.h>
 
 #include <linux/platform_data/omap4-keypad.h>
 
@@ -76,6 +77,7 @@ enum {
 
 struct omap4_keypad {
 	struct input_dev *input;
+	struct pinctrl	*pins;
 
 	void __iomem *base;
 	unsigned int irq;
@@ -298,6 +300,15 @@ static int __devinit omap4_keypad_probe(struct platform_device *pdev)
 		goto err_release_mem;
 	}
 
+	keypad_data->pins = devm_pinctrl_get_select_default(&pdev->dev);
+	if (IS_ERR(keypad_data->pins)) {
+		if (PTR_ERR(keypad_data->pins) == -EPROBE_DEFER)
+			return -EPROBE_DEFER;
+
+		dev_warn(&pdev->dev, "did not get pins for keypad error: %li\n",
+					PTR_ERR(keypad_data->pins));
+		keypad_data->pins = NULL;
+	}
 
 	/*
 	 * Enable clocks for the keypad module so that we can read
-- 
1.7.1


WARNING: multiple messages have this Message-ID (diff)
From: sourav.poddar@ti.com (Sourav Poddar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] Input: omap4-keypad: Add pinctrl support
Date: Mon, 22 Oct 2012 18:43:00 +0530	[thread overview]
Message-ID: <1350911580-20307-1-git-send-email-sourav.poddar@ti.com> (raw)

Adapt keypad to use pinctrl framework.

Tested on omap4430 sdp with 3.7-rc1 kernel.

Cc: Felipe Balbi <balbi@ti.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
v1->v2
- Added "PROBE_DEFER" check 
 drivers/input/keyboard/omap4-keypad.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c
index c05f98c..502b832 100644
--- a/drivers/input/keyboard/omap4-keypad.c
+++ b/drivers/input/keyboard/omap4-keypad.c
@@ -31,6 +31,7 @@
 #include <linux/input.h>
 #include <linux/slab.h>
 #include <linux/pm_runtime.h>
+#include <linux/pinctrl/consumer.h>
 
 #include <linux/platform_data/omap4-keypad.h>
 
@@ -76,6 +77,7 @@ enum {
 
 struct omap4_keypad {
 	struct input_dev *input;
+	struct pinctrl	*pins;
 
 	void __iomem *base;
 	unsigned int irq;
@@ -298,6 +300,15 @@ static int __devinit omap4_keypad_probe(struct platform_device *pdev)
 		goto err_release_mem;
 	}
 
+	keypad_data->pins = devm_pinctrl_get_select_default(&pdev->dev);
+	if (IS_ERR(keypad_data->pins)) {
+		if (PTR_ERR(keypad_data->pins) == -EPROBE_DEFER)
+			return -EPROBE_DEFER;
+
+		dev_warn(&pdev->dev, "did not get pins for keypad error: %li\n",
+					PTR_ERR(keypad_data->pins));
+		keypad_data->pins = NULL;
+	}
 
 	/*
 	 * Enable clocks for the keypad module so that we can read
-- 
1.7.1

             reply	other threads:[~2012-10-22 13:12 UTC|newest]

Thread overview: 162+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 13:13 Sourav Poddar [this message]
2012-10-22 13:13 ` [PATCHv2] Input: omap4-keypad: Add pinctrl support Sourav Poddar
2012-10-22 13:13 ` Sourav Poddar
2012-10-22 15:50 ` Dmitry Torokhov
2012-10-22 15:50   ` Dmitry Torokhov
2012-10-23  9:13   ` Linus Walleij
2012-10-23  9:13     ` Linus Walleij
2012-10-23  9:35     ` Benoit Cousson
2012-10-23  9:35       ` Benoit Cousson
2012-10-23  9:35       ` Benoit Cousson
2012-10-23 10:04       ` Linus Walleij
2012-10-23 10:04         ` Linus Walleij
2012-10-23 10:03         ` Felipe Balbi
2012-10-23 10:03           ` Felipe Balbi
2012-10-23 10:03           ` Felipe Balbi
2012-10-23 10:23           ` Thomas Petazzoni
2012-10-23 10:23             ` Thomas Petazzoni
2012-10-23 10:29             ` Linus Walleij
2012-10-23 10:29               ` Linus Walleij
2012-10-23 10:29               ` Felipe Balbi
2012-10-23 10:29                 ` Felipe Balbi
2012-10-23 10:29                 ` Felipe Balbi
2012-10-23 10:45                 ` Linus Walleij
2012-10-23 10:45                   ` Linus Walleij
2012-10-23 10:42                   ` Felipe Balbi
2012-10-23 10:42                     ` Felipe Balbi
2012-10-23 10:42                     ` Felipe Balbi
2012-10-23 11:11                   ` Thomas Petazzoni
2012-10-23 11:11                     ` Thomas Petazzoni
2012-10-23 17:02           ` Mitch Bradley
2012-10-23 17:02             ` Mitch Bradley
2012-10-23 17:20             ` Felipe Balbi
2012-10-23 17:20               ` Felipe Balbi
2012-10-23 17:20               ` Felipe Balbi
2012-10-23 17:51               ` Mitch Bradley
2012-10-23 17:51                 ` Mitch Bradley
2012-10-23 17:51                 ` Felipe Balbi
2012-10-23 17:51                   ` Felipe Balbi
2012-10-23 17:51                   ` Felipe Balbi
2012-10-23  9:18   ` Benoit Cousson
2012-10-23  9:18     ` Benoit Cousson
2012-10-23  9:18     ` Benoit Cousson
2012-10-23 20:02     ` Dmitry Torokhov
2012-10-23 20:02       ` Dmitry Torokhov
2012-10-24  8:37       ` Felipe Balbi
2012-10-24  8:37         ` Felipe Balbi
2012-10-24  8:37         ` Felipe Balbi
2012-10-24 16:14         ` Dmitry Torokhov
2012-10-24 16:14           ` Dmitry Torokhov
2012-10-24 16:51           ` Linus Walleij
2012-10-24 16:51             ` Linus Walleij
2012-10-24 17:28             ` Dmitry Torokhov
2012-10-24 17:28               ` Dmitry Torokhov
2012-10-24 18:58               ` Felipe Balbi
2012-10-24 18:58                 ` Felipe Balbi
2012-10-24 18:58                 ` Felipe Balbi
2012-10-25 20:59                 ` Mark Brown
2012-10-25 20:59                   ` Mark Brown
2012-10-25 20:59                   ` Mark Brown
2012-10-26  6:20                   ` Felipe Balbi
2012-10-26  6:20                     ` Felipe Balbi
2012-10-26  6:20                     ` Felipe Balbi
2012-10-26 16:03                     ` Mark Brown
2012-10-26 16:03                       ` Mark Brown
2012-10-29 19:49                       ` Felipe Balbi
2012-10-29 19:49                         ` Felipe Balbi
2012-10-29 19:49                         ` Felipe Balbi
2012-10-30 11:24                         ` Mark Brown
2012-10-30 11:24                           ` Mark Brown
2012-10-30 11:49                           ` Felipe Balbi
2012-10-30 11:49                             ` Felipe Balbi
2012-10-30 11:49                             ` Felipe Balbi
2012-10-30 14:07                             ` Mark Brown
2012-10-30 14:07                               ` Mark Brown
2012-10-30 14:16                               ` Linus Walleij
2012-10-30 14:16                                 ` Linus Walleij
2012-10-30 14:54                                 ` Mark Brown
2012-10-30 14:54                                   ` Mark Brown
2012-10-30 15:16                               ` Felipe Balbi
2012-10-30 15:16                                 ` Felipe Balbi
2012-10-30 15:16                                 ` Felipe Balbi
2012-10-30 15:58                                 ` Mark Brown
2012-10-30 15:58                                   ` Mark Brown
2012-10-30 17:25                                   ` Felipe Balbi
2012-10-30 17:25                                     ` Felipe Balbi
2012-10-30 17:25                                     ` Felipe Balbi
2012-10-30 18:20                                     ` Dmitry Torokhov
2012-10-30 18:20                                       ` Dmitry Torokhov
2012-10-30 18:48                                       ` Felipe Balbi
2012-10-30 18:48                                         ` Felipe Balbi
2012-10-30 18:48                                         ` Felipe Balbi
2012-10-30 18:37                                     ` Mark Brown
2012-10-30 18:37                                       ` Mark Brown
2012-10-30 21:51                                       ` Linus Walleij
2012-10-30 21:51                                         ` Linus Walleij
2012-10-30 22:57                                         ` Rafael J. Wysocki
2012-10-30 22:57                                           ` Rafael J. Wysocki
2012-11-02 18:26                                         ` Mark Brown
2012-11-02 18:26                                           ` Mark Brown
2012-10-30 14:11                             ` Linus Walleij
2012-10-30 14:11                               ` Linus Walleij
2012-10-28 20:12               ` Linus Walleij
2012-10-28 20:12                 ` Linus Walleij
2012-10-30 11:34                 ` Mark Brown
2012-10-30 11:34                   ` Mark Brown
2012-10-30 11:34                   ` Mark Brown
2012-10-30 14:02                   ` Linus Walleij
2012-10-30 14:02                     ` Linus Walleij
2012-10-30 14:37                     ` Mark Brown
2012-10-30 14:37                       ` Mark Brown
2012-10-31 20:10                     ` Kevin Hilman
2012-10-31 20:10                       ` Kevin Hilman
     [not found]                       ` <87obji8kta.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2012-11-01  8:54                         ` Linus Walleij
2012-11-01  8:54                           ` Linus Walleij
2012-11-01  8:56                           ` Fwd: " Linus Walleij
2012-11-01  8:56                             ` Linus Walleij
2012-11-01 11:42                             ` Kevin Hilman
2012-11-01 11:42                               ` Kevin Hilman
2012-11-01 13:22                               ` Linus Walleij
2012-11-01 13:22                                 ` Linus Walleij
2012-11-01 12:07                           ` Mark Brown
2012-11-01 12:07                             ` Mark Brown
2012-11-01 14:01                             ` Linus Walleij
2012-11-01 14:01                               ` Linus Walleij
2012-11-01 14:19                               ` Mark Brown
2012-11-01 14:19                                 ` Mark Brown
2012-11-11 12:32                               ` Linus Walleij
2012-11-11 12:32                                 ` Linus Walleij
2012-10-31 13:19                 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-31 13:19                   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-24 16:52           ` Felipe Balbi
2012-10-24 16:52             ` Felipe Balbi
2012-10-24 16:52             ` Felipe Balbi
2012-10-24 17:13             ` Linus Walleij
2012-10-24 17:13               ` Linus Walleij
2012-10-24 17:34             ` Dmitry Torokhov
2012-10-24 17:34               ` Dmitry Torokhov
2012-10-24 17:46           ` Benoit Cousson
2012-10-24 17:46             ` Benoit Cousson
2012-10-24 17:46             ` Benoit Cousson
2012-10-24 12:54       ` Linus Walleij
2012-10-24 12:54         ` Linus Walleij
2012-10-24 16:18         ` Dmitry Torokhov
2012-10-24 16:18           ` Dmitry Torokhov
2012-10-24 16:57           ` Felipe Balbi
2012-10-24 16:57             ` Felipe Balbi
2012-10-24 16:57             ` Felipe Balbi
2012-10-24 17:18             ` Linus Walleij
2012-10-24 17:18               ` Linus Walleij
2012-10-24 17:58             ` Dmitry Torokhov
2012-10-24 17:58               ` Dmitry Torokhov
2012-10-24 19:10               ` Felipe Balbi
2012-10-24 19:10                 ` Felipe Balbi
2012-10-24 19:10                 ` Felipe Balbi
2012-10-24 19:38                 ` Dmitry Torokhov
2012-10-24 19:38                   ` Dmitry Torokhov
2012-10-24 19:38                   ` Dmitry Torokhov
2012-10-24 19:51                   ` Felipe Balbi
2012-10-24 19:51                     ` Felipe Balbi
2012-10-24 19:51                     ` Felipe Balbi
2012-10-24 17:01           ` Linus Walleij
2012-10-24 17:01             ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350911580-20307-1-git-send-email-sourav.poddar@ti.com \
    --to=sourav.poddar@ti.com \
    --cc=b-cousson@ti.com \
    --cc=balbi@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.