All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
	linux-kernel@vger.kernel.org, michael.brantley@deshaw.com,
	hch@infradead.org, miklos@szeredi.hu, pstaubach@exagrid.com
Subject: [PATCH v8 01/32] vfs: add a retry_estale helper function to handle retries on ESTALE
Date: Sat, 27 Oct 2012 08:33:08 -0400	[thread overview]
Message-ID: <1351341219-17837-2-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1351341219-17837-1-git-send-email-jlayton@redhat.com>

This function is expected to be called from path-based syscalls to help
them decide whether to try the lookup and call again in the event that
they got an -ESTALE return back on an earier try.

Currently, we only retry the call once on an ESTALE error, but in the
event that we decide that that's not enough in the future, we should be
able to change the logic in this helper without too much effort.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
 include/linux/fs.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index b33cfc9..01ff902 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2023,6 +2023,27 @@ extern int finish_open(struct file *file, struct dentry *dentry,
 			int *opened);
 extern int finish_no_open(struct file *file, struct dentry *dentry);
 
+/**
+ * retry_estale - determine whether the caller should retry an operation
+ *
+ * @error: the error we'll be returning
+ * @try: number of retries already performed
+ *
+ * Check to see if the error code was -ESTALE, and then determine whether
+ * to retry the call based on the number of retries so far. Currently, we only
+ * retry the call once.
+ *
+ * Returns true if the caller should try again.
+ */
+static inline bool
+retry_estale(const long error, const unsigned int try)
+{
+	if (likely(error != -ESTALE))
+		return false;
+
+	return !try;
+}
+
 /* fs/ioctl.c */
 
 extern int ioctl_preallocate(struct file *filp, void __user *argp);
-- 
1.7.11.7


  reply	other threads:[~2012-10-27 12:43 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-27 12:33 [PATCH v8 00/32] vfs: add the ability to retry lookup and operation to most path-based syscalls Jeff Layton
2012-10-27 12:33 ` Jeff Layton [this message]
2012-10-27 12:33 ` [PATCH v8 02/32] vfs: make fstatat retry on ESTALE errors from getattr call Jeff Layton
2012-10-27 12:33 ` [PATCH v8 03/32] vfs: fix readlinkat to retry on ESTALE Jeff Layton
2012-10-27 12:33 ` [PATCH v8 04/32] vfs: add new "reval" argument to kern_path_create and user_path_create Jeff Layton
2012-10-27 12:33 ` [PATCH v8 05/32] vfs: fix mknodat to retry on ESTALE errors Jeff Layton
2012-10-27 12:33 ` [PATCH v8 06/32] vfs: fix mkdir " Jeff Layton
2012-10-27 12:33   ` Jeff Layton
2012-10-27 12:33 ` [PATCH v8 07/32] vfs: fix symlinkat " Jeff Layton
2012-10-27 12:33 ` [PATCH v8 08/32] vfs: fix linkat " Jeff Layton
2012-10-27 12:33 ` [PATCH v8 09/32] vfs: add a reval argument to user_path_parent Jeff Layton
2012-10-27 12:33 ` [PATCH v8 10/32] vfs: make rmdir retry on ESTALE errors Jeff Layton
2012-10-27 12:33   ` Jeff Layton
2012-10-27 12:33 ` [PATCH v8 11/32] vfs: make do_unlinkat " Jeff Layton
2012-10-30 16:14   ` J. Bruce Fields
2012-10-30 16:14     ` J. Bruce Fields
2012-10-30 16:33     ` Jeff Layton
2012-10-30 16:33       ` Jeff Layton
2012-10-30 19:28       ` J. Bruce Fields
2012-10-30 19:28         ` J. Bruce Fields
2012-10-30 19:45         ` Jeff Layton
2012-10-30 19:45           ` Jeff Layton
2012-10-27 12:33 ` [PATCH v8 12/32] vfs: fix renameat to " Jeff Layton
2012-10-27 12:33 ` [PATCH v8 13/32] vfs: have do_sys_truncate retry once on an ESTALE error Jeff Layton
2012-10-27 12:33 ` [PATCH v8 14/32] vfs: have faccessat " Jeff Layton
2012-10-27 12:33 ` [PATCH v8 15/32] vfs: have chdir retry lookup and call once on " Jeff Layton
2012-10-27 12:33 ` [PATCH v8 16/32] vfs: make chroot retry " Jeff Layton
2012-10-27 12:33   ` Jeff Layton
2012-10-27 12:33 ` [PATCH v8 17/32] vfs: make fchmodat retry once on ESTALE errors Jeff Layton
2012-10-27 12:33 ` [PATCH v8 18/32] vfs: make fchownat " Jeff Layton
2012-10-27 12:33 ` [PATCH v8 19/32] vfs: fix user_statfs to " Jeff Layton
2012-10-27 12:33 ` [PATCH v8 20/32] vfs: allow utimensat() calls to retry once on an ESTALE error Jeff Layton
2012-10-27 12:33 ` [PATCH v8 21/32] vfs: allow setxattr to retry once on ESTALE errors Jeff Layton
2012-10-27 12:33   ` Jeff Layton
2012-10-27 12:33 ` [PATCH v8 22/32] vfs: allow lsetxattr() " Jeff Layton
2012-10-27 12:33   ` Jeff Layton
2012-10-27 12:33 ` [PATCH v8 23/32] vfs: make getxattr retry once on an ESTALE error Jeff Layton
2012-10-27 12:33 ` [PATCH v8 24/32] vfs: make lgetxattr retry once on ESTALE Jeff Layton
2012-10-27 12:33 ` [PATCH v8 25/32] vfs: make listxattr retry once on ESTALE error Jeff Layton
2012-10-27 12:33 ` [PATCH v8 26/32] vfs: make llistxattr " Jeff Layton
2012-10-27 12:33 ` [PATCH v8 27/32] vfs: make removexattr retry once on ESTALE Jeff Layton
2012-10-27 12:33 ` [PATCH v8 28/32] vfs: make lremovexattr retry once on ESTALE error Jeff Layton
2012-10-27 12:33 ` [PATCH v8 29/32] vfs: convert do_filp_open to use retry_estale helper Jeff Layton
2012-10-27 12:33 ` [PATCH v8 30/32] vfs: convert do_file_open_root " Jeff Layton
2012-10-27 12:33 ` [PATCH v8 31/32] vfs: convert filename_lookup " Jeff Layton
2012-10-27 12:33 ` [PATCH v8 32/32] vfs: make number of ESTALE retries tunable Jeff Layton
2012-10-27 12:33   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351341219-17837-2-git-send-email-jlayton@redhat.com \
    --to=jlayton@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=michael.brantley@deshaw.com \
    --cc=miklos@szeredi.hu \
    --cc=pstaubach@exagrid.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.