All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <levinsasha928@gmail.com>
To: torvalds@linux-foundation.org
Cc: tj@kernel.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	paul.gortmaker@windriver.com, davem@davemloft.net,
	rostedt@goodmis.org, mingo@elte.hu, ebiederm@xmission.com,
	aarcange@redhat.com, ericvh@gmail.com, netdev@vger.kernel.org,
	josh@joshtriplett.org, eric.dumazet@gmail.com,
	mathieu.desnoyers@efficios.com, axboe@kernel.dk, agk@redhat.com,
	dm-devel@redhat.com, neilb@suse.de, ccaulfie@redhat.com,
	teigland@redhat.com, Trond.Myklebust@netapp.com,
	bfields@fieldses.org, fweisbec@gmail.com, jesse@nicira.com,
	venkat.x.venkatsubra@oracle.com, ejt@redhat.com,
	snitzer@redhat.com, edumazet@google.com,
	linux-nfs@vger.kernel.org, dev@openvswitch.org,
	rds-devel@oss.oracle.com, lw@cn.fujitsu.com,
	Sasha Levin <levinsasha928@gmail.com>
Subject: [PATCH v8 09/16] SUNRPC/cache: use new hashtable implementation
Date: Tue, 30 Oct 2012 14:46:05 -0400	[thread overview]
Message-ID: <1351622772-16400-9-git-send-email-levinsasha928@gmail.com> (raw)
In-Reply-To: <1351622772-16400-1-git-send-email-levinsasha928@gmail.com>

Switch cache to use the new hashtable implementation. This reduces the amount
of generic unrelated code in the cache implementation.

Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
 net/sunrpc/cache.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
index fc2f7aa..eaf9693 100644
--- a/net/sunrpc/cache.c
+++ b/net/sunrpc/cache.c
@@ -28,6 +28,7 @@
 #include <linux/workqueue.h>
 #include <linux/mutex.h>
 #include <linux/pagemap.h>
+#include <linux/hashtable.h>
 #include <asm/ioctls.h>
 #include <linux/sunrpc/types.h>
 #include <linux/sunrpc/cache.h>
@@ -524,19 +525,18 @@ EXPORT_SYMBOL_GPL(cache_purge);
  * it to be revisited when cache info is available
  */
 
-#define	DFR_HASHSIZE	(PAGE_SIZE/sizeof(struct list_head))
-#define	DFR_HASH(item)	((((long)item)>>4 ^ (((long)item)>>13)) % DFR_HASHSIZE)
+#define	DFR_HASH_BITS	9
 
 #define	DFR_MAX	300	/* ??? */
 
 static DEFINE_SPINLOCK(cache_defer_lock);
 static LIST_HEAD(cache_defer_list);
-static struct hlist_head cache_defer_hash[DFR_HASHSIZE];
+static DEFINE_HASHTABLE(cache_defer_hash, DFR_HASH_BITS);
 static int cache_defer_cnt;
 
 static void __unhash_deferred_req(struct cache_deferred_req *dreq)
 {
-	hlist_del_init(&dreq->hash);
+	hash_del(&dreq->hash);
 	if (!list_empty(&dreq->recent)) {
 		list_del_init(&dreq->recent);
 		cache_defer_cnt--;
@@ -545,10 +545,7 @@ static void __unhash_deferred_req(struct cache_deferred_req *dreq)
 
 static void __hash_deferred_req(struct cache_deferred_req *dreq, struct cache_head *item)
 {
-	int hash = DFR_HASH(item);
-
-	INIT_LIST_HEAD(&dreq->recent);
-	hlist_add_head(&dreq->hash, &cache_defer_hash[hash]);
+	hash_add(cache_defer_hash, &dreq->hash, (unsigned long)item);
 }
 
 static void setup_deferral(struct cache_deferred_req *dreq,
@@ -600,7 +597,7 @@ static void cache_wait_req(struct cache_req *req, struct cache_head *item)
 		 * to clean up
 		 */
 		spin_lock(&cache_defer_lock);
-		if (!hlist_unhashed(&sleeper.handle.hash)) {
+		if (hash_hashed(&sleeper.handle.hash)) {
 			__unhash_deferred_req(&sleeper.handle);
 			spin_unlock(&cache_defer_lock);
 		} else {
@@ -671,12 +668,11 @@ static void cache_revisit_request(struct cache_head *item)
 	struct cache_deferred_req *dreq;
 	struct list_head pending;
 	struct hlist_node *lp, *tmp;
-	int hash = DFR_HASH(item);
 
 	INIT_LIST_HEAD(&pending);
 	spin_lock(&cache_defer_lock);
 
-	hlist_for_each_entry_safe(dreq, lp, tmp, &cache_defer_hash[hash], hash)
+	hash_for_each_possible_safe(cache_defer_hash, dreq, lp, tmp, hash, (unsigned long)item)
 		if (dreq->item == item) {
 			__unhash_deferred_req(dreq);
 			list_add(&dreq->recent, &pending);
-- 
1.7.12.4


WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <levinsasha928@gmail.com>
To: torvalds@linux-foundation.org
Cc: tj@kernel.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	paul.gortmaker@windriver.com, davem@davemloft.net,
	rostedt@goodmis.org, mingo@elte.hu, ebiederm@xmission.com,
	aarcange@redhat.com, ericvh@gmail.com, netdev@vger.kernel.org,
	josh@joshtriplett.org, eric.dumazet@gmail.com,
	mathieu.desnoyers@efficios.com, axboe@kernel.dk, agk@redhat.com,
	dm-devel@redhat.com, neilb@suse.de, ccaulfie@redhat.com,
	teigland@redhat.com, Trond.Myklebust@netapp.com,
	bfields@fieldses.org, fweisbec@gmail.com, jesse@nicira.com,
	venkat.x.venkatsubra@oracle.com, ejt@redhat.com,
	snitzer@redhat.com, edumazet@google.com,
	linux-nfs@vger.kernel.org, dev@openvswitch.org,
	rds-devel@oss.oracle.com, lw@cn.fujitsu.com,
	Sasha Levin <levinsasha928@gmail.com>
Subject: [PATCH v8 09/16] SUNRPC/cache: use new hashtable implementation
Date: Tue, 30 Oct 2012 14:46:05 -0400	[thread overview]
Message-ID: <1351622772-16400-9-git-send-email-levinsasha928@gmail.com> (raw)
In-Reply-To: <1351622772-16400-1-git-send-email-levinsasha928@gmail.com>

Switch cache to use the new hashtable implementation. This reduces the amount
of generic unrelated code in the cache implementation.

Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
 net/sunrpc/cache.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
index fc2f7aa..eaf9693 100644
--- a/net/sunrpc/cache.c
+++ b/net/sunrpc/cache.c
@@ -28,6 +28,7 @@
 #include <linux/workqueue.h>
 #include <linux/mutex.h>
 #include <linux/pagemap.h>
+#include <linux/hashtable.h>
 #include <asm/ioctls.h>
 #include <linux/sunrpc/types.h>
 #include <linux/sunrpc/cache.h>
@@ -524,19 +525,18 @@ EXPORT_SYMBOL_GPL(cache_purge);
  * it to be revisited when cache info is available
  */
 
-#define	DFR_HASHSIZE	(PAGE_SIZE/sizeof(struct list_head))
-#define	DFR_HASH(item)	((((long)item)>>4 ^ (((long)item)>>13)) % DFR_HASHSIZE)
+#define	DFR_HASH_BITS	9
 
 #define	DFR_MAX	300	/* ??? */
 
 static DEFINE_SPINLOCK(cache_defer_lock);
 static LIST_HEAD(cache_defer_list);
-static struct hlist_head cache_defer_hash[DFR_HASHSIZE];
+static DEFINE_HASHTABLE(cache_defer_hash, DFR_HASH_BITS);
 static int cache_defer_cnt;
 
 static void __unhash_deferred_req(struct cache_deferred_req *dreq)
 {
-	hlist_del_init(&dreq->hash);
+	hash_del(&dreq->hash);
 	if (!list_empty(&dreq->recent)) {
 		list_del_init(&dreq->recent);
 		cache_defer_cnt--;
@@ -545,10 +545,7 @@ static void __unhash_deferred_req(struct cache_deferred_req *dreq)
 
 static void __hash_deferred_req(struct cache_deferred_req *dreq, struct cache_head *item)
 {
-	int hash = DFR_HASH(item);
-
-	INIT_LIST_HEAD(&dreq->recent);
-	hlist_add_head(&dreq->hash, &cache_defer_hash[hash]);
+	hash_add(cache_defer_hash, &dreq->hash, (unsigned long)item);
 }
 
 static void setup_deferral(struct cache_deferred_req *dreq,
@@ -600,7 +597,7 @@ static void cache_wait_req(struct cache_req *req, struct cache_head *item)
 		 * to clean up
 		 */
 		spin_lock(&cache_defer_lock);
-		if (!hlist_unhashed(&sleeper.handle.hash)) {
+		if (hash_hashed(&sleeper.handle.hash)) {
 			__unhash_deferred_req(&sleeper.handle);
 			spin_unlock(&cache_defer_lock);
 		} else {
@@ -671,12 +668,11 @@ static void cache_revisit_request(struct cache_head *item)
 	struct cache_deferred_req *dreq;
 	struct list_head pending;
 	struct hlist_node *lp, *tmp;
-	int hash = DFR_HASH(item);
 
 	INIT_LIST_HEAD(&pending);
 	spin_lock(&cache_defer_lock);
 
-	hlist_for_each_entry_safe(dreq, lp, tmp, &cache_defer_hash[hash], hash)
+	hash_for_each_possible_safe(cache_defer_hash, dreq, lp, tmp, hash, (unsigned long)item)
 		if (dreq->item == item) {
 			__unhash_deferred_req(dreq);
 			list_add(&dreq->recent, &pending);
-- 
1.7.12.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2012-10-30 18:47 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-30 18:45 [PATCH v8 01/16] hashtable: introduce a small and naive hashtable Sasha Levin
2012-10-30 18:45 ` Sasha Levin
2012-10-30 18:45 ` [PATCH v8 02/16] userns: use new hashtable implementation Sasha Levin
2012-10-30 18:45   ` Sasha Levin
2012-10-30 18:45   ` Sasha Levin
2012-10-30 18:45 ` [PATCH v8 03/16] mm,ksm: " Sasha Levin
2012-10-30 18:45   ` Sasha Levin
2012-10-30 18:46 ` [PATCH v8 04/16] workqueue: " Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46 ` [PATCH v8 05/16] mm/huge_memory: " Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46 ` [PATCH v8 06/16] tracepoint: " Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 19:20   ` Mathieu Desnoyers
2012-10-30 19:20     ` Mathieu Desnoyers
2012-10-30 18:46 ` [PATCH v8 07/16] net,9p: " Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46   ` [PATCH v8 07/16] net, 9p: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 08/16] block,elevator: " Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46   ` [PATCH v8 08/16] block, elevator: " Sasha Levin
2012-10-30 18:46 ` Sasha Levin [this message]
2012-10-30 18:46   ` [PATCH v8 09/16] SUNRPC/cache: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 10/16] dlm: " Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46 ` [PATCH v8 11/16] net,l2tp: " Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46   ` [PATCH v8 11/16] net, l2tp: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 12/16] dm: " Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46 ` [PATCH v8 13/16] lockd: " Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46 ` [PATCH v8 14/16] net,rds: " Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46   ` [PATCH v8 14/16] net, rds: " Sasha Levin
2012-10-30 18:46 ` [PATCH v8 15/16] openvswitch: " Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46 ` [PATCH v8 16/16] tracing output: " Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 18:46   ` Sasha Levin
2012-10-30 19:23   ` Steven Rostedt
2012-10-30 19:23     ` Steven Rostedt
2012-10-30 19:23     ` Steven Rostedt
2012-10-30 19:19 ` [PATCH v8 01/16] hashtable: introduce a small and naive hashtable Mathieu Desnoyers
2012-10-30 19:19   ` Mathieu Desnoyers
2012-10-30 19:19   ` Mathieu Desnoyers
2012-10-30 21:42 ` Tejun Heo
2012-10-30 21:42   ` Tejun Heo
2012-10-31  0:33   ` Sasha Levin
2012-10-31  0:33     ` Sasha Levin
2012-10-31  0:51     ` Jim Rees
2012-10-31  0:51       ` Jim Rees
2012-10-31  0:51       ` Jim Rees
2012-10-31  1:15       ` Sasha Levin
2012-10-31  1:15         ` Sasha Levin
2012-10-31  1:15         ` Sasha Levin
2012-10-31  1:16     ` Steven Rostedt
2012-10-31  1:16       ` Steven Rostedt
2012-10-31  1:16       ` Steven Rostedt
2012-10-31  1:25       ` Linus Torvalds
2012-10-31  1:25         ` Linus Torvalds
2012-10-31  1:25         ` Linus Torvalds
2012-10-31  1:36         ` Sasha Levin
2012-10-31  1:36           ` Sasha Levin
2012-10-31  2:23           ` Linus Torvalds
2012-10-31  2:23             ` Linus Torvalds
2012-10-31  2:23             ` Linus Torvalds
2012-11-02  4:23             ` Sasha Levin
2012-11-02  4:23               ` Sasha Levin
2012-11-02  4:23               ` Sasha Levin
2012-10-31  1:36         ` Steven Rostedt
2012-10-31  1:36           ` Steven Rostedt
2012-10-31  1:36           ` Steven Rostedt
2012-10-31  2:24         ` Al Viro
2012-10-31  2:24           ` Al Viro
2012-10-31  2:48           ` Linus Torvalds
2012-10-31  2:48             ` Linus Torvalds
2012-10-31  3:24             ` Al Viro
2012-10-31  3:24               ` Al Viro
2012-10-31  3:24               ` Al Viro
2012-10-31  3:48               ` Linus Torvalds
2012-10-31  3:48                 ` Linus Torvalds
2012-10-31  3:48                 ` Linus Torvalds
2012-10-31  9:46       ` David Laight
2012-10-31  9:46         ` David Laight
2012-10-31  9:46         ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351622772-16400-9-git-send-email-levinsasha928@gmail.com \
    --to=levinsasha928@gmail.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=aarcange@redhat.com \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=bfields@fieldses.org \
    --cc=ccaulfie@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=dm-devel@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=edumazet@google.com \
    --cc=ejt@redhat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=ericvh@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jesse@nicira.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=lw@cn.fujitsu.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@elte.hu \
    --cc=neilb@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=rds-devel@oss.oracle.com \
    --cc=rostedt@goodmis.org \
    --cc=snitzer@redhat.com \
    --cc=teigland@redhat.com \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=venkat.x.venkatsubra@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.