All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Cc: devicetree-discuss@lists.ozlabs.org, robherring2@gmail.com,
	linux-omap@vger.kernel.org, jon-hunter@ti.com, x0148406@ti.com,
	tony@atomide.com, paul@pwsan.com, nsekhar@ti.com,
	Daniel Mack <zonque@gmail.com>
Subject: [PATCH v2 3/4] ARM: OMAP: gpmc: don't create devices from initcall on DT
Date: Thu,  1 Nov 2012 19:36:09 +0100	[thread overview]
Message-ID: <1351794970-14675-4-git-send-email-zonque@gmail.com> (raw)
In-Reply-To: <1351794970-14675-1-git-send-email-zonque@gmail.com>

On DT driven boards, the gpmc node will match the driver. Hence, there's
no need to do that unconditionally from the initcall.

Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 arch/arm/mach-omap2/gpmc.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 60f1cce..1dcb30c 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -844,6 +844,13 @@ static int __init omap_gpmc_init(void)
 	struct platform_device *pdev;
 	char *oh_name = "gpmc";
 
+	/*
+	 * if the board boots up with a populated DT, do not
+	 * manually add the device from this initcall
+	 */
+	if (of_have_populated_dt())
+		return -ENODEV;
+
 	oh = omap_hwmod_lookup(oh_name);
 	if (!oh) {
 		pr_err("Could not look up %s\n", oh_name);
-- 
1.7.11.7


WARNING: multiple messages have this Message-ID (diff)
From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] ARM: OMAP: gpmc: don't create devices from initcall on DT
Date: Thu,  1 Nov 2012 19:36:09 +0100	[thread overview]
Message-ID: <1351794970-14675-4-git-send-email-zonque@gmail.com> (raw)
In-Reply-To: <1351794970-14675-1-git-send-email-zonque@gmail.com>

On DT driven boards, the gpmc node will match the driver. Hence, there's
no need to do that unconditionally from the initcall.

Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 arch/arm/mach-omap2/gpmc.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 60f1cce..1dcb30c 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -844,6 +844,13 @@ static int __init omap_gpmc_init(void)
 	struct platform_device *pdev;
 	char *oh_name = "gpmc";
 
+	/*
+	 * if the board boots up with a populated DT, do not
+	 * manually add the device from this initcall
+	 */
+	if (of_have_populated_dt())
+		return -ENODEV;
+
 	oh = omap_hwmod_lookup(oh_name);
 	if (!oh) {
 		pr_err("Could not look up %s\n", oh_name);
-- 
1.7.11.7

  parent reply	other threads:[~2012-11-01 18:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01 18:36 [PATCH v2 0/4] RFC: OMAP GPMC DT bindings Daniel Mack
2012-11-01 18:36 ` Daniel Mack
2012-11-01 18:36 ` [PATCH v2 1/4] mtd: omap-nand: pass device_node in platform data Daniel Mack
2012-11-01 18:36   ` Daniel Mack
2012-11-01 18:36 ` [PATCH v2 2/4] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs Daniel Mack
2012-11-01 18:36   ` Daniel Mack
2012-11-01 18:36 ` Daniel Mack [this message]
2012-11-01 18:36   ` [PATCH v2 3/4] ARM: OMAP: gpmc: don't create devices from initcall on DT Daniel Mack
2012-11-01 18:36 ` [PATCH v2 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND Daniel Mack
2012-11-01 18:36   ` Daniel Mack
2012-11-02 10:41   ` Jon Hunter
2012-11-02 10:41     ` Jon Hunter
2012-11-02 11:14     ` Daniel Mack
2012-11-02 11:14       ` Daniel Mack
     [not found]       ` <5093AB14.9090402-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-02 19:18         ` Jon Hunter
2012-11-02 19:18           ` Jon Hunter
2012-11-02 19:23           ` Daniel Mack
2012-11-02 19:23             ` Daniel Mack
2012-11-02 19:57             ` Jon Hunter
2012-11-02 19:57               ` Jon Hunter
2012-11-02 20:23               ` Daniel Mack
2012-11-02 20:23                 ` Daniel Mack
2012-11-05 21:46                 ` Jon Hunter
2012-11-05 21:46                   ` Jon Hunter
2012-11-06  0:42                   ` Daniel Mack
2012-11-06  0:42                     ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351794970-14675-4-git-send-email-zonque@gmail.com \
    --to=zonque@gmail.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=jon-hunter@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=paul@pwsan.com \
    --cc=robherring2@gmail.com \
    --cc=tony@atomide.com \
    --cc=x0148406@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.