All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
To: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
	tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
	b-cousson-l0cyMroinI0@public.gmane.org,
	w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
Subject: [PATCHv2 7/7] i2c: omap: Restore i2c context always
Date: Sun, 4 Nov 2012 16:14:33 +0530	[thread overview]
Message-ID: <1352025873-27492-8-git-send-email-shubhrajyoti@ti.com> (raw)
In-Reply-To: <1352025873-27492-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>

Currently the restore is done based on the flag
OMAP_I2C_FLAG_RESET_REGS_POSTIDLE.

This helps the following
- The driver is always capable of restoring regardless
of the off mode support being there or not.

- While testing omap2430 it is found that in case of certain
error paths (timeout) a reset is done. However the restore
never happens as it is dependent on the POSTIDLE flag.
The other option would be to call a restore in the reset
case. As there are only a few registers to be restored
the penalty in the idle case should not be much.

Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
---
Todo: the flag could be deleted if the patch is accepted.

 drivers/i2c/busses/i2c-omap.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 70d43b7..f66c5ab 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1314,8 +1314,7 @@ static int omap_i2c_runtime_resume(struct device *dev)
 	if (!_dev->regs)
 		return 0;
 
-	if (_dev->flags & OMAP_I2C_FLAG_RESET_REGS_POSTIDLE)
-		__omap_i2c_init(_dev);
+	__omap_i2c_init(_dev);
 
 	return 0;
 }
-- 
1.7.5.4

WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti D)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 7/7] i2c: omap: Restore i2c context always
Date: Sun, 4 Nov 2012 16:14:33 +0530	[thread overview]
Message-ID: <1352025873-27492-8-git-send-email-shubhrajyoti@ti.com> (raw)
In-Reply-To: <1352025873-27492-1-git-send-email-shubhrajyoti@ti.com>

Currently the restore is done based on the flag
OMAP_I2C_FLAG_RESET_REGS_POSTIDLE.

This helps the following
- The driver is always capable of restoring regardless
of the off mode support being there or not.

- While testing omap2430 it is found that in case of certain
error paths (timeout) a reset is done. However the restore
never happens as it is dependent on the POSTIDLE flag.
The other option would be to call a restore in the reset
case. As there are only a few registers to be restored
the penalty in the idle case should not be much.

Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
Todo: the flag could be deleted if the patch is accepted.

 drivers/i2c/busses/i2c-omap.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 70d43b7..f66c5ab 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1314,8 +1314,7 @@ static int omap_i2c_runtime_resume(struct device *dev)
 	if (!_dev->regs)
 		return 0;
 
-	if (_dev->flags & OMAP_I2C_FLAG_RESET_REGS_POSTIDLE)
-		__omap_i2c_init(_dev);
+	__omap_i2c_init(_dev);
 
 	return 0;
 }
-- 
1.7.5.4

  parent reply	other threads:[~2012-11-04 10:44 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-04 10:44 [PATCHv2 0/7] i2c: omap: updates Shubhrajyoti D
2012-11-04 10:44 ` Shubhrajyoti D
2012-11-04 10:44 ` [PATCHv2 5/7] i2c: omap: re-factor omap_i2c_init function Shubhrajyoti D
2012-11-04 10:44   ` Shubhrajyoti D
     [not found]   ` <1352025873-27492-6-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05  7:54     ` Felipe Balbi
2012-11-05  7:54       ` Felipe Balbi
2012-11-04 10:44 ` [PATCHv2 6/7] i2c: omap: make reset a seperate function Shubhrajyoti D
2012-11-04 10:44   ` Shubhrajyoti D
2012-11-05  7:55   ` Felipe Balbi
2012-11-05  7:55     ` Felipe Balbi
     [not found] ` <1352025873-27492-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-04 10:44   ` [PATCHv2 1/7] i2c: omap: Fix the revision register read Shubhrajyoti D
2012-11-04 10:44     ` Shubhrajyoti D
     [not found]     ` <1352025873-27492-2-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05  7:50       ` Felipe Balbi
2012-11-05  7:50         ` Felipe Balbi
2012-11-05  8:34         ` Shubhrajyoti
2012-11-05  8:34           ` Shubhrajyoti
     [not found]           ` <50977A30.6040907-l0cyMroinI0@public.gmane.org>
2012-11-05  9:04             ` Felipe Balbi
2012-11-05  9:04               ` Felipe Balbi
2012-11-05  9:24               ` Shubhrajyoti Datta
2012-11-05  9:24                 ` Shubhrajyoti Datta
2012-11-05 10:01                 ` Felipe Balbi
2012-11-05 10:01                   ` Felipe Balbi
     [not found]                   ` <20121105100105.GC3327-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-05 10:45                     ` Felipe Balbi
2012-11-05 10:45                       ` Felipe Balbi
2012-11-05  9:40               ` Shubhrajyoti Datta
2012-11-05  9:40                 ` Shubhrajyoti Datta
2012-11-04 10:44   ` [PATCHv2 2/7] i2c: omap: use revision check for OMAP_I2C_FLAG_APPLY_ERRATA_I207 Shubhrajyoti D
2012-11-04 10:44     ` Shubhrajyoti D
     [not found]     ` <1352025873-27492-3-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05  7:51       ` Felipe Balbi
2012-11-05  7:51         ` Felipe Balbi
2012-11-04 10:44   ` [PATCHv2 3/7] i2c: omap: remove the dtrev Shubhrajyoti D
2012-11-04 10:44     ` Shubhrajyoti D
     [not found]     ` <1352025873-27492-4-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05  7:53       ` Felipe Balbi
2012-11-05  7:53         ` Felipe Balbi
     [not found]         ` <20121105075320.GD32468-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-05  8:44           ` Shubhrajyoti
2012-11-05  8:44             ` Shubhrajyoti
2012-11-05  9:05             ` Felipe Balbi
2012-11-05  9:05               ` Felipe Balbi
     [not found]               ` <20121105090517.GB2913-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-05  9:26                 ` Shubhrajyoti
2012-11-05  9:26                   ` Shubhrajyoti
2012-11-04 10:44   ` [PATCHv2 4/7] ARM: i2c: omap: Remove the i207 errata flag Shubhrajyoti D
2012-11-04 10:44     ` Shubhrajyoti D
     [not found]     ` <1352025873-27492-5-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05  7:53       ` Felipe Balbi
2012-11-05  7:53         ` Felipe Balbi
2012-11-04 10:44   ` Shubhrajyoti D [this message]
2012-11-04 10:44     ` [PATCHv2 7/7] i2c: omap: Restore i2c context always Shubhrajyoti D
     [not found]     ` <1352025873-27492-8-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05  7:56       ` Felipe Balbi
2012-11-05  7:56         ` Felipe Balbi
2012-11-05  7:46 ` [PATCHv2 0/7] i2c: omap: updates Felipe Balbi
2012-11-05  7:46   ` Felipe Balbi
2012-11-05  8:34   ` Shubhrajyoti
2012-11-05  8:34     ` Shubhrajyoti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352025873-27492-8-git-send-email-shubhrajyoti@ti.com \
    --to=shubhrajyoti-l0cymroini0@public.gmane.org \
    --cc=b-cousson-l0cyMroinI0@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.