All of lore.kernel.org
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/30] dma: mv_xor: do not use pool_size from platform_data within the driver
Date: Mon, 19 Nov 2012 11:04:40 +0100	[thread overview]
Message-ID: <1353319508-30566-3-git-send-email-thomas.petazzoni@free-electrons.com> (raw)
In-Reply-To: <1353319508-30566-1-git-send-email-thomas.petazzoni@free-electrons.com>

The driver currently pokes into the platform_data structure during its
normal operation to get the pool_size value. Poking into the
platform_data structure is not nice when moving to the Device Tree, so
this commit adds a new pool_size field in the mv_xor_device structure,
which gets initialized at ->probe() time. The driver then uses this
field instead of the platform_data.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 drivers/dma/mv_xor.c |   10 ++++------
 drivers/dma/mv_xor.h |    1 +
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
index 610d0b8..7042772 100644
--- a/drivers/dma/mv_xor.c
+++ b/drivers/dma/mv_xor.c
@@ -604,9 +604,7 @@ static int mv_xor_alloc_chan_resources(struct dma_chan *chan)
 	int idx;
 	struct mv_xor_chan *mv_chan = to_mv_xor_chan(chan);
 	struct mv_xor_desc_slot *slot = NULL;
-	struct mv_xor_platform_data *plat_data =
-		mv_chan->device->pdev->dev.platform_data;
-	int num_descs_in_pool = plat_data->pool_size/MV_XOR_SLOT_SIZE;
+	int num_descs_in_pool = mv_chan->device->pool_size/MV_XOR_SLOT_SIZE;
 
 	/* Allocate descriptor slots */
 	idx = mv_chan->slots_allocated;
@@ -1084,11 +1082,10 @@ static int __devexit mv_xor_remove(struct platform_device *dev)
 	struct mv_xor_device *device = platform_get_drvdata(dev);
 	struct dma_chan *chan, *_chan;
 	struct mv_xor_chan *mv_chan;
-	struct mv_xor_platform_data *plat_data = dev->dev.platform_data;
 
 	dma_async_device_unregister(&device->common);
 
-	dma_free_coherent(&dev->dev, plat_data->pool_size,
+	dma_free_coherent(&dev->dev, device->pool_size,
 			device->dma_desc_pool_virt, device->dma_desc_pool);
 
 	list_for_each_entry_safe(chan, _chan, &device->common.channels,
@@ -1120,8 +1117,9 @@ static int __devinit mv_xor_probe(struct platform_device *pdev)
 	 * note: writecombine gives slightly better performance, but
 	 * requires that we explicitly flush the writes
 	 */
+	adev->pool_size = plat_data->pool_size;
 	adev->dma_desc_pool_virt = dma_alloc_writecombine(&pdev->dev,
-							  plat_data->pool_size,
+							  adev->pool_size,
 							  &adev->dma_desc_pool,
 							  GFP_KERNEL);
 	if (!adev->dma_desc_pool_virt)
diff --git a/drivers/dma/mv_xor.h b/drivers/dma/mv_xor.h
index a5b422f..a0641ae 100644
--- a/drivers/dma/mv_xor.h
+++ b/drivers/dma/mv_xor.h
@@ -72,6 +72,7 @@ struct mv_xor_device {
 	int				id;
 	dma_addr_t			dma_desc_pool;
 	void				*dma_desc_pool_virt;
+	size_t                          pool_size;
 	struct dma_device		common;
 	struct mv_xor_shared_private	*shared;
 };
-- 
1.7.9.5

  parent reply	other threads:[~2012-11-19 10:04 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 10:04 [GIT PULL] Marvell XOR driver cleanup and DT binding Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 01/30] dma: mv_xor: use dev_(err|info|notice) instead of dev_printk Thomas Petazzoni
2012-11-19 10:04 ` Thomas Petazzoni [this message]
2012-11-19 10:04 ` [PATCH 03/30] dma: mv_xor: split initialization/cleanup of XOR channels Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 04/30] dma: mv_xor: allow channels to be registered directly from the main device Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 05/30] arm: plat-orion: convert the registration of the xor0 engine to the single driver Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 06/30] arm: plat-orion: convert the registration of the xor1 " Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 07/30] arm: plat-orion: remove unused orion_xor_init_channels() Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 08/30] dma: mv_xor: remove sub-driver 'mv_xor' Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 09/30] dma: mv_xor: remove 'shared' from mv_xor_platform_data Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 10/30] dma: mv_xor: rename mv_xor_platform_data to mv_xor_channel_data Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 11/30] dma: mv_xor: rename mv_xor_shared_platform_data to mv_xor_platform_data Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 12/30] dma: mv_xor: change the driver name to 'mv_xor' Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 13/30] dma: mv_xor: rename many symbols to remove the 'shared' word Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 14/30] dma: mv_xor: remove unused id field in mv_xor_device structure Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 15/30] dma: mv_xor: remove unused to_mv_xor_device() macro Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 16/30] dma: mv_xor: simplify dma_sync_single_for_cpu() calls Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 17/30] dma: mv_xor: introduce a mv_chan_to_devp() helper Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 18/30] dma: mv_xor: get rid of the pdev pointer in mv_xor_device Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 19/30] dma: mv_xor: in mv_xor_chan, rename 'common' to 'dmachan' Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 20/30] dma: mv_xor: in mv_xor_device, rename 'common' to 'dmadev' Thomas Petazzoni
2012-11-19 10:04 ` [PATCH 21/30] dma: mv_xor: use mv_xor_chan pointers as arguments to self-test functions Thomas Petazzoni
2012-11-19 10:05 ` [PATCH 22/30] dma: mv_xor: merge mv_xor_device and mv_xor_chan Thomas Petazzoni
2012-11-19 10:05 ` [PATCH 23/30] dma: mv_xor: rename mv_xor_private to mv_xor_device Thomas Petazzoni
2012-11-19 10:05 ` [PATCH 24/30] dma: mv_xor: remove useless backpointer from mv_xor_chan " Thomas Petazzoni
2012-11-19 10:05 ` [PATCH 25/30] dma: mv_xor: remove hw_id field from platform_data Thomas Petazzoni
2012-11-19 10:05 ` [PATCH 26/30] dma: mv_xor: remove the pool_size " Thomas Petazzoni
2012-11-19 10:05 ` [PATCH 27/30] dma: mv_xor: add missing free_irq() call Thomas Petazzoni
     [not found] ` <1353319508-30566-1-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2012-11-19 10:05   ` [PATCH 28/30] dma: mv_xor: add Device Tree binding Thomas Petazzoni
2012-11-19 10:05     ` Thomas Petazzoni
2012-11-19 10:05 ` [PATCH 29/30] dma: mv_xor: add missing __devinit and __devexit qualifiers on probe and remove Thomas Petazzoni
2012-11-19 10:05 ` [PATCH 30/30] dma: mv_xor: Add a device_control function Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353319508-30566-3-git-send-email-thomas.petazzoni@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.