All of lore.kernel.org
 help / color / mirror / Atom feed
From: bjschuma@netapp.com
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v3 04/10] NFSD: Clean up forgetting locks
Date: Tue, 27 Nov 2012 09:35:13 -0500	[thread overview]
Message-ID: <1354026919-13313-5-git-send-email-bjschuma@netapp.com> (raw)
In-Reply-To: <1354026919-13313-1-git-send-email-bjschuma@netapp.com>

From: Bryan Schumaker <bjschuma@netapp.com>

I use the new "forget_n_state()" function to iterate through each client
first when searching for locks.  This may slow down forgetting locks a
little bit, but it implements most of the code needed to forget a
specified client's locks.

Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
---
 fs/nfsd/nfs4state.c | 36 ++++++++++++++++++++++++++++--------
 1 file changed, 28 insertions(+), 8 deletions(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 07abca5..c931e65 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -4598,6 +4598,32 @@ u64 nfsd_forget_client(struct nfsd_net *nn, struct nfs4_client *clp, u64 max)
 	return 1;
 }
 
+static u64 nfsd_foreach_client_lock(struct nfsd_net *nn, struct nfs4_client *clp,
+				    u64 max, void (*func)(struct nfs4_lockowner *))
+{
+	struct nfs4_stateowner *sop, *next;
+	u64 count = 0;
+	int i;
+
+	for (i = 0; i < OWNER_HASH_SIZE; i++) {
+		list_for_each_entry_safe(sop, next, &nn->ownerstr_hashtbl[i], so_strhash) {
+			if (!sop->so_is_open_owner && (sop->so_client == clp)) {
+				if (func)
+					func(lockowner(sop));
+				if (++count == max)
+					break;
+			}
+		}
+	}
+
+	return count;
+}
+
+u64 nfsd_forget_client_locks(struct nfsd_net *nn, struct nfs4_client *clp, u64 max)
+{
+	return nfsd_foreach_client_lock(nn, clp, max, release_lockowner);
+}
+
 static u64 nfsd_for_n_state(u64 max, u64 (*func)(struct nfsd_net *, struct nfs4_client *, u64))
 {
 	struct nfs4_client *clp, *next;
@@ -4619,11 +4645,6 @@ void nfsd_forget_clients(u64 num)
 	printk(KERN_INFO "NFSD: Forgot %llu clients", count);
 }
 
-static void release_lockowner_sop(struct nfs4_stateowner *sop)
-{
-	release_lockowner(lockowner(sop));
-}
-
 static void release_openowner_sop(struct nfs4_stateowner *sop)
 {
 	release_openowner(openowner(sop));
@@ -4650,9 +4671,8 @@ static int nfsd_release_n_owners(u64 num, bool is_open_owner,
 
 void nfsd_forget_locks(u64 num)
 {
-	struct nfsd_net *nn = net_generic(&init_net, nfsd_net_id);
-	int count = nfsd_release_n_owners(num, false, release_lockowner_sop, nn);
-	printk(KERN_INFO "NFSD: Forgot %d locks", count);
+	u64 count = nfsd_for_n_state(num, nfsd_forget_client_locks);
+	printk(KERN_INFO "NFSD: Forgot %llu locks", count);
 }
 
 void nfsd_forget_openowners(u64 num)
-- 
1.8.0.1


  parent reply	other threads:[~2012-11-27 14:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27 14:35 [PATCH v3 00/10] NFSD: Improve fault injection bjschuma
2012-11-27 14:35 ` [PATCH v3 01/10] NFSD: Fold fault_inject.h into state.h bjschuma
2012-11-28 18:01   ` J. Bruce Fields
2012-11-27 14:35 ` [PATCH v3 02/10] NFSD: Lock state before calling fault injection function bjschuma
2012-11-27 14:35 ` [PATCH v3 03/10] NFSD: Clean up forgetting clients bjschuma
2012-11-28 16:29   ` J. Bruce Fields
2012-11-28 16:34     ` Bryan Schumaker
2012-11-28 16:47       ` J. Bruce Fields
2012-11-28 16:49         ` Bryan Schumaker
2012-11-28 16:56           ` J. Bruce Fields
2012-11-28 16:57             ` J. Bruce Fields
2012-11-28 20:53               ` Bryan Schumaker
2012-11-30 18:40                 ` J. Bruce Fields
2012-11-28 16:57             ` Bryan Schumaker
2012-11-27 14:35 ` bjschuma [this message]
2012-11-27 14:35 ` [PATCH v3 05/10] NFSD: Clean up forgetting openowners bjschuma
2012-11-27 14:35 ` [PATCH v3 06/10] NFSD: Clean up forgetting and recalling delegations bjschuma
2012-11-27 14:35 ` [PATCH v3 07/10] NFSD: Fault injection operations take a per-client forget function bjschuma
2012-11-27 14:35 ` [PATCH v3 08/10] NFSD: Reading a fault injection file prints a state count bjschuma
2012-11-27 14:35 ` [PATCH v3 09/10] NFSD: Add a custom file operations structure for fault injection bjschuma
2012-11-27 14:35 ` [PATCH v3 10/10] NFSD: Forget state for a specific client bjschuma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354026919-13313-5-git-send-email-bjschuma@netapp.com \
    --to=bjschuma@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.