From: Jon Hunter <jon-hunter@ti.com> To: Tony Lindgren <tony@atomide.com> Cc: linux-omap <linux-omap@vger.kernel.org>, linux-arm <linux-arm-kernel@lists.infradead.org>, Jon Hunter <jon-hunter@ti.com>, Igor Grinberg <grinberg@compulab.co.il> Subject: [PATCH 2/3] ARM: OMAP4: Fix build error and warning in timer.c Date: Tue, 27 Nov 2012 20:15:14 -0600 [thread overview] Message-ID: <1354068915-3378-3-git-send-email-jon-hunter@ti.com> (raw) In-Reply-To: <1354068915-3378-1-git-send-email-jon-hunter@ti.com> When compiling the kernel with configuration option CONFIG_ARCH_OMAP4 enabled and CONFIG_LOCAL_TIMERS disabled, the following build error and warning is seen. CC arch/arm/mach-omap2/timer.o arch/arm/mach-omap2/timer.c: In function ‘omap4_local_timer_init’: arch/arm/mach-omap2/timer.c:630:2: error: implicit declaration of function ‘omap4_sync32_timer_init’ [-Werror=implicit-function-declaration] arch/arm/mach-omap2/timer.c: At top level: arch/arm/mach-omap2/timer.c:607:1: warning: ‘omap4_sync32k_timer_init’ defined but not used [-Wunused-function] cc1: some warnings being treated as errors make[1]: *** [arch/arm/mach-omap2/timer.o] Error 1 This issue was introduced by commit 6f80b3b (ARM: OMAP2+: timer: remove CONFIG_OMAP_32K_TIMER) where the "k" is missing from the "sync32k" in the function name "omap4_sync32_timer_init". Therefore, correct this typo to resolve the above error and warning. Cc: Igor Grinberg <grinberg@compulab.co.il> Reported-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Jon Hunter <jon-hunter@ti.com> --- arch/arm/mach-omap2/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c index a9f99e3..eb96712 100644 --- a/arch/arm/mach-omap2/timer.c +++ b/arch/arm/mach-omap2/timer.c @@ -627,7 +627,7 @@ static void __init omap4_local_timer_init(void) #else /* CONFIG_LOCAL_TIMERS */ static inline void omap4_local_timer_init(void) { - omap4_sync32_timer_init(); + omap4_sync32k_timer_init(); } #endif /* CONFIG_LOCAL_TIMERS */ OMAP_SYS_TIMER(4, local); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] ARM: OMAP4: Fix build error and warning in timer.c Date: Tue, 27 Nov 2012 20:15:14 -0600 [thread overview] Message-ID: <1354068915-3378-3-git-send-email-jon-hunter@ti.com> (raw) In-Reply-To: <1354068915-3378-1-git-send-email-jon-hunter@ti.com> When compiling the kernel with configuration option CONFIG_ARCH_OMAP4 enabled and CONFIG_LOCAL_TIMERS disabled, the following build error and warning is seen. CC arch/arm/mach-omap2/timer.o arch/arm/mach-omap2/timer.c: In function ?omap4_local_timer_init?: arch/arm/mach-omap2/timer.c:630:2: error: implicit declaration of function ?omap4_sync32_timer_init? [-Werror=implicit-function-declaration] arch/arm/mach-omap2/timer.c: At top level: arch/arm/mach-omap2/timer.c:607:1: warning: ?omap4_sync32k_timer_init? defined but not used [-Wunused-function] cc1: some warnings being treated as errors make[1]: *** [arch/arm/mach-omap2/timer.o] Error 1 This issue was introduced by commit 6f80b3b (ARM: OMAP2+: timer: remove CONFIG_OMAP_32K_TIMER) where the "k" is missing from the "sync32k" in the function name "omap4_sync32_timer_init". Therefore, correct this typo to resolve the above error and warning. Cc: Igor Grinberg <grinberg@compulab.co.il> Reported-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Jon Hunter <jon-hunter@ti.com> --- arch/arm/mach-omap2/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c index a9f99e3..eb96712 100644 --- a/arch/arm/mach-omap2/timer.c +++ b/arch/arm/mach-omap2/timer.c @@ -627,7 +627,7 @@ static void __init omap4_local_timer_init(void) #else /* CONFIG_LOCAL_TIMERS */ static inline void omap4_local_timer_init(void) { - omap4_sync32_timer_init(); + omap4_sync32k_timer_init(); } #endif /* CONFIG_LOCAL_TIMERS */ OMAP_SYS_TIMER(4, local); -- 1.7.10.4
next prev parent reply other threads:[~2012-11-28 2:15 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-11-28 2:15 [PATCH 0/3] ARM: OMAP2+: Timer build warnings and error fixes Jon Hunter 2012-11-28 2:15 ` Jon Hunter 2012-11-28 2:15 ` [PATCH 1/3] ARM: OMAP2+: Fix realtime_counter_init warning in timer.c Jon Hunter 2012-11-28 2:15 ` Jon Hunter 2012-11-28 6:09 ` Santosh Shilimkar 2012-11-28 6:09 ` Santosh Shilimkar 2012-11-28 15:47 ` Jon Hunter 2012-11-28 15:47 ` Jon Hunter 2012-11-28 15:55 ` Santosh Shilimkar 2012-11-28 15:55 ` Santosh Shilimkar 2012-11-28 16:01 ` Jon Hunter 2012-11-28 16:01 ` Jon Hunter 2012-11-28 16:06 ` Santosh Shilimkar 2012-11-28 16:06 ` Santosh Shilimkar 2012-11-28 16:04 ` Santosh Shilimkar 2012-11-28 16:04 ` Santosh Shilimkar 2012-11-28 2:15 ` Jon Hunter [this message] 2012-11-28 2:15 ` [PATCH 2/3] ARM: OMAP4: Fix build error and " Jon Hunter 2012-11-28 5:47 ` Santosh Shilimkar 2012-11-28 5:47 ` Santosh Shilimkar 2012-11-28 6:40 ` Igor Grinberg 2012-11-28 6:40 ` Igor Grinberg 2012-11-28 2:15 ` [PATCH 3/3] ARM: AM335x: Fix " Jon Hunter 2012-11-28 2:15 ` Jon Hunter 2012-11-28 6:28 ` Santosh Shilimkar 2012-11-28 6:28 ` Santosh Shilimkar 2012-11-28 6:46 ` Igor Grinberg 2012-11-28 6:46 ` Igor Grinberg 2012-11-28 7:20 ` Santosh Shilimkar 2012-11-28 7:20 ` Santosh Shilimkar 2012-11-28 16:06 ` Jon Hunter 2012-11-28 16:06 ` Jon Hunter 2012-11-28 10:21 ` Vaibhav Hiremath 2012-11-28 10:21 ` Vaibhav Hiremath
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1354068915-3378-3-git-send-email-jon-hunter@ti.com \ --to=jon-hunter@ti.com \ --cc=grinberg@compulab.co.il \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.