All of lore.kernel.org
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 13/20] arm: kirkwood: mplcec4: use Device Tree to probe SDIO
Date: Fri, 21 Dec 2012 15:49:12 +0100	[thread overview]
Message-ID: <1356101359-6054-14-git-send-email-thomas.petazzoni@free-electrons.com> (raw)
In-Reply-To: <1356101359-6054-1-git-send-email-thomas.petazzoni@free-electrons.com>

Now that the mvsdio driver has a Device Tree binding, and the SDIO
controller is declared in kirkwood.dtsi, migrate the mplcec4 board to
use the Device Tree to probe the SDIO controller and to mux the pins
of the SDIO interface correctly.

This patch has not been tested, it remains to be tested by a person
having access to the hardware.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Stefan Peter <s.peter@mpl.ch>
---
Changes since v1:
 * Remove the useless header inclusion from board-mplcec4.c, now
   that the SDIO interface is probed from the Device Tree.
 * Reference the pmx_sdio muxing option from the DT node describing
   the SDIO interface, in order to get proper muxing of this
   interface.
---
 arch/arm/boot/dts/kirkwood-mplcec4.dts |   11 +++++++++--
 arch/arm/mach-kirkwood/board-mplcec4.c |    7 -------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/kirkwood-mplcec4.dts b/arch/arm/boot/dts/kirkwood-mplcec4.dts
index 262c654..662dfd8 100644
--- a/arch/arm/boot/dts/kirkwood-mplcec4.dts
+++ b/arch/arm/boot/dts/kirkwood-mplcec4.dts
@@ -20,12 +20,11 @@
 		pinctrl: pinctrl at 10000 {
 
 			pinctrl-0 = < &pmx_nand &pmx_uart0
-				      &pmx_led_health &pmx_sdio
+				      &pmx_led_health
 				      &pmx_sata0 &pmx_sata1
 				      &pmx_led_user1o
 				      &pmx_led_user1g &pmx_led_user0o
 				      &pmx_led_user0g &pmx_led_misc
-				      &pmx_sdio_cd
 				    >;
 			pinctrl-names = "default";
 
@@ -133,6 +132,14 @@
 			status = "okay";
 
 		};
+
+		mvsdio at 90000 {
+			pinctrl-0 = <&pmx_sdio &pmx_sdio_cd>;
+			pinctrl-names = "default";
+			status = "okay";
+			cd-gpios = <&gpio1 15 0>;
+			/* No WP GPIO */
+		};
 	};
 
 	gpio-leds {
diff --git a/arch/arm/mach-kirkwood/board-mplcec4.c b/arch/arm/mach-kirkwood/board-mplcec4.c
index 56bfe5a..73a0332 100644
--- a/arch/arm/mach-kirkwood/board-mplcec4.c
+++ b/arch/arm/mach-kirkwood/board-mplcec4.c
@@ -12,7 +12,6 @@
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/mv643xx_eth.h>
-#include <linux/platform_data/mmc-mvsdio.h>
 #include "common.h"
 #include "mpp.h"
 
@@ -24,11 +23,6 @@ static struct mv643xx_eth_platform_data mplcec4_ge01_data = {
 	.phy_addr	= MV643XX_ETH_PHY_ADDR(2),
 };
 
-static struct mvsdio_platform_data mplcec4_mvsdio_data = {
-	.gpio_card_detect = 47,	/* MPP47 used as SD card detect */
-};
-
-
 void __init mplcec4_init(void)
 {
 	/*
@@ -36,7 +30,6 @@ void __init mplcec4_init(void)
 	 */
 	kirkwood_ge00_init(&mplcec4_ge00_data);
 	kirkwood_ge01_init(&mplcec4_ge01_data);
-	kirkwood_sdio_init(&mplcec4_mvsdio_data);
 	kirkwood_pcie_init(KW_PCIE0);
 }
 
-- 
1.7.9.5

  parent reply	other threads:[~2012-12-21 14:49 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-21 14:48 [PATCH v2] Device Tree binding for the mvsdio driver and related changes Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 01/20] mmc: mvsdio: use slot-gpio infrastructure for write protect gpio Thomas Petazzoni
2012-12-22 14:05   ` Shawn Guo
2012-12-22 14:49     ` Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 02/20] mmc: mvsdio: use slot-gpio for card detect gpio Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 03/20] mmc: mvsdio: implement a Device Tree binding Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 04/20] mmc: mvsdio: add pinctrl integration Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 05/20] arm: mvebu: add DT information for the SDIO interface of Armada 370/XP Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 06/20] arm: mvebu: add pin muxing options for the SDIO interface on Armada 370 Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 07/20] arm: mvebu: add pin muxing options for the SDIO interface on Armada XP Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 08/20] arm: mvebu: enable the SD card slot on Armada XP DB board Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 09/20] arm: mvebu: enable the SD card slot on Armada 370 " Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 10/20] arm: mvebu: enable the SDIO interface on the Globalscale Mirabox Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 11/20] arm: kirkwood: add Device Tree informations for the SDIO controller Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 12/20] arm: kirkwood: dreamplug: use Device Tree to probe SDIO Thomas Petazzoni
2012-12-21 14:49 ` Thomas Petazzoni [this message]
2012-12-27 12:32   ` [PATCH v2 13/20] arm: kirkwood: mplcec4: " Stefan Peter
2012-12-27 12:43     ` Thomas Petazzoni
2012-12-27 16:45     ` Jason Cooper
2012-12-27 22:22       ` Stefan Peter
2012-12-27 22:29         ` Jason Cooper
2012-12-27 22:57   ` Stefan Peter
2012-12-21 14:49 ` [PATCH v2 14/20] arm: kirkwood: add pinmux option for the SDIO interface on 88F6282 Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 15/20] arm: kirkwood: topkick: the Topkick platform uses a 88F6282 SoC Thomas Petazzoni
2013-01-10  2:29   ` Jason Cooper
2013-01-10  6:13     ` Andrew Lunn
2013-01-10 11:50       ` Jason Cooper
2012-12-21 14:49 ` [PATCH v2 16/20] arm: kirkwood: topkick: use Device Tree to probe SDIO Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 17/20] arm: kirkwood: dockstar: remove useless include of SDIO header Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 18/20] arm: mvebu: enable SDIO support in mvebu_defconfig Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 19/20] arm: mvebu: enable mwifiex driver " Thomas Petazzoni
2012-12-21 14:49 ` [PATCH v2 20/20] arm: mvebu: enable btmrvl " Thomas Petazzoni
2013-01-08 20:38 ` [PATCH v2] Device Tree binding for the mvsdio driver and related changes Florian Fainelli
2013-01-10  3:13 ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356101359-6054-14-git-send-email-thomas.petazzoni@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.