From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
To: ceph-devel@vger.kernel.org
Cc: Danny Al-Gaaf <dalgaaf@suse.de>, Sage Weil <sage@inktank.com>
Subject: [PATCH 06/15] common/WorkQueue.h: use empty() instead of size()
Date: Thu, 7 Feb 2013 20:41:54 +0100 [thread overview]
Message-ID: <1360266123-28972-7-git-send-email-danny.al-gaaf@bisect.de> (raw)
In-Reply-To: <1360266123-28972-1-git-send-email-danny.al-gaaf@bisect.de>
Fix warning for usage of out->size() in _void_dequeue(). Use empty()
since it should be prefered as it has, following the standard, a
constant time complexity regardless of the containter type. The
same is not guaranteed for size().
warning from cppchecker was:
[common/WorkQueue.h:97]: (performance) Possible inefficient
checking for 'queue' emptiness.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---
src/common/WorkQueue.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/common/WorkQueue.h b/src/common/WorkQueue.h
index b19a6a2..ced952c 100644
--- a/src/common/WorkQueue.h
+++ b/src/common/WorkQueue.h
@@ -94,7 +94,7 @@ public:
void *_void_dequeue() {
list<T*> *out(new list<T*>);
_dequeue(out);
- if (out->size()) {
+ if (!out->empty()) {
return (void *)out;
} else {
delete out;
--
1.8.1.2
next prev parent reply other threads:[~2013-02-07 19:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 19:41 [PATCH 00/15] fix more issues from clang(++) and cppchecker Danny Al-Gaaf
2013-02-07 19:41 ` [PATCH 01/15] kv_flat_btree_async.cc: use vector instead of VLA's Danny Al-Gaaf
2013-02-10 5:57 ` Sage Weil
2013-02-11 13:21 ` Danny Al-Gaaf
2013-02-11 13:57 ` Sage Weil
2013-02-07 19:41 ` [PATCH 02/15] common/config.h: declaration of config_option as struct Danny Al-Gaaf
2013-02-07 19:41 ` [PATCH 03/15] src/msg/msg_types.h: pass function parameter by reference Danny Al-Gaaf
2013-02-07 19:41 ` [PATCH 04/15] fuse_ll.cc: fix -Wgnu-designator Danny Al-Gaaf
2013-02-07 19:41 ` [PATCH 05/15] common/AsyncReserver.h: use empty() instead of size() Danny Al-Gaaf
2013-02-07 19:41 ` Danny Al-Gaaf [this message]
2013-02-07 19:41 ` [PATCH 07/15] common/config.cc: fix -Wgnu-designator Danny Al-Gaaf
2013-02-07 19:41 ` [PATCH 08/15] src/log/Entry.h: pass function parameter by reference Danny Al-Gaaf
2013-02-07 19:41 ` [PATCH 09/15] src/mon/PGMonitor.cc: remove unused variable Danny Al-Gaaf
2013-02-07 19:41 ` [PATCH 10/15] src/msg/Messenger.h: pass function parameter by reference Danny Al-Gaaf
2013-02-07 19:41 ` [PATCH 11/15] src/osd/OSD.h: use empty() instead of size() Danny Al-Gaaf
2013-02-07 19:42 ` [PATCH 12/15] src/osd/PG.h: " Danny Al-Gaaf
2013-02-07 19:42 ` [PATCH 13/15] src/osd/osd_types.h: pass function parameter by reference Danny Al-Gaaf
2013-02-10 6:00 ` Sage Weil
2013-02-07 19:42 ` [PATCH 14/15] test_mon_workloadgen.cc: fix -Wgnu Danny Al-Gaaf
2013-02-07 19:42 ` [PATCH 15/15] librados/librados.cc: fix implicitly-defined namespace 'std' Danny Al-Gaaf
2013-02-10 6:02 ` [PATCH 00/15] fix more issues from clang(++) and cppchecker Sage Weil
2013-02-10 13:38 ` Danny Al-Gaaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360266123-28972-7-git-send-email-danny.al-gaaf@bisect.de \
--to=danny.al-gaaf@bisect.de \
--cc=ceph-devel@vger.kernel.org \
--cc=dalgaaf@suse.de \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.