From: Santosh Shilimkar <santosh.shilimkar@ti.com> To: linux-omap@vger.kernel.org Cc: khilman@deeprootsystems.com, tony@atomide.com, linux-arm-kernel@lists.infradead.org, Santosh Shilimkar <santosh.shilimkar@ti.com>, Jon Hunter <jon-hunter@ti.com> Subject: [PATCH 8/9] ARM: OMAP4: PM: Remove L4 wakeup depedency with MPU since errata fix exist now Date: Wed, 20 Feb 2013 20:48:46 +0530 [thread overview] Message-ID: <1361373527-21695-9-git-send-email-santosh.shilimkar@ti.com> (raw) In-Reply-To: <1361373527-21695-1-git-send-email-santosh.shilimkar@ti.com> With commit bfd6d021 {ARM: OMAP3+: Implement timer workaround for errata i103 and i767}, the sync and gptimer synchronization errata got fixed. Hence the l4_wakeup static dependency with MPU can can be removed now. Static dependency was one of the proposed workaround but from power savings perspective, it isn't an ideal workaround. Cc: Jon Hunter <jon-hunter@ti.com> Cc: Kevin Hilman <khilman@deeprootsystems.com> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> --- arch/arm/mach-omap2/pm44xx.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c index a96ae57..1fd9662 100644 --- a/arch/arm/mach-omap2/pm44xx.c +++ b/arch/arm/mach-omap2/pm44xx.c @@ -133,7 +133,7 @@ static void omap_default_idle(void) int __init omap4_pm_init(void) { int ret; - struct clockdomain *emif_clkdm, *mpuss_clkdm, *l3_1_clkdm, *l4wkup; + struct clockdomain *emif_clkdm, *mpuss_clkdm, *l3_1_clkdm; struct clockdomain *ducati_clkdm, *l3_2_clkdm, *l4_per_clkdm; if (omap_rev() == OMAP4430_REV_ES1_0) { @@ -154,19 +154,14 @@ int __init omap4_pm_init(void) * MPUSS -> L4_PER/L3_* and DUCATI -> L3_* doesn't work as * expected. The hardware recommendation is to enable static * dependencies for these to avoid system lock ups or random crashes. - * The L4 wakeup depedency is added to workaround the OCP sync hardware - * BUG with 32K synctimer which lead to incorrect timer value read - * from the 32K counter. The BUG applies for GPTIMER1 and WDT2 which - * are part of L4 wakeup clockdomain. */ mpuss_clkdm = clkdm_lookup("mpuss_clkdm"); emif_clkdm = clkdm_lookup("l3_emif_clkdm"); l3_1_clkdm = clkdm_lookup("l3_1_clkdm"); l3_2_clkdm = clkdm_lookup("l3_2_clkdm"); l4_per_clkdm = clkdm_lookup("l4_per_clkdm"); - l4wkup = clkdm_lookup("l4_wkup_clkdm"); ducati_clkdm = clkdm_lookup("ducati_clkdm"); - if ((!mpuss_clkdm) || (!emif_clkdm) || (!l3_1_clkdm) || (!l4wkup) || + if ((!mpuss_clkdm) || (!emif_clkdm) || (!l3_1_clkdm) || (!l3_2_clkdm) || (!ducati_clkdm) || (!l4_per_clkdm)) goto err2; @@ -174,7 +169,6 @@ int __init omap4_pm_init(void) ret |= clkdm_add_wkdep(mpuss_clkdm, l3_1_clkdm); ret |= clkdm_add_wkdep(mpuss_clkdm, l3_2_clkdm); ret |= clkdm_add_wkdep(mpuss_clkdm, l4_per_clkdm); - ret |= clkdm_add_wkdep(mpuss_clkdm, l4wkup); ret |= clkdm_add_wkdep(ducati_clkdm, l3_1_clkdm); ret |= clkdm_add_wkdep(ducati_clkdm, l3_2_clkdm); if (ret) { -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 8/9] ARM: OMAP4: PM: Remove L4 wakeup depedency with MPU since errata fix exist now Date: Wed, 20 Feb 2013 20:48:46 +0530 [thread overview] Message-ID: <1361373527-21695-9-git-send-email-santosh.shilimkar@ti.com> (raw) In-Reply-To: <1361373527-21695-1-git-send-email-santosh.shilimkar@ti.com> With commit bfd6d021 {ARM: OMAP3+: Implement timer workaround for errata i103 and i767}, the sync and gptimer synchronization errata got fixed. Hence the l4_wakeup static dependency with MPU can can be removed now. Static dependency was one of the proposed workaround but from power savings perspective, it isn't an ideal workaround. Cc: Jon Hunter <jon-hunter@ti.com> Cc: Kevin Hilman <khilman@deeprootsystems.com> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> --- arch/arm/mach-omap2/pm44xx.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c index a96ae57..1fd9662 100644 --- a/arch/arm/mach-omap2/pm44xx.c +++ b/arch/arm/mach-omap2/pm44xx.c @@ -133,7 +133,7 @@ static void omap_default_idle(void) int __init omap4_pm_init(void) { int ret; - struct clockdomain *emif_clkdm, *mpuss_clkdm, *l3_1_clkdm, *l4wkup; + struct clockdomain *emif_clkdm, *mpuss_clkdm, *l3_1_clkdm; struct clockdomain *ducati_clkdm, *l3_2_clkdm, *l4_per_clkdm; if (omap_rev() == OMAP4430_REV_ES1_0) { @@ -154,19 +154,14 @@ int __init omap4_pm_init(void) * MPUSS -> L4_PER/L3_* and DUCATI -> L3_* doesn't work as * expected. The hardware recommendation is to enable static * dependencies for these to avoid system lock ups or random crashes. - * The L4 wakeup depedency is added to workaround the OCP sync hardware - * BUG with 32K synctimer which lead to incorrect timer value read - * from the 32K counter. The BUG applies for GPTIMER1 and WDT2 which - * are part of L4 wakeup clockdomain. */ mpuss_clkdm = clkdm_lookup("mpuss_clkdm"); emif_clkdm = clkdm_lookup("l3_emif_clkdm"); l3_1_clkdm = clkdm_lookup("l3_1_clkdm"); l3_2_clkdm = clkdm_lookup("l3_2_clkdm"); l4_per_clkdm = clkdm_lookup("l4_per_clkdm"); - l4wkup = clkdm_lookup("l4_wkup_clkdm"); ducati_clkdm = clkdm_lookup("ducati_clkdm"); - if ((!mpuss_clkdm) || (!emif_clkdm) || (!l3_1_clkdm) || (!l4wkup) || + if ((!mpuss_clkdm) || (!emif_clkdm) || (!l3_1_clkdm) || (!l3_2_clkdm) || (!ducati_clkdm) || (!l4_per_clkdm)) goto err2; @@ -174,7 +169,6 @@ int __init omap4_pm_init(void) ret |= clkdm_add_wkdep(mpuss_clkdm, l3_1_clkdm); ret |= clkdm_add_wkdep(mpuss_clkdm, l3_2_clkdm); ret |= clkdm_add_wkdep(mpuss_clkdm, l4_per_clkdm); - ret |= clkdm_add_wkdep(mpuss_clkdm, l4wkup); ret |= clkdm_add_wkdep(ducati_clkdm, l3_1_clkdm); ret |= clkdm_add_wkdep(ducati_clkdm, l3_2_clkdm); if (ret) { -- 1.7.9.5
next prev parent reply other threads:[~2013-02-20 15:17 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-20 15:18 [PATCH 0/9] ARM: OMAP: Static deps, fiq, omap-smp cleanup Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 1/9] ARM: OMAP4+: Use common scratchpad SAR RAM offsets for all architectures Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-03-27 18:41 ` Kevin Hilman 2013-03-27 18:41 ` Kevin Hilman 2013-03-27 20:49 ` Santosh Shilimkar 2013-03-27 20:49 ` Santosh Shilimkar 2013-03-27 20:49 ` Tony Lindgren 2013-03-27 20:49 ` Tony Lindgren 2013-03-27 20:52 ` Santosh Shilimkar 2013-03-27 20:52 ` Santosh Shilimkar 2013-03-28 7:32 ` Santosh Shilimkar 2013-03-28 7:32 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 2/9] ARM: OMAP1: PM: Remove bogus fiq_[enable/disable] tuple Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-02-20 16:09 ` Tony Lindgren 2013-02-20 16:09 ` Tony Lindgren 2013-02-20 16:14 ` Santosh Shilimkar 2013-02-20 16:14 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 3/9] ARM: OMAP2+: " Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-03-27 18:36 ` Kevin Hilman 2013-03-27 18:36 ` Kevin Hilman 2013-03-27 19:02 ` Santosh Shilimkar 2013-03-27 19:02 ` Santosh Shilimkar 2013-03-28 7:37 ` Santosh Shilimkar 2013-03-28 7:37 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 4/9] ARM: OMAP4+: Remove the un-necessary cache flush from hotplug code Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-03-27 18:43 ` Kevin Hilman 2013-03-27 18:43 ` Kevin Hilman 2013-03-27 20:47 ` Santosh Shilimkar 2013-03-27 20:47 ` Santosh Shilimkar 2013-03-28 7:29 ` Santosh Shilimkar 2013-03-28 7:29 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 5/9] ARM: OMAP4+: Remove un-necessary cacheflush in secondary CPU boot path Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 6/9] ARM: OMAP4+: Remove out of placed smp_wmb() in secondary wakeup code Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-02-21 12:55 ` Sergei Shtylyov 2013-02-21 12:55 ` Sergei Shtylyov 2013-02-21 12:59 ` Santosh Shilimkar 2013-02-21 12:59 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 7/9] ARM: OMAP4+: Move the CPU wakeup prepare code under smp_prepare_cpus() Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-03-27 18:45 ` Kevin Hilman 2013-03-27 18:45 ` Kevin Hilman 2013-03-27 19:04 ` Santosh Shilimkar 2013-03-27 19:04 ` Santosh Shilimkar 2013-03-27 19:54 ` Kevin Hilman 2013-03-27 19:54 ` Kevin Hilman 2013-03-27 20:50 ` Santosh Shilimkar 2013-03-27 20:50 ` Santosh Shilimkar 2013-03-28 7:35 ` Santosh Shilimkar 2013-03-28 7:35 ` Santosh Shilimkar 2013-03-28 9:46 ` Russell King - ARM Linux 2013-03-28 9:46 ` Russell King - ARM Linux 2013-03-28 9:58 ` Santosh Shilimkar 2013-03-28 9:58 ` Santosh Shilimkar 2013-03-28 12:04 ` Russell King - ARM Linux 2013-03-28 12:04 ` Russell King - ARM Linux 2013-03-28 12:09 ` Santosh Shilimkar 2013-03-28 12:09 ` Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar [this message] 2013-02-20 15:18 ` [PATCH 8/9] ARM: OMAP4: PM: Remove L4 wakeup depedency with MPU since errata fix exist now Santosh Shilimkar 2013-03-27 18:46 ` Kevin Hilman 2013-03-27 18:46 ` Kevin Hilman 2013-03-27 19:01 ` Peter Korsgaard 2013-03-27 19:01 ` Peter Korsgaard 2013-02-20 15:18 ` [PATCH 9/9] ARM: OMAP4: PM: Now remove L4 per clockdomain static depedency with MPU Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-03-27 18:46 ` Kevin Hilman 2013-03-27 18:46 ` Kevin Hilman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1361373527-21695-9-git-send-email-santosh.shilimkar@ti.com \ --to=santosh.shilimkar@ti.com \ --cc=jon-hunter@ti.com \ --cc=khilman@deeprootsystems.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.