From: Stephen Warren <swarren@wwwdotorg.org> To: Grant Likely <grant.likely@secretlab.ca>, Rob Herring <rob.herring@calxeda.com> Cc: Michal Marek <mmarek@suse.cz>, devicetree-discuss@lists.ozlabs.org, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Warren <swarren@nvidia.com>, Shawn Guo <shawn.guo@linaro.org>, Hiroshi Doyu <hdoyu@nvidia.com> Subject: [PATCH] kbuild: create an "include chroot" for DT bindings Date: Wed, 20 Feb 2013 14:05:56 -0700 [thread overview] Message-ID: <1361394356-19385-1-git-send-email-swarren@wwwdotorg.org> (raw) From: Stephen Warren <swarren@nvidia.com> The recent dtc+cpp support allows header files and C pre-processor defines/macros to be used when compiling device tree files. These headers will typically define various constants that are part of the device tree bindings. The original patch which set up the dtc+cpp include path only considered using those headers from device tree files. However, they are also useful for kernel code which needs to interpret the device tree. In both the DT files and the kernel, I'd like to include the DT-related headers in the same way, for example, <dt-bindings/gpio/tegra-gpio.h>. That will simplify any text which discusses the DT header locations. Creating a <dt-bindings/> for kernel source to use is as simple as placing files into include/dt-bindings/. However, when compiling DT files, the include path should be restricted so that only the dt-bindings path is available; arbitrary kernel headers shouldn't be exposed. For this reason, create a specific include directory for use by dtc+cpp, and symlink dt-bindings from there to the actual location of include/dt-bindings/. For want of a better location, place this "include chroot" into the existing dts/ directory. arch/*/boot/dts/include/dt-bindings -> ../../../../../dt-bindings Cc: Shawn Guo <shawn.guo@linaro.org> Cc: Hiroshi Doyu <hdoyu@nvidia.com> Signed-off-by: Stephen Warren <swarren@nvidia.com> --- You can find an example of how this would be used at git://nv-tegra.nvidia.com/user/swarren/linux-2.6 linux-next_common (note: there's a bunch of other cruft in that branch too) arch/arm/boot/dts/include/dt-bindings | 1 + scripts/Makefile.lib | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) create mode 120000 arch/arm/boot/dts/include/dt-bindings diff --git a/arch/arm/boot/dts/include/dt-bindings b/arch/arm/boot/dts/include/dt-bindings new file mode 120000 index 0000000..08c00e4 --- /dev/null +++ b/arch/arm/boot/dts/include/dt-bindings @@ -0,0 +1 @@ +../../../../../include/dt-bindings \ No newline at end of file diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 07125e6..d6c5036 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -157,8 +157,7 @@ cpp_flags = -Wp,-MD,$(depfile) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) \ ld_flags = $(LDFLAGS) $(ldflags-y) dtc_cpp_flags = -Wp,-MD,$(depfile) -nostdinc \ - -I$(srctree)/arch/$(SRCARCH)/boot/dts \ - -I$(srctree)/arch/$(SRCARCH)/include/dts \ + -I$(srctree)/arch/$(SRCARCH)/boot/dts/include \ -undef -D__DTS__ # Finds the multi-part object the current object will be linked into -- 1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] kbuild: create an "include chroot" for DT bindings Date: Wed, 20 Feb 2013 14:05:56 -0700 [thread overview] Message-ID: <1361394356-19385-1-git-send-email-swarren@wwwdotorg.org> (raw) From: Stephen Warren <swarren@nvidia.com> The recent dtc+cpp support allows header files and C pre-processor defines/macros to be used when compiling device tree files. These headers will typically define various constants that are part of the device tree bindings. The original patch which set up the dtc+cpp include path only considered using those headers from device tree files. However, they are also useful for kernel code which needs to interpret the device tree. In both the DT files and the kernel, I'd like to include the DT-related headers in the same way, for example, <dt-bindings/gpio/tegra-gpio.h>. That will simplify any text which discusses the DT header locations. Creating a <dt-bindings/> for kernel source to use is as simple as placing files into include/dt-bindings/. However, when compiling DT files, the include path should be restricted so that only the dt-bindings path is available; arbitrary kernel headers shouldn't be exposed. For this reason, create a specific include directory for use by dtc+cpp, and symlink dt-bindings from there to the actual location of include/dt-bindings/. For want of a better location, place this "include chroot" into the existing dts/ directory. arch/*/boot/dts/include/dt-bindings -> ../../../../../dt-bindings Cc: Shawn Guo <shawn.guo@linaro.org> Cc: Hiroshi Doyu <hdoyu@nvidia.com> Signed-off-by: Stephen Warren <swarren@nvidia.com> --- You can find an example of how this would be used at git://nv-tegra.nvidia.com/user/swarren/linux-2.6 linux-next_common (note: there's a bunch of other cruft in that branch too) arch/arm/boot/dts/include/dt-bindings | 1 + scripts/Makefile.lib | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) create mode 120000 arch/arm/boot/dts/include/dt-bindings diff --git a/arch/arm/boot/dts/include/dt-bindings b/arch/arm/boot/dts/include/dt-bindings new file mode 120000 index 0000000..08c00e4 --- /dev/null +++ b/arch/arm/boot/dts/include/dt-bindings @@ -0,0 +1 @@ +../../../../../include/dt-bindings \ No newline at end of file diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 07125e6..d6c5036 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -157,8 +157,7 @@ cpp_flags = -Wp,-MD,$(depfile) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) \ ld_flags = $(LDFLAGS) $(ldflags-y) dtc_cpp_flags = -Wp,-MD,$(depfile) -nostdinc \ - -I$(srctree)/arch/$(SRCARCH)/boot/dts \ - -I$(srctree)/arch/$(SRCARCH)/include/dts \ + -I$(srctree)/arch/$(SRCARCH)/boot/dts/include \ -undef -D__DTS__ # Finds the multi-part object the current object will be linked into -- 1.7.10.4
next reply other threads:[~2013-02-20 21:05 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-20 21:05 Stephen Warren [this message] 2013-02-20 21:05 ` [PATCH] kbuild: create an "include chroot" for DT bindings Stephen Warren 2013-02-21 4:37 ` Shawn Guo 2013-02-21 4:37 ` Shawn Guo 2013-02-21 18:43 ` Stephen Warren 2013-02-21 18:43 ` Stephen Warren 2013-02-22 2:35 ` Shawn Guo 2013-02-22 2:35 ` Shawn Guo 2013-02-22 18:11 ` Stephen Warren 2013-02-22 18:11 ` Stephen Warren 2013-02-21 22:26 ` Michal Marek 2013-02-21 22:26 ` Michal Marek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1361394356-19385-1-git-send-email-swarren@wwwdotorg.org \ --to=swarren@wwwdotorg.org \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=grant.likely@secretlab.ca \ --cc=hdoyu@nvidia.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=mmarek@suse.cz \ --cc=rob.herring@calxeda.com \ --cc=shawn.guo@linaro.org \ --cc=swarren@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.