From: Paul Bolle <pebolle@tiscali.nl> To: Ben Dooks <ben-linux@fluff.org>, Kukjin Kim <kgene.kim@samsung.com>, Russell King <linux@arm.linux.org.uk> Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: S3C24XX: drop "select MACH_NEO1973" Date: Sat, 09 Mar 2013 20:08:01 +0100 [thread overview] Message-ID: <1362856081.3137.19.camel@x61.thuisdomein> (raw) The Kconfig entry for the Openmoko GTA02 / Freerunner phone selects MACH_NEO1973. But there is no Kconfig symbol MACH_NEO1973. The select statement for that symbol is a nop. It can safely be dropped. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- 0) Tested with "git grep". 1) There appear to be repositories that carry a "config MACH_NEO1973" in their tree. I guess it is used to collect functionality common to the GTA01 and the GTA02. But except for this select statement, MACH_NEO1973 was never used in mainline. So if the GTA01 code ever gets merged into mainline, this select statement might be added once more (if it is actually needed then). arch/arm/mach-s3c24xx/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig index 7361b9d..bec43fe 100644 --- a/arch/arm/mach-s3c24xx/Kconfig +++ b/arch/arm/mach-s3c24xx/Kconfig @@ -641,7 +641,6 @@ comment "S3C2442 Boards" config MACH_NEO1973_GTA02 bool "Openmoko GTA02 / Freerunner phone" select I2C - select MACH_NEO1973 select MFD_PCF50633 select PCF50633_GPIO select POWER_SUPPLY -- 1.7.11.7
WARNING: multiple messages have this Message-ID (diff)
From: pebolle@tiscali.nl (Paul Bolle) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: S3C24XX: drop "select MACH_NEO1973" Date: Sat, 09 Mar 2013 20:08:01 +0100 [thread overview] Message-ID: <1362856081.3137.19.camel@x61.thuisdomein> (raw) The Kconfig entry for the Openmoko GTA02 / Freerunner phone selects MACH_NEO1973. But there is no Kconfig symbol MACH_NEO1973. The select statement for that symbol is a nop. It can safely be dropped. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- 0) Tested with "git grep". 1) There appear to be repositories that carry a "config MACH_NEO1973" in their tree. I guess it is used to collect functionality common to the GTA01 and the GTA02. But except for this select statement, MACH_NEO1973 was never used in mainline. So if the GTA01 code ever gets merged into mainline, this select statement might be added once more (if it is actually needed then). arch/arm/mach-s3c24xx/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig index 7361b9d..bec43fe 100644 --- a/arch/arm/mach-s3c24xx/Kconfig +++ b/arch/arm/mach-s3c24xx/Kconfig @@ -641,7 +641,6 @@ comment "S3C2442 Boards" config MACH_NEO1973_GTA02 bool "Openmoko GTA02 / Freerunner phone" select I2C - select MACH_NEO1973 select MFD_PCF50633 select PCF50633_GPIO select POWER_SUPPLY -- 1.7.11.7
next reply other threads:[~2013-03-09 19:08 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-09 19:08 Paul Bolle [this message] 2013-03-09 19:08 ` [PATCH] ARM: S3C24XX: drop "select MACH_NEO1973" Paul Bolle 2013-03-11 7:09 ` Kukjin Kim 2013-03-11 7:09 ` Kukjin Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1362856081.3137.19.camel@x61.thuisdomein \ --to=pebolle@tiscali.nl \ --cc=ben-linux@fluff.org \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.