All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Frank Schäfer" <fschaefer.oss@googlemail.com>
To: mchehab@redhat.com
Cc: hverkuil@xs4all.nl, linux-media@vger.kernel.org,
	"Frank Schäfer" <fschaefer.oss@googlemail.com>
Subject: [RFC PATCH v2 6/6] bttv: radio: apply mute settings on open
Date: Sun, 10 Mar 2013 22:53:54 +0100	[thread overview]
Message-ID: <1362952434-2974-7-git-send-email-fschaefer.oss@googlemail.com> (raw)
In-Reply-To: <1362952434-2974-1-git-send-email-fschaefer.oss@googlemail.com>

In contrast to the video device node, radio_open() doesn't select an input
(which would also applies the mute setting).
Hence the device needs to be muted/unmuted with an explicit call to audio_mux()
in this function.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
---
 drivers/media/pci/bt8xx/bttv-driver.c |    2 ++
 1 Datei geändert, 2 Zeilen hinzugefügt(+)

diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c
index 7459ad6..5031b6e 100644
--- a/drivers/media/pci/bt8xx/bttv-driver.c
+++ b/drivers/media/pci/bt8xx/bttv-driver.c
@@ -3232,6 +3232,8 @@ static int radio_open(struct file *file)
 
 	v4l2_fh_add(&fh->fh);
 
+	audio_mute(btv, btv->mute);
+
 	return 0;
 }
 
-- 
1.7.10.4


      parent reply	other threads:[~2013-03-10 21:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10 21:53 [RFC PATCH v2 0/6] bttv: fix muting/unmuting on probing, first open and last close Frank Schäfer
2013-03-10 21:53 ` [RFC PATCH v2 1/6] bttv: audio_mux() use a local variable "gpio_mute" instead of modifying the function parameter "mute" Frank Schäfer
2013-03-12 13:25   ` Hans Verkuil
2013-03-10 21:53 ` [RFC PATCH v2 2/6] bttv: audio_mux(): do not change the value of the v4l2 mute control Frank Schäfer
2013-03-12 13:41   ` Hans Verkuil
2013-03-15 17:38     ` Frank Schäfer
2013-03-10 21:53 ` [RFC PATCH v2 3/6] bttv: fix mute on last close of the video device node Frank Schäfer
2013-03-10 21:53 ` [RFC PATCH v2 4/6] bttv: do not unmute the device before the first open Frank Schäfer
2013-03-10 21:53 ` [RFC PATCH v2 5/6] bttv: avoid mute on last close when the radio device node is still open Frank Schäfer
2013-03-10 21:53 ` Frank Schäfer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362952434-2974-7-git-send-email-fschaefer.oss@googlemail.com \
    --to=fschaefer.oss@googlemail.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.