From: Asias He <asias@redhat.com>
To: Nicholas Bellinger <nab@linux-iscsi.org>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH 3/4] tcm_vhost: Fix vs->vs_endpoint checking in vhost_scsi_handle_vq()
Date: Tue, 12 Mar 2013 10:42:50 +0800 [thread overview]
Message-ID: <1363056171-5854-4-git-send-email-asias@redhat.com> (raw)
In-Reply-To: <1363056171-5854-1-git-send-email-asias@redhat.com>
vs->vs_endpoint is protected by the vs->dev.mutex. Use
tcm_vhost_check_endpoint() to do check. The helper does the needed
locking for us.
Signed-off-by: Asias He <asias@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
drivers/vhost/tcm_vhost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
index 29612bc..61093d1 100644
--- a/drivers/vhost/tcm_vhost.c
+++ b/drivers/vhost/tcm_vhost.c
@@ -594,7 +594,7 @@ static void vhost_scsi_handle_vq(struct vhost_scsi *vs,
u8 target;
/* Must use ioctl VHOST_SCSI_SET_ENDPOINT */
- if (unlikely(!vs->vs_endpoint))
+ if (!tcm_vhost_check_endpoint(vs))
return;
mutex_lock(&vq->mutex);
--
1.8.1.4
next prev parent reply other threads:[~2013-03-12 2:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 2:42 [PATCH 0/4] tcm_vhost lock and flush fix Asias He
2013-03-12 2:42 ` [PATCH 1/4] tcm_vhost: Add missed lock in vhost_scsi_clear_endpoint() Asias He
2013-03-12 11:13 ` Michael S. Tsirkin
2013-03-13 2:54 ` Asias He
2013-03-13 2:54 ` Asias He
2013-03-12 2:42 ` [PATCH 2/4] tcm_vhost: Introduce tcm_vhost_check_endpoint() Asias He
2013-03-12 8:26 ` Paolo Bonzini
2013-03-13 3:02 ` Asias He
2013-03-13 8:00 ` Paolo Bonzini
2013-03-14 2:14 ` Asias He
2013-03-12 2:42 ` Asias He [this message]
2013-03-12 11:11 ` [PATCH 3/4] tcm_vhost: Fix vs->vs_endpoint checking in vhost_scsi_handle_vq() Michael S. Tsirkin
2013-03-13 3:13 ` Asias He
2013-03-13 8:02 ` Paolo Bonzini
2013-03-14 2:12 ` Asias He
2013-03-12 2:42 ` [PATCH 4/4] tcm_vhost: Flush vhost_work in vhost_scsi_flush() Asias He
2013-03-12 2:42 ` Asias He
2013-03-12 8:26 ` [PATCH 0/4] tcm_vhost lock and flush fix Paolo Bonzini
2013-03-12 11:12 ` Michael S. Tsirkin
2013-03-12 11:14 ` Paolo Bonzini
2013-03-14 2:17 ` Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363056171-5854-4-git-send-email-asias@redhat.com \
--to=asias@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.