All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Manjunathappa, Prakash" <prakash.pm@ti.com>
To: davinci-linux-open-source@linux.davincidsp.com,
	linux-mmc@vger.kernel.org
Cc: cjb@laptop.org, nsekhar@ti.com, grant.likely@secretlab.ca,
	rob.herring@calxeda.com, rob@landley.net, linux@arm.linux.org.uk,
	hs@denx.de, devicetree-discuss@lists.ozlabs.org,
	linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Manjunathappa, Prakash" <prakash.pm@ti.com>
Subject: [PATCH v6 1/5] mmc: davinci: allow driver to work without DMA resource
Date: Wed, 20 Mar 2013 17:14:08 +0530	[thread overview]
Message-ID: <1363779852-24083-2-git-send-email-prakash.pm@ti.com> (raw)
In-Reply-To: <1363779852-24083-1-git-send-email-prakash.pm@ti.com>

Do not return probe failure with missing DMA resources,
allow driver to work in PIO mode.
Tested on da850-evm by mounting partition followed by
file creation and deletion.

Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
Tested-by: Sekhar Nori <nsekhar@ti.com>
---
 drivers/mmc/host/davinci_mmc.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index f5d46ea..bd848d3 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -1191,13 +1191,15 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev)
 
 	r = platform_get_resource(pdev, IORESOURCE_DMA, 0);
 	if (!r)
-		goto out;
-	host->rxdma = r->start;
+		dev_warn(&pdev->dev, "RX DMA resource not specified\n");
+	else
+		host->rxdma = r->start;
 
 	r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
 	if (!r)
-		goto out;
-	host->txdma = r->start;
+		dev_warn(&pdev->dev, "TX DMA resource not specified\n");
+	else
+		host->txdma = r->start;
 
 	host->mem_res = mem;
 	host->base = ioremap(mem->start, mem_size);
-- 
1.7.4.1


WARNING: multiple messages have this Message-ID (diff)
From: prakash.pm@ti.com (Manjunathappa, Prakash)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/5] mmc: davinci: allow driver to work without DMA resource
Date: Wed, 20 Mar 2013 17:14:08 +0530	[thread overview]
Message-ID: <1363779852-24083-2-git-send-email-prakash.pm@ti.com> (raw)
In-Reply-To: <1363779852-24083-1-git-send-email-prakash.pm@ti.com>

Do not return probe failure with missing DMA resources,
allow driver to work in PIO mode.
Tested on da850-evm by mounting partition followed by
file creation and deletion.

Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
Tested-by: Sekhar Nori <nsekhar@ti.com>
---
 drivers/mmc/host/davinci_mmc.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index f5d46ea..bd848d3 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -1191,13 +1191,15 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev)
 
 	r = platform_get_resource(pdev, IORESOURCE_DMA, 0);
 	if (!r)
-		goto out;
-	host->rxdma = r->start;
+		dev_warn(&pdev->dev, "RX DMA resource not specified\n");
+	else
+		host->rxdma = r->start;
 
 	r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
 	if (!r)
-		goto out;
-	host->txdma = r->start;
+		dev_warn(&pdev->dev, "TX DMA resource not specified\n");
+	else
+		host->txdma = r->start;
 
 	host->mem_res = mem;
 	host->base = ioremap(mem->start, mem_size);
-- 
1.7.4.1

  reply	other threads:[~2013-03-20 11:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20 11:44 [PATCH v6 0/5] Add DT support for davinci_mmc driver Manjunathappa, Prakash
2013-03-20 11:44 ` Manjunathappa, Prakash
2013-03-20 11:44 ` Manjunathappa, Prakash [this message]
2013-03-20 11:44   ` [PATCH v6 1/5] mmc: davinci: allow driver to work without DMA resource Manjunathappa, Prakash
2013-03-20 11:44 ` [PATCH v6 2/5] ARM: davinci: mmc: derive version information from device name Manjunathappa, Prakash
2013-03-20 11:44   ` Manjunathappa, Prakash
2013-03-20 11:44 ` [PATCH v6 3/5] mmc: davinci_mmc: add DT support Manjunathappa, Prakash
2013-03-20 11:44   ` Manjunathappa, Prakash
2013-03-20 13:26   ` Arnd Bergmann
2013-03-20 13:26     ` Arnd Bergmann
2013-03-27  9:55     ` Manjunathappa, Prakash
2013-03-27  9:55       ` Manjunathappa, Prakash
2013-03-27 10:43       ` Arnd Bergmann
2013-03-27 10:43         ` Arnd Bergmann
     [not found]         ` <201303271043.51265.arnd-r2nGTMty4D4@public.gmane.org>
2013-03-27 17:46           ` Manjunathappa, Prakash
2013-03-27 17:46             ` Manjunathappa, Prakash
2013-03-20 11:44 ` [PATCH v6 4/5] ARM: davinci: da850: add mmc DT entries Manjunathappa, Prakash
2013-03-20 11:44   ` Manjunathappa, Prakash
2013-03-20 11:44   ` Manjunathappa, Prakash
2013-03-20 11:44 ` [PATCH v6 5/5] ARM: davinci: da850: override mmc DT node device name Manjunathappa, Prakash
2013-03-20 11:44   ` Manjunathappa, Prakash
2013-03-20 11:44   ` Manjunathappa, Prakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363779852-24083-2-git-send-email-prakash.pm@ti.com \
    --to=prakash.pm@ti.com \
    --cc=cjb@laptop.org \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=hs@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nsekhar@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.