All of lore.kernel.org
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/21] arm: kirkwood: guruplug: affect pinmux configs to the right devices
Date: Fri, 24 May 2013 11:44:43 +0200	[thread overview]
Message-ID: <1369388699-25975-7-git-send-email-thomas.petazzoni@free-electrons.com> (raw)
In-Reply-To: <1369388699-25975-1-git-send-email-thomas.petazzoni@free-electrons.com>

When the pinmux mechanism was added in Kirkwood, the device driver
core was not yet providing the possibility of attaching pinmux
configurations to all devices, drivers had to do it explicitly, and
not all drivers were doing this.

Now that the driver core does that in a generic way, it makes sense to
attach the pinmux configuration to their corresponding devices.

This allows the pinctrl subsystem to show in debugfs to which device
is related which pins, for example:

pin 41 (PIN41): gpio-leds.1 mvebu-gpio:41 function gpio group mpp41
pin 42 (PIN42): gpio-leds.1 mvebu-gpio:42 function gpio group mpp42
pin 43 (PIN43): gpio-leds.1 mvebu-gpio:43 function gpio group mpp43

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 .../arm/boot/dts/kirkwood-guruplug-server-plus.dts |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/kirkwood-guruplug-server-plus.dts b/arch/arm/boot/dts/kirkwood-guruplug-server-plus.dts
index 44fd97d..df830d4 100644
--- a/arch/arm/boot/dts/kirkwood-guruplug-server-plus.dts
+++ b/arch/arm/boot/dts/kirkwood-guruplug-server-plus.dts
@@ -18,11 +18,6 @@
 
 	ocp at f1000000 {
 		pinctrl: pinctrl at 10000 {
-
-			pinctrl-0 = < &pmx_led_health_r &pmx_led_health_g
-				      &pmx_led_wmode_r &pmx_led_wmode_g >;
-			pinctrl-names = "default";
-
 			pmx_led_health_r: pmx-led-health-r {
 				marvell,pins = "mpp46";
 				marvell,function = "gpio";
@@ -77,6 +72,9 @@
 
 	gpio-leds {
 		compatible = "gpio-leds";
+		pinctrl-0 = < &pmx_led_health_r &pmx_led_health_g
+			      &pmx_led_wmode_r &pmx_led_wmode_g >;
+		pinctrl-names = "default";
 
 		health-r {
 			label = "guruplug:red:health";
-- 
1.7.9.5

  parent reply	other threads:[~2013-05-24  9:44 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24  9:44 [PATCH 00/21] ARM: kirkwood: improve pinmux configs in Device Tree Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 01/21] arm: kirkwood: cloudbox: affect pinmux configs to the right devices Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 02/21] arm: kirkwood: dlink dns: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 03/21] arm: kirkwood: dockstar: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 04/21] arm: kirkwood: dreamplug: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 05/21] arm: kirkwood: goflexnet: " Thomas Petazzoni
2013-05-24  9:44 ` Thomas Petazzoni [this message]
2013-05-24  9:44 ` [PATCH 07/21] arm: kirkwood: ib62x0: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 08/21] arm: kirkwood: iconnect: give meaningful names to pinmux configs Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 09/21] arm: kirkwood: iconnect: affect pinmux configs to the right devices Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 10/21] arm: kirkwood: iomega ix2-200: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 11/21] arm: kirkwood: ns2: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 12/21] arm: kirkwood: keymile: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 13/21] arm: kirkwood: buffalo linkstation: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 14/21] arm: kirkwood: mplcec4: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 15/21] arm: kirkwood: readynas: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 16/21] arm: kirkwood: nsa310: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 17/21] arm: kirkwood: openblocks_a6: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 18/21] arm: kirkwood: topkick: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 19/21] arm: kirkwood: ts219: " Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 20/21] arm: kirkwood: openblocks-a6: group pinmux configurations Thomas Petazzoni
2013-05-24  9:44 ` [PATCH 21/21] arm: kirkwood: openblocks-a6: add support for Init button Thomas Petazzoni
2013-05-24 18:33 ` [PATCH 00/21] ARM: kirkwood: improve pinmux configs in Device Tree Jason Cooper
2013-05-25 13:36   ` Thomas Petazzoni
2013-05-25 16:54 ` Andrew Lunn
2013-05-27  9:10 ` yamagata at plathome.co.jp
2013-05-27  9:19   ` Thomas Petazzoni
2013-05-27 15:41   ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369388699-25975-7-git-send-email-thomas.petazzoni@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.