All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: linux-fbdev@vger.kernel.org
Subject: [PATCH] fbdev: bfin-lq035q1-fb: Use dev_pm_ops
Date: Wed, 29 May 2013 12:17:39 +0000	[thread overview]
Message-ID: <1369829859-13405-1-git-send-email-lars@metafoo.de> (raw)

Use dev_pm_ops instead of the legacy suspend/resume callbacks.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 drivers/video/bfin-lq035q1-fb.c | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/drivers/video/bfin-lq035q1-fb.c b/drivers/video/bfin-lq035q1-fb.c
index 29d8c04..6084c17 100644
--- a/drivers/video/bfin-lq035q1-fb.c
+++ b/drivers/video/bfin-lq035q1-fb.c
@@ -170,16 +170,19 @@ static int lq035q1_spidev_remove(struct spi_device *spi)
 	return lq035q1_control(spi, LQ035_SHUT_CTL, LQ035_SHUT);
 }
 
-#ifdef CONFIG_PM
-static int lq035q1_spidev_suspend(struct spi_device *spi, pm_message_t state)
+#ifdef CONFIG_PM_SLEEP
+static int lq035q1_spidev_suspend(struct device *dev)
 {
+	struct spi_device *spi = to_spi_device(dev);
+
 	return lq035q1_control(spi, LQ035_SHUT_CTL, LQ035_SHUT);
 }
 
-static int lq035q1_spidev_resume(struct spi_device *spi)
+static int lq035q1_spidev_resume(struct device *dev)
 {
-	int ret;
+	struct spi_device *spi = to_spi_device(dev);
 	struct spi_control *ctl = spi_get_drvdata(spi);
+	int ret;
 
 	ret = lq035q1_control(spi, LQ035_DRIVER_OUTPUT_CTL, ctl->mode);
 	if (ret)
@@ -187,9 +190,13 @@ static int lq035q1_spidev_resume(struct spi_device *spi)
 
 	return lq035q1_control(spi, LQ035_SHUT_CTL, LQ035_ON);
 }
+
+static SIMPLE_DEV_PM_OPS(lq035q1_spidev_pm_ops, lq035q1_spidev_suspend,
+	lq035q1_spidev_resume);
+#define LQ035Q1_SPIDEV_PM_OPS (&lq035q1_spidev_pm_ops)
+
 #else
-# define lq035q1_spidev_suspend NULL
-# define lq035q1_spidev_resume  NULL
+#define LQ035Q1_SPIDEV_PM_OPS NULL
 #endif
 
 /* Power down all displays on reboot, poweroff or halt */
@@ -708,8 +715,7 @@ static int bfin_lq035q1_probe(struct platform_device *pdev)
 	info->spidrv.probe    = lq035q1_spidev_probe;
 	info->spidrv.remove   = lq035q1_spidev_remove;
 	info->spidrv.shutdown = lq035q1_spidev_shutdown;
-	info->spidrv.suspend  = lq035q1_spidev_suspend;
-	info->spidrv.resume   = lq035q1_spidev_resume;
+	info->spidrv.driver.pm = LQ035Q1_SPIDEV_PM_OPS;
 
 	ret = spi_register_driver(&info->spidrv);
 	if (ret < 0) {
-- 
1.8.0


             reply	other threads:[~2013-05-29 12:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 12:17 Lars-Peter Clausen [this message]
2013-05-29 14:24 ` [PATCH] fbdev: bfin-lq035q1-fb: Use dev_pm_ops Michael Hennerich
2013-05-29 19:20   ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-29 19:20     ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-29 21:36     ` Rafael J. Wysocki
2013-05-29 21:36       ` Rafael J. Wysocki
2013-05-30  0:32     ` Jingoo Han
2013-05-30  0:32       ` Jingoo Han
2013-05-30  7:14       ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-30  7:14         ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-30  7:52         ` Lars-Peter Clausen
2013-05-30  7:52           ` Lars-Peter Clausen
2013-05-30 10:45           ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-30 10:45             ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-30 16:32             ` Lars-Peter Clausen
2013-05-30 16:32               ` Lars-Peter Clausen
2013-05-31  3:32             ` Jingoo Han
2013-05-31  3:32               ` Jingoo Han
2013-05-31  5:01               ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-31  5:01                 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-02 19:30               ` Rafael J. Wysocki
2013-06-02 19:30                 ` Rafael J. Wysocki
2013-06-03  5:15                 ` Jingoo Han
2013-06-03  5:15                   ` Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369829859-13405-1-git-send-email-lars@metafoo.de \
    --to=lars@metafoo.de \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.