From: Simon Horman <horms+renesas@verge.net.au>
To: Zhang Rui <rui.zhang@intel.com>, linux-pm@vger.kernel.org
Cc: linux-sh@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
Ulrich Hecht <ulrich.hecht@gmail.com>,
Simon Horman <horms+renesas@verge.net.au>
Subject: [PATCH] thermal: rcar: set up I/O base before requesting IRQ
Date: Tue, 04 Jun 2013 02:09:13 +0000 [thread overview]
Message-ID: <1370311753-6463-1-git-send-email-horms+renesas@verge.net.au> (raw)
In-Reply-To: <1369817336-1953-1-git-send-email-ulrich.hecht@gmail.com>
From: Ulrich Hecht <ulrich.hecht@gmail.com>
It is used by the interrupt handler. Fixes crash when booting via kexec
on APE6 board.
This problem was introduced by e0a5172e9eec7f0d3c476e013c51dab62f3fc666
("thermal: rcar: add interrupt support") which was introduced in v3.8-rc3.
Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
[horms+renesas@verge.net.au: enhanced changelog to include commit
that cuases the problem ]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
drivers/thermal/rcar_thermal.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
Hi Zhang,
could you consider this fix for v3.10?
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index 8d7edd4..7641dcc 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -395,13 +395,6 @@ static int rcar_thermal_probe(struct platform_device *pdev)
return -ENODEV;
}
- ret = devm_request_irq(dev, irq->start, rcar_thermal_irq, 0,
- dev_name(dev), common);
- if (ret) {
- dev_err(dev, "irq request failed\n ");
- return ret;
- }
-
/*
* rcar_has_irq_support() will be enabled
*/
@@ -409,6 +402,13 @@ static int rcar_thermal_probe(struct platform_device *pdev)
if (IS_ERR(common->base))
return PTR_ERR(common->base);
+ ret = devm_request_irq(dev, irq->start, rcar_thermal_irq, 0,
+ dev_name(dev), common);
+ if (ret) {
+ dev_err(dev, "irq request failed\n ");
+ return ret;
+ }
+
/* enable temperature comparation */
rcar_thermal_common_write(common, ENR, 0x00030303);
--
1.8.2.1
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms+renesas@verge.net.au>
To: Zhang Rui <rui.zhang@intel.com>, linux-pm@vger.kernel.org
Cc: linux-sh@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
Ulrich Hecht <ulrich.hecht@gmail.com>,
Simon Horman <horms+renesas@verge.net.au>
Subject: [PATCH] thermal: rcar: set up I/O base before requesting IRQ
Date: Tue, 4 Jun 2013 11:09:13 +0900 [thread overview]
Message-ID: <1370311753-6463-1-git-send-email-horms+renesas@verge.net.au> (raw)
From: Ulrich Hecht <ulrich.hecht@gmail.com>
It is used by the interrupt handler. Fixes crash when booting via kexec
on APE6 board.
This problem was introduced by e0a5172e9eec7f0d3c476e013c51dab62f3fc666
("thermal: rcar: add interrupt support") which was introduced in v3.8-rc3.
Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
[horms+renesas@verge.net.au: enhanced changelog to include commit
that cuases the problem ]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
drivers/thermal/rcar_thermal.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
Hi Zhang,
could you consider this fix for v3.10?
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index 8d7edd4..7641dcc 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -395,13 +395,6 @@ static int rcar_thermal_probe(struct platform_device *pdev)
return -ENODEV;
}
- ret = devm_request_irq(dev, irq->start, rcar_thermal_irq, 0,
- dev_name(dev), common);
- if (ret) {
- dev_err(dev, "irq request failed\n ");
- return ret;
- }
-
/*
* rcar_has_irq_support() will be enabled
*/
@@ -409,6 +402,13 @@ static int rcar_thermal_probe(struct platform_device *pdev)
if (IS_ERR(common->base))
return PTR_ERR(common->base);
+ ret = devm_request_irq(dev, irq->start, rcar_thermal_irq, 0,
+ dev_name(dev), common);
+ if (ret) {
+ dev_err(dev, "irq request failed\n ");
+ return ret;
+ }
+
/* enable temperature comparation */
rcar_thermal_common_write(common, ENR, 0x00030303);
--
1.8.2.1
next prev parent reply other threads:[~2013-06-04 2:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 8:48 [PATCH] thermal: rcar: set up I/O base before requesting IRQ Ulrich Hecht
2013-05-31 5:48 ` Simon Horman
2013-05-31 7:04 ` Ulrich Hecht
2013-06-04 2:09 ` Simon Horman [this message]
2013-06-04 2:09 ` Simon Horman
2013-06-04 12:53 ` Eduardo Valentin
2013-06-04 12:53 ` Eduardo Valentin
2013-06-13 2:56 ` Zhang Rui
2013-06-13 2:56 ` Zhang Rui
2013-06-04 2:10 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370311753-6463-1-git-send-email-horms+renesas@verge.net.au \
--to=horms+renesas@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=rui.zhang@intel.com \
--cc=ulrich.hecht@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.