All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@stericsson.com>
To: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Subject: [PATCH 01/12] mmc: core: Remove unnecessary check for the remove callback
Date: Mon, 10 Jun 2013 17:03:36 +0200	[thread overview]
Message-ID: <1370876627-13439-2-git-send-email-ulf.hansson@stericsson.com> (raw)
In-Reply-To: <1370876627-13439-1-git-send-email-ulf.hansson@stericsson.com>

From: Ulf Hansson <ulf.hansson@linaro.org>

For every bus_ops type the .remove callback always exist, thus there
are no need to check the existence of it, before we decide to call it.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Tested-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 drivers/mmc/core/core.c |   11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index e9a104b..d2ee282 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -2483,9 +2483,7 @@ void mmc_stop_host(struct mmc_host *host)
 	mmc_bus_get(host);
 	if (host->bus_ops && !host->bus_dead) {
 		/* Calling bus_ops->remove() with a claimed host can deadlock */
-		if (host->bus_ops->remove)
-			host->bus_ops->remove(host);
-
+		host->bus_ops->remove(host);
 		mmc_claim_host(host);
 		mmc_detach_bus(host);
 		mmc_power_off(host);
@@ -2638,8 +2636,7 @@ int mmc_suspend_host(struct mmc_host *host)
 			 * bus_ops->remove() with a claimed host can
 			 * deadlock.)
 			 */
-			if (host->bus_ops->remove)
-				host->bus_ops->remove(host);
+			host->bus_ops->remove(host);
 			mmc_claim_host(host);
 			mmc_detach_bus(host);
 			mmc_power_off(host);
@@ -2722,9 +2719,7 @@ int mmc_pm_notify(struct notifier_block *notify_block,
 			break;
 
 		/* Calling bus_ops->remove() with a claimed host can deadlock */
-		if (host->bus_ops->remove)
-			host->bus_ops->remove(host);
-
+		host->bus_ops->remove(host);
 		mmc_claim_host(host);
 		mmc_detach_bus(host);
 		mmc_power_off(host);
-- 
1.7.10


  reply	other threads:[~2013-06-10 15:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10 15:03 [PATCH 00/12] mmc: core: mmc_bus to handle suspend|resume|shutdown Ulf Hansson
2013-06-10 15:03 ` Ulf Hansson [this message]
2013-06-10 15:03 ` [PATCH 02/12] mmc: core: Validate suspend prerequisites for SDIO at SUSPEND_PREPARE Ulf Hansson
2013-06-10 15:03 ` [PATCH 03/12] mmc: core: Push common suspend|resume code into each bus_ops Ulf Hansson
2013-06-10 15:03 ` [PATCH 04/12] mmc: core: Initiate suspend|resume from mmc bus instead of mmc host Ulf Hansson
2013-06-10 15:03 ` [PATCH 05/12] mmc: core: Handle card shutdown from mmc_bus Ulf Hansson
2013-06-10 15:03 ` [PATCH 06/12] mmc: core: Extend shutdown sequence to handle bus operations Ulf Hansson
2013-06-10 15:03 ` [PATCH 07/12] mmc: core: Add shutdown callback for SD bus_ops Ulf Hansson
2013-06-10 15:03 ` [PATCH 08/12] mmc: core: Handle both poweroff notification types for eMMC Ulf Hansson
2013-06-10 15:03 ` [PATCH 09/12] mmc: core: Add shutdown callback for (e)MMC bus_ops Ulf Hansson
2013-06-10 15:03 ` [PATCH 10/12] mmc: core: Enable power_off_notify for eMMC shutdown sequence Ulf Hansson
2013-06-10 15:03 ` [PATCH 11/12] mmc: core: Invent MMC_CAP2_FULL_PWR_CYCLE Ulf Hansson
2013-06-10 15:03 ` [PATCH 12/12] mmc: core: Add DT-bindings for MMC_CAP2_FULL_PWR_CYCLE Ulf Hansson
2013-06-11  9:24 ` [PATCH 00/12] mmc: core: mmc_bus to handle suspend|resume|shutdown Linus Walleij
2013-06-12  8:15   ` Pierre Ossman
2013-06-27 15:43 ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370876627-13439-2-git-send-email-ulf.hansson@stericsson.com \
    --to=ulf.hansson@stericsson.com \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.