All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stéphane Marchesin" <marcheu@chromium.org>
To: intel-gfx@lists.freedesktop.org
Cc: daniel.vetter@ffwll.ch
Subject: [PATCH 1/2] drm/i915: tune the RC6 threshold for stability
Date: Tue, 11 Jun 2013 15:49:26 -0700	[thread overview]
Message-ID: <1370990967-22892-1-git-send-email-marcheu@chromium.org> (raw)

It's basically the same deal as the RC6+ issues on ivy bridge
except this time with RC6 on sandy bridge. Like last time the
core of the issue is that the timings don't work 100% with our
voltage regulator. So from time to time, the kernel will print
a warning message about the GPU not getting out of RC6. In
particular, I found this fairly easy to reproduce during
suspend/resume.

Changing the threshold to 150000 instead of 50000 seems to fix
the issue.

I also measured the idle power usage before/after this patch and
didn't see a difference on a sandy bridge laptop.

Signed-off-by: Stéphane Marchesin <marcheu@chromium.org>
---
 drivers/gpu/drm/i915/intel_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index aa01128..52fe8f7 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -2577,7 +2577,7 @@ static void gen6_enable_rps(struct drm_device *dev)
 
 	I915_WRITE(GEN6_RC_SLEEP, 0);
 	I915_WRITE(GEN6_RC1e_THRESHOLD, 1000);
-	I915_WRITE(GEN6_RC6_THRESHOLD, 50000);
+	I915_WRITE(GEN6_RC6_THRESHOLD, 150000);
 	I915_WRITE(GEN6_RC6p_THRESHOLD, 150000);
 	I915_WRITE(GEN6_RC6pp_THRESHOLD, 64000); /* unused */
 
-- 
1.8.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2013-06-11 22:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-11 22:49 Stéphane Marchesin [this message]
2013-06-11 22:49 ` [PATCH 2/2] drm/i915: repin bound framebuffers on resume Stéphane Marchesin
2013-06-11 22:57   ` Chris Wilson
2013-06-11 23:01     ` Stéphane Marchesin
2013-06-11 23:48       ` Chris Wilson
2013-06-12  9:15         ` [PATCH] drm/i915: Restore fences after resume and GPU resets Chris Wilson
2013-06-12 20:51           ` Daniel Vetter
2013-06-12 22:06         ` [PATCH 2/2] drm/i915: repin bound framebuffers on resume Jesse Barnes
2013-06-12 22:41           ` Chris Wilson
2013-06-14 19:12           ` Stéphane Marchesin
2013-06-14 19:21             ` Daniel Vetter
2013-06-12  9:41 ` [PATCH 1/2] drm/i915: tune the RC6 threshold for stability Chris Wilson
2013-06-14 19:13   ` Stéphane Marchesin
2013-06-14 19:32     ` Daniel Vetter
2013-06-20  0:43       ` Stéphane Marchesin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370990967-22892-1-git-send-email-marcheu@chromium.org \
    --to=marcheu@chromium.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.