From: Javier Martinez Canillas <javier.martinez@collabora.co.uk> To: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@kernel.org>, Grant Likely <grant.likely@linaro.org>, Linus Walleij <linus.walleij@linaro.org>, Samuel Ortiz <sameo@linux.intel.com>, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Russell King <linux@arm.linux.org.uk>, Ralf Baechle <ralf@linux-mips.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Javier Martinez Canillas <javier.martinez@collabora.co.uk> Subject: [PATCH 1/7] genirq: add irq_get_trigger_type() to get IRQ flags Date: Fri, 14 Jun 2013 18:40:43 +0200 [thread overview] Message-ID: <1371228049-27080-2-git-send-email-javier.martinez@collabora.co.uk> (raw) In-Reply-To: <1371228049-27080-1-git-send-email-javier.martinez@collabora.co.uk> Drivers that want to get the trigger edge/level type flags for a given interrupt have to first call irq_get_irq_data(irq) to get the struct irq_data and then irqd_get_trigger_type(irq_data) to obtain the IRQ flags. This is not only error prone but also unnecessary exposes the struct irq_data to callers. It's better to have an irq_get_trigger_type() function to obtain the edge/level flags for an IRQ. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- include/linux/irq.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/include/linux/irq.h b/include/linux/irq.h index bc4e066..0e8e3a6 100644 --- a/include/linux/irq.h +++ b/include/linux/irq.h @@ -579,6 +579,12 @@ static inline struct msi_desc *irq_data_get_msi(struct irq_data *d) return d->msi_desc; } +static inline u32 irq_get_trigger_type(unsigned int irq) +{ + struct irq_data *d = irq_get_irq_data(irq); + return d ? irqd_get_trigger_type(d) : 0; +} + int __irq_alloc_descs(int irq, unsigned int from, unsigned int cnt, int node, struct module *owner); -- 1.7.7.6
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/7] genirq: add irq_get_trigger_type() to get IRQ flags Date: Fri, 14 Jun 2013 18:40:43 +0200 [thread overview] Message-ID: <1371228049-27080-2-git-send-email-javier.martinez@collabora.co.uk> (raw) In-Reply-To: <1371228049-27080-1-git-send-email-javier.martinez@collabora.co.uk> Drivers that want to get the trigger edge/level type flags for a given interrupt have to first call irq_get_irq_data(irq) to get the struct irq_data and then irqd_get_trigger_type(irq_data) to obtain the IRQ flags. This is not only error prone but also unnecessary exposes the struct irq_data to callers. It's better to have an irq_get_trigger_type() function to obtain the edge/level flags for an IRQ. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- include/linux/irq.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/include/linux/irq.h b/include/linux/irq.h index bc4e066..0e8e3a6 100644 --- a/include/linux/irq.h +++ b/include/linux/irq.h @@ -579,6 +579,12 @@ static inline struct msi_desc *irq_data_get_msi(struct irq_data *d) return d->msi_desc; } +static inline u32 irq_get_trigger_type(unsigned int irq) +{ + struct irq_data *d = irq_get_irq_data(irq); + return d ? irqd_get_trigger_type(d) : 0; +} + int __irq_alloc_descs(int irq, unsigned int from, unsigned int cnt, int node, struct module *owner); -- 1.7.7.6
next prev parent reply other threads:[~2013-06-14 16:41 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-06-14 16:40 [PATCH 0/7] genirq: add irq_get_trigger_type() to get IRQ flags Javier Martinez Canillas 2013-06-14 16:40 ` Javier Martinez Canillas 2013-06-14 16:40 ` Javier Martinez Canillas [this message] 2013-06-14 16:40 ` [PATCH 1/7] " Javier Martinez Canillas 2013-06-25 9:52 ` [tip:irq/core] genirq: Add " tip-bot for Javier Martinez Canillas 2013-06-14 16:40 ` [PATCH 2/7] gpio: mvebu: use " Javier Martinez Canillas 2013-06-14 16:40 ` Javier Martinez Canillas 2013-06-14 18:37 ` Jason Cooper 2013-06-14 18:37 ` Jason Cooper 2013-06-25 9:52 ` [tip:irq/core] gpio: mvebu: Use " tip-bot for Javier Martinez Canillas 2013-06-14 16:40 ` [PATCH 3/7] mfd: twl4030-irq: use " Javier Martinez Canillas 2013-06-14 16:40 ` Javier Martinez Canillas 2013-06-18 8:46 ` Samuel Ortiz 2013-06-18 8:46 ` Samuel Ortiz 2013-06-25 9:52 ` [tip:irq/core] mfd: twl4030-irq: Use " tip-bot for Javier Martinez Canillas 2013-06-14 16:40 ` [PATCH 4/7] mfd: stmpe: use " Javier Martinez Canillas 2013-06-14 16:40 ` Javier Martinez Canillas 2013-06-17 9:20 ` Linus Walleij 2013-06-17 9:20 ` Linus Walleij 2013-06-17 9:20 ` Linus Walleij 2013-06-18 8:45 ` Samuel Ortiz 2013-06-18 8:45 ` Samuel Ortiz 2013-06-25 9:52 ` [tip:irq/core] " tip-bot for Javier Martinez Canillas 2013-06-14 16:40 ` [PATCH 5/7] arm: orion: " Javier Martinez Canillas 2013-06-14 16:40 ` Javier Martinez Canillas 2013-06-14 18:37 ` Jason Cooper 2013-06-14 18:37 ` Jason Cooper 2013-06-25 9:52 ` [tip:irq/core] arm: orion: Use " tip-bot for Javier Martinez Canillas 2013-06-14 16:40 ` [PATCH 6/7] MIPS: octeon: use " Javier Martinez Canillas 2013-06-14 16:40 ` Javier Martinez Canillas 2013-06-14 17:20 ` David Daney 2013-06-14 17:20 ` David Daney 2013-06-25 9:53 ` [tip:irq/core] MIPS: octeon: Use " tip-bot for Javier Martinez Canillas 2013-06-14 16:40 ` [PATCH 7/7] irqdomain: use " Javier Martinez Canillas 2013-06-14 16:40 ` Javier Martinez Canillas 2013-06-25 9:53 ` [tip:irq/core] irqdomain: Use " tip-bot for Javier Martinez Canillas 2013-06-17 22:29 ` [PATCH 0/7] genirq: add " Grant Likely 2013-06-17 22:29 ` Grant Likely 2013-06-17 22:29 ` Grant Likely 2013-06-25 7:11 ` Javier Martinez Canillas 2013-06-25 7:11 ` Javier Martinez Canillas 2013-06-25 7:11 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1371228049-27080-2-git-send-email-javier.martinez@collabora.co.uk \ --to=javier.martinez@collabora.co.uk \ --cc=andrew@lunn.ch \ --cc=benh@kernel.crashing.org \ --cc=grant.likely@linaro.org \ --cc=jason@lakedaemon.net \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@linux-mips.org \ --cc=linux@arm.linux.org.uk \ --cc=mingo@kernel.org \ --cc=ralf@linux-mips.org \ --cc=sameo@linux.intel.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.