All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 2/6] drm/crtc-helper: no need to check for fb->depth/bpp
Date: Sat, 15 Jun 2013 00:13:12 +0200	[thread overview]
Message-ID: <1371247996-6052-3-git-send-email-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <1371247996-6052-1-git-send-email-daniel.vetter@ffwll.ch>

... since we already check for fb->pixel_format, which encodes all
this. The other two fields are only for backwards compat of older
drivers (and we might want to look into eventually just killing them).

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/drm_crtc_helper.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index e57cfec..1ace9c1 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -645,11 +645,6 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set)
 			mode_changed = true;
 		} else if (set->fb == NULL) {
 			mode_changed = true;
-		} else if (set->fb->depth != set->crtc->fb->depth) {
-			mode_changed = true;
-		} else if (set->fb->bits_per_pixel !=
-			   set->crtc->fb->bits_per_pixel) {
-			mode_changed = true;
 		} else if (set->fb->pixel_format !=
 			   set->crtc->fb->pixel_format) {
 			mode_changed = true;
-- 
1.7.10.4

  parent reply	other threads:[~2013-06-14 22:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 22:13 [PATCH 0/6] fb refcount and crtc helper patches Daniel Vetter
2013-06-14 22:13 ` [PATCH 1/6] drm/crtc-helpers: Enforce sane set_config api Daniel Vetter
2013-06-14 22:13 ` Daniel Vetter [this message]
2013-06-14 22:13 ` [PATCH 3/6] drm/crtc-helper: explicit DPMS on after modeset Daniel Vetter
2013-06-15 20:41   ` [PATCH] " Daniel Vetter
2013-06-14 22:13 ` [PATCH 4/6] drm/crtc-helper: don't disable disconnected outputs Daniel Vetter
2013-06-15 20:41   ` [PATCH] " Daniel Vetter
2013-06-25  1:09     ` Dave Airlie
2013-06-25  9:29       ` Daniel Vetter
2013-06-14 22:13 ` [PATCH 5/6] drm: check that ->set_config properly updates the fb Daniel Vetter
2013-06-14 22:13 ` [PATCH 6/6] drm: fix fb leak in setcrtc Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371247996-6052-3-git-send-email-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.