From: Jeff Layton <jlayton@redhat.com>
To: viro@zeniv.linux.org.uk, matthew@wil.cx, bfields@fieldses.org
Cc: linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
cluster-devel@redhat.com, sage@inktank.com,
samba-technical@lists.samba.org, Trond.Myklebust@netapp.com,
linux-kernel@vger.kernel.org, piastryyy@gmail.com,
linux-afs@lists.infradead.org, dhowells@redhat.com,
smfrench@gmail.com, linux-fsdevel@vger.kernel.org,
ceph-devel@vger.kernel.org, akpm@linux-foundation.org
Subject: [PATCH v3 04/13] locks: make "added" in __posix_lock_file a bool
Date: Mon, 17 Jun 2013 11:13:47 -0400 [thread overview]
Message-ID: <1371482036-15958-5-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1371482036-15958-1-git-send-email-jlayton@redhat.com>
...save 3 bytes of stack space.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: J. Bruce Fields <bfields@fieldses.org>
---
fs/locks.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 1e6301b..c186649 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -791,7 +791,8 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
struct file_lock *left = NULL;
struct file_lock *right = NULL;
struct file_lock **before;
- int error, added = 0;
+ int error;
+ bool added = false;
/*
* We may need two file_lock structures for this operation,
@@ -885,7 +886,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
continue;
}
request = fl;
- added = 1;
+ added = true;
}
else {
/* Processing for different lock types is a bit
@@ -896,7 +897,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
if (fl->fl_start > request->fl_end)
break;
if (request->fl_type == F_UNLCK)
- added = 1;
+ added = true;
if (fl->fl_start < request->fl_start)
left = fl;
/* If the next lock in the list has a higher end
@@ -926,7 +927,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
locks_release_private(fl);
locks_copy_private(fl, request);
request = fl;
- added = 1;
+ added = true;
}
}
/* Go on to next lock.
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jlayton@redhat.com>
To: viro@zeniv.linux.org.uk, matthew@wil.cx, bfields@fieldses.org
Cc: dhowells@redhat.com, sage@inktank.com, smfrench@gmail.com,
swhiteho@redhat.com, Trond.Myklebust@netapp.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
cluster-devel@redhat.com, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, piastryyy@gmail.com
Subject: [PATCH v3 04/13] locks: make "added" in __posix_lock_file a bool
Date: Mon, 17 Jun 2013 11:13:47 -0400 [thread overview]
Message-ID: <1371482036-15958-5-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1371482036-15958-1-git-send-email-jlayton@redhat.com>
...save 3 bytes of stack space.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: J. Bruce Fields <bfields@fieldses.org>
---
fs/locks.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 1e6301b..c186649 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -791,7 +791,8 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
struct file_lock *left = NULL;
struct file_lock *right = NULL;
struct file_lock **before;
- int error, added = 0;
+ int error;
+ bool added = false;
/*
* We may need two file_lock structures for this operation,
@@ -885,7 +886,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
continue;
}
request = fl;
- added = 1;
+ added = true;
}
else {
/* Processing for different lock types is a bit
@@ -896,7 +897,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
if (fl->fl_start > request->fl_end)
break;
if (request->fl_type == F_UNLCK)
- added = 1;
+ added = true;
if (fl->fl_start < request->fl_start)
left = fl;
/* If the next lock in the list has a higher end
@@ -926,7 +927,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
locks_release_private(fl);
locks_copy_private(fl, request);
request = fl;
- added = 1;
+ added = true;
}
}
/* Go on to next lock.
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jlayton@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v3 04/13] locks: make "added" in __posix_lock_file a bool
Date: Mon, 17 Jun 2013 11:13:47 -0400 [thread overview]
Message-ID: <1371482036-15958-5-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1371482036-15958-1-git-send-email-jlayton@redhat.com>
...save 3 bytes of stack space.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: J. Bruce Fields <bfields@fieldses.org>
---
fs/locks.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 1e6301b..c186649 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -791,7 +791,8 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
struct file_lock *left = NULL;
struct file_lock *right = NULL;
struct file_lock **before;
- int error, added = 0;
+ int error;
+ bool added = false;
/*
* We may need two file_lock structures for this operation,
@@ -885,7 +886,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
continue;
}
request = fl;
- added = 1;
+ added = true;
}
else {
/* Processing for different lock types is a bit
@@ -896,7 +897,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
if (fl->fl_start > request->fl_end)
break;
if (request->fl_type == F_UNLCK)
- added = 1;
+ added = true;
if (fl->fl_start < request->fl_start)
left = fl;
/* If the next lock in the list has a higher end
@@ -926,7 +927,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
locks_release_private(fl);
locks_copy_private(fl, request);
request = fl;
- added = 1;
+ added = true;
}
}
/* Go on to next lock.
--
1.7.1
next prev parent reply other threads:[~2013-06-17 15:13 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 15:13 [PATCH v3 00/13] locks: scalability improvements for file locking Jeff Layton
2013-06-17 15:13 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` Jeff Layton
2013-06-17 15:13 ` [PATCH v3 01/13] cifs: use posix_unblock_lock instead of locks_delete_block Jeff Layton
2013-06-17 15:13 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` Jeff Layton
2013-06-17 15:13 ` [PATCH v3 02/13] locks: make generic_add_lease and generic_delete_lease static Jeff Layton
2013-06-17 15:13 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` Jeff Layton
2013-06-17 15:13 ` [PATCH v3 03/13] locks: comment cleanups and clarifications Jeff Layton
2013-06-17 15:13 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` Jeff Layton
2013-06-17 15:13 ` Jeff Layton [this message]
2013-06-17 15:13 ` [Cluster-devel] [PATCH v3 04/13] locks: make "added" in __posix_lock_file a bool Jeff Layton
2013-06-17 15:13 ` Jeff Layton
2013-06-17 15:13 ` [PATCH v3 05/13] locks: encapsulate the fl_link list handling Jeff Layton
2013-06-17 15:13 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` Jeff Layton
2013-06-17 15:13 ` [PATCH v3 06/13] locks: protect most of the file_lock handling with i_lock Jeff Layton
2013-06-17 15:13 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` Jeff Layton
[not found] ` <1371482036-15958-7-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-17 15:46 ` Jeff Layton
2013-06-17 15:46 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:46 ` Jeff Layton
2013-06-17 15:49 ` Jeff Layton
2013-06-17 15:49 ` [Cluster-devel] " Jeff Layton
2013-06-18 17:43 ` Jeff Layton
2013-06-18 17:43 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` [PATCH v3 07/13] locks: avoid taking global lock if possible when waking up blocked waiters Jeff Layton
2013-06-17 15:13 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` Jeff Layton
[not found] ` <1371482036-15958-8-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-17 15:55 ` Jeff Layton
2013-06-17 15:55 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:55 ` Jeff Layton
2013-06-17 15:13 ` [PATCH v3 08/13] locks: convert fl_link to a hlist_node Jeff Layton
2013-06-17 15:13 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` Jeff Layton
2013-06-17 15:13 ` [PATCH v3 09/13] locks: turn the blocked_list into a hashtable Jeff Layton
2013-06-17 15:13 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` Jeff Layton
2013-06-17 15:13 ` [PATCH v3 10/13] locks: add a new "lm_owner_key" lock operation Jeff Layton
2013-06-17 15:13 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` [PATCH v3 11/13] locks: give the blocked_hash its own spinlock Jeff Layton
2013-06-17 15:13 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` Jeff Layton
2013-06-17 15:13 ` [PATCH v3 12/13] seq_file: add seq_list_*_percpu helpers Jeff Layton
2013-06-17 15:13 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` Jeff Layton
2013-06-17 15:13 ` [PATCH v3 13/13] locks: move file_lock_list to a set of percpu hlist_heads and convert file_lock_lock to an lglock Jeff Layton
2013-06-17 15:13 ` [Cluster-devel] " Jeff Layton
2013-06-17 15:13 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371482036-15958-5-git-send-email-jlayton@redhat.com \
--to=jlayton@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=ceph-devel@vger.kernel.org \
--cc=cluster-devel@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=piastryyy@gmail.com \
--cc=sage@inktank.com \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.