All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 02/13] drm/i915/dvo: switch ->mode_fixup to ->compute_config
Date: Sun, 21 Jul 2013 21:36:58 +0200	[thread overview]
Message-ID: <1374435429-5543-3-git-send-email-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <1374435429-5543-1-git-send-email-daniel.vetter@ffwll.ch>

This is the last encoder ->mode_fixup callback we have left, so
convert it.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_dvo.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/drm/i915/intel_dvo.c
index d820884..1297ea3 100644
--- a/drivers/gpu/drm/i915/intel_dvo.c
+++ b/drivers/gpu/drm/i915/intel_dvo.c
@@ -241,11 +241,11 @@ static int intel_dvo_mode_valid(struct drm_connector *connector,
 	return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode);
 }
 
-static bool intel_dvo_mode_fixup(struct drm_encoder *encoder,
-				 const struct drm_display_mode *mode,
-				 struct drm_display_mode *adjusted_mode)
+static bool intel_dvo_compute_config(struct intel_encoder *encoder,
+				     struct intel_crtc_config *pipe_config)
 {
-	struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));
+	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
+	struct drm_display_mode *adjusted_mode = &pipe_config->adjusted_mode;
 
 	/* If we have timings from the BIOS for the panel, put them in
 	 * to the adjusted mode.  The CRTC will be set up for this mode,
@@ -267,7 +267,9 @@ static bool intel_dvo_mode_fixup(struct drm_encoder *encoder,
 	}
 
 	if (intel_dvo->dev.dev_ops->mode_fixup)
-		return intel_dvo->dev.dev_ops->mode_fixup(&intel_dvo->dev, mode, adjusted_mode);
+		return intel_dvo->dev.dev_ops->mode_fixup(&intel_dvo->dev,
+							  &pipe_config->requested_mode,
+							  adjusted_mode);
 
 	return true;
 }
@@ -370,7 +372,6 @@ static void intel_dvo_destroy(struct drm_connector *connector)
 }
 
 static const struct drm_encoder_helper_funcs intel_dvo_helper_funcs = {
-	.mode_fixup = intel_dvo_mode_fixup,
 	.mode_set = intel_dvo_mode_set,
 };
 
@@ -468,6 +469,7 @@ void intel_dvo_init(struct drm_device *dev)
 	intel_encoder->enable = intel_enable_dvo;
 	intel_encoder->get_hw_state = intel_dvo_get_hw_state;
 	intel_encoder->get_config = intel_dvo_get_config;
+	intel_encoder->compute_config = intel_dvo_compute_config;
 	intel_connector->get_hw_state = intel_dvo_connector_get_hw_state;
 
 	/* Now, try to find a controller */
-- 
1.8.1.4

  parent reply	other threads:[~2013-07-21 20:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-21 19:36 [PATCH 00/13] modeset interface cleanups Daniel Vetter
2013-07-21 19:36 ` [PATCH 01/13] drm/i915/dvo: use intel_encoder to the upcast macro Daniel Vetter
2013-07-21 19:36 ` Daniel Vetter [this message]
2013-07-26 18:39   ` [PATCH 02/13] drm/i915/dvo: switch ->mode_fixup to ->compute_config Rodrigo Vivi
2013-07-26 19:23     ` Daniel Vetter
2013-07-21 19:36 ` [PATCH 03/13] drm/i915: rip out legacy encoder->mode_fixup logic Daniel Vetter
2013-07-21 19:37 ` [PATCH 04/13] drm/i915/dvo: use native encoder ->mode_set callback Daniel Vetter
2013-07-21 19:37 ` [PATCH 05/13] drm/i915/sdvo: use intel_encoder for upcast helper Daniel Vetter
2013-07-21 19:37 ` [PATCH 06/13] drm/i915/tv: Use native encoder->mode_set callback Daniel Vetter
2013-07-21 19:37 ` [PATCH 07/13] drm/i915/crt: use " Daniel Vetter
2013-07-21 19:37 ` [PATCH 08/13] drm/i915/hdmi: use native encoder mode_set callback Daniel Vetter
2013-07-21 19:37 ` [PATCH 09/13] drm/i915/dp: use native encoder ->mode_set callback Daniel Vetter
2013-07-21 19:37 ` [PATCH 10/13] drm/i915/lvds: use the " Daniel Vetter
2013-07-21 19:37 ` [PATCH 11/13] drm/i915/ddi: " Daniel Vetter
2013-07-21 19:37 ` [PATCH 12/13] drm/i915: rip out legacy encoder->mode_set callback Daniel Vetter
2013-07-21 19:37 ` [PATCH 13/13] drm/i915: clean up crtc timings computation Daniel Vetter
2013-07-26 18:40   ` Rodrigo Vivi
2013-07-26 19:24     ` Daniel Vetter
2013-07-26 18:42 ` [PATCH 00/13] modeset interface cleanups Rodrigo Vivi
2013-07-26 22:05   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374435429-5543-3-git-send-email-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.