All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 03/13] drm/i915: rip out legacy encoder->mode_fixup logic
Date: Sun, 21 Jul 2013 21:36:59 +0200	[thread overview]
Message-ID: <1374435429-5543-4-git-send-email-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <1374435429-5543-1-git-send-email-daniel.vetter@ffwll.ch>

Everyone is now using our own ->compute_config callback, which means
we can now also make that callback mandatory.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_display.c | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 62c5ab9..1ff8f9c 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -4109,7 +4109,7 @@ static int intel_crtc_compute_config(struct intel_crtc *crtc,
 	}
 
 	/* All interlaced capable intel hw wants timings in frames. Note though
-	 * that intel_lvds_mode_fixup does some funny tricks with the crtc
+	 * that intel_lvds_compute_config does some funny tricks with the crtc
 	 * timings, so we need to be careful not to clobber these.*/
 	if (!pipe_config->timings_set)
 		drm_mode_set_crtcinfo(adjusted_mode, 0);
@@ -7856,7 +7856,6 @@ intel_modeset_pipe_config(struct drm_crtc *crtc,
 			  struct drm_display_mode *mode)
 {
 	struct drm_device *dev = crtc->dev;
-	struct drm_encoder_helper_funcs *encoder_funcs;
 	struct intel_encoder *encoder;
 	struct intel_crtc_config *pipe_config;
 	int plane_bpp, ret = -EINVAL;
@@ -7901,20 +7900,8 @@ encoder_retry:
 		if (&encoder->new_crtc->base != crtc)
 			continue;
 
-		if (encoder->compute_config) {
-			if (!(encoder->compute_config(encoder, pipe_config))) {
-				DRM_DEBUG_KMS("Encoder config failure\n");
-				goto fail;
-			}
-
-			continue;
-		}
-
-		encoder_funcs = encoder->base.helper_private;
-		if (!(encoder_funcs->mode_fixup(&encoder->base,
-						&pipe_config->requested_mode,
-						&pipe_config->adjusted_mode))) {
-			DRM_DEBUG_KMS("Encoder fixup failed\n");
+		if (!(encoder->compute_config(encoder, pipe_config))) {
+			DRM_DEBUG_KMS("Encoder config failure\n");
 			goto fail;
 		}
 	}
-- 
1.8.1.4

  parent reply	other threads:[~2013-07-21 20:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-21 19:36 [PATCH 00/13] modeset interface cleanups Daniel Vetter
2013-07-21 19:36 ` [PATCH 01/13] drm/i915/dvo: use intel_encoder to the upcast macro Daniel Vetter
2013-07-21 19:36 ` [PATCH 02/13] drm/i915/dvo: switch ->mode_fixup to ->compute_config Daniel Vetter
2013-07-26 18:39   ` Rodrigo Vivi
2013-07-26 19:23     ` Daniel Vetter
2013-07-21 19:36 ` Daniel Vetter [this message]
2013-07-21 19:37 ` [PATCH 04/13] drm/i915/dvo: use native encoder ->mode_set callback Daniel Vetter
2013-07-21 19:37 ` [PATCH 05/13] drm/i915/sdvo: use intel_encoder for upcast helper Daniel Vetter
2013-07-21 19:37 ` [PATCH 06/13] drm/i915/tv: Use native encoder->mode_set callback Daniel Vetter
2013-07-21 19:37 ` [PATCH 07/13] drm/i915/crt: use " Daniel Vetter
2013-07-21 19:37 ` [PATCH 08/13] drm/i915/hdmi: use native encoder mode_set callback Daniel Vetter
2013-07-21 19:37 ` [PATCH 09/13] drm/i915/dp: use native encoder ->mode_set callback Daniel Vetter
2013-07-21 19:37 ` [PATCH 10/13] drm/i915/lvds: use the " Daniel Vetter
2013-07-21 19:37 ` [PATCH 11/13] drm/i915/ddi: " Daniel Vetter
2013-07-21 19:37 ` [PATCH 12/13] drm/i915: rip out legacy encoder->mode_set callback Daniel Vetter
2013-07-21 19:37 ` [PATCH 13/13] drm/i915: clean up crtc timings computation Daniel Vetter
2013-07-26 18:40   ` Rodrigo Vivi
2013-07-26 19:24     ` Daniel Vetter
2013-07-26 18:42 ` [PATCH 00/13] modeset interface cleanups Rodrigo Vivi
2013-07-26 22:05   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374435429-5543-4-git-send-email-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.