All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 04/20] drm/prime: add a bit of documentation about gem_obj->import_attach
Date: Thu, 15 Aug 2013 00:02:33 +0200	[thread overview]
Message-ID: <1376517769-7171-5-git-send-email-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <1376517769-7171-1-git-send-email-daniel.vetter@ffwll.ch>

Lifetime rules seem to be solid around ->import_attach. So this patch
just properly documents them.

Note that pointing directly at the attachment might have issues for
devices that have multiple struct device *dev parts constituting the
logical gpu and so might need multiple attachment points. Similarly
for drm devices which don't need a dma attachment at all (like udl).

But fixing that up is material for different patches.

Reviewed-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 include/drm/drmP.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 016e75e..3711e97 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -678,7 +678,16 @@ struct drm_gem_object {
 	/* dma buf exported from this GEM object */
 	struct dma_buf *export_dma_buf;
 
-	/* dma buf attachment backing this object */
+	/**
+	 * import_attach - dma buf attachment backing this object
+	 *
+	 * Any foreign dma_buf imported as a gem object has this set to the
+	 * attachment point for the device. This is invariant over the lifetime
+	 * of a gem object.
+	 *
+	 * The driver's ->gem_free_object callback is responsible for cleaning
+	 * up the dma_buf attachment and references acquired at import time.
+	 */
 	struct dma_buf_attachment *import_attach;
 };
 
-- 
1.8.3.2

  parent reply	other threads:[~2013-08-14 22:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14 22:02 [PATCH 00/20] prime patches Daniel Vetter
2013-08-14 22:02 ` [PATCH 01/20] drm: use common drm_gem_dmabuf_release in i915/exynos drivers Daniel Vetter
2013-08-14 22:02 ` [PATCH 02/20] drm/exynos: explicit store base gem object in dma_buf->priv Daniel Vetter
2013-08-14 22:02 ` [PATCH 03/20] drm/prime: remove cargo-cult locking from map_sg helper Daniel Vetter
2013-08-14 22:02 ` Daniel Vetter [this message]
2013-08-14 22:02 ` [PATCH 05/20] drm/gem: move drm_gem_object_handle_unreference_unlocked into drm_gem.c Daniel Vetter
2013-08-14 22:02 ` [PATCH 06/20] drm/gem: remove bogus NULL check from drm_gem_object_handle_unreference_unlocked Daniel Vetter
2013-08-14 22:02 ` [PATCH 07/20] drm/gem: WARN about unbalanced handle refcounts Daniel Vetter
2013-08-14 22:02 ` [PATCH 08/20] drm/gem: fix up flink name create race Daniel Vetter
2013-08-14 22:02 ` [PATCH 09/20] drm/prime: fix error path in drm_gem_prime_fd_to_handle Daniel Vetter
2013-08-14 22:02 ` [PATCH 10/20] drm/gem: make drm_gem_object_handle_unreference_unlocked static Daniel Vetter
2013-08-14 22:02 ` [PATCH 11/20] drm/gem: create drm_gem_dumb_destroy Daniel Vetter
     [not found]   ` <20130815072447.GC21854@nuc-i3427.alporthouse.com>
2013-08-15  8:03     ` Daniel Vetter
2013-08-14 22:02 ` [PATCH 12/20] drm/prime: use proper pointer in drm_gem_prime_handle_to_fd Daniel Vetter
2013-08-14 22:02 ` [PATCH 13/20] drm/prime: shrink critical section protected by prime lock Daniel Vetter
2013-08-14 22:02 ` [PATCH 14/20] drm/prime: clarify logic a bit in drm_gem_prime_fd_to_handle Daniel Vetter
2013-08-14 22:02 ` [PATCH 15/20] drm/gem: switch dev->object_name_lock to a mutex Daniel Vetter
2013-08-14 22:02 ` [PATCH 16/20] drm/gem: completely close gem_open vs. gem_close races Daniel Vetter
2013-08-14 22:02 ` [PATCH 17/20] drm/prime: proper locking+refcounting for obj->dma_buf link Daniel Vetter
2013-08-14 22:02 ` [PATCH 18/20] drm/prime: Simplify drm_gem_remove_prime_handles Daniel Vetter
2013-08-14 22:02 ` [PATCH 19/20] drm/prime: make drm_prime_lookup_buf_handle static Daniel Vetter
2013-08-14 22:02 ` [PATCH 20/20] drm/prime: Always add exported buffers to the handle cache Daniel Vetter
  -- strict thread matches above, loose matches on Subject: below --
2013-07-16  7:11 [PATCH 00/20] prime/flink fixes and related stuff Daniel Vetter
2013-07-16  7:11 ` [PATCH 04/20] drm/prime: add a bit of documentation about gem_obj->import_attach Daniel Vetter
2013-07-22 22:56   ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376517769-7171-5-git-send-email-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.