All of lore.kernel.org
 help / color / mirror / Atom feed
From: Padmavathi Venna <padma.v@samsung.com>
To: linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	padma.v@samsung.com, padma.kvr@gmail.com
Cc: broonie@kernel.org, kgene.kim@samsung.com, olof@lixom.net,
	tushar.behera@linaro.org
Subject: [PATCH V5] ARM: dts: Change i2s compatible string on exynos5250
Date: Fri, 16 Aug 2013 09:56:18 +0530	[thread overview]
Message-ID: <1376627178-28649-1-git-send-email-padma.v@samsung.com> (raw)

This patch removes quirks from i2s node and change the i2s
compatible names.

Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
---

Changes since V4:
	- Mark Brown reverted the below two patches due to below build failure with
	  exynos_defconfig.
		"ARM: dts: exynos5250: move common i2s properties to exynos5 dtsi"
		"ARM: dts: Change i2s compatible string on exynos5250"

	  build error:
	  DTC     arch/arm/boot/dts/exynos5420-smdk5420.dtb
	  ERROR (phandle_references): Reference to non-existent node or label "pdma1"
	  ERROR (phandle_references): Reference to non-existent node or label "pdma1"
	  ERROR (phandle_references): Reference to non-existent node or label "pdma0"
	  ERROR (phandle_references): Reference to non-existent node or label "pdma0"

But with out "ARM: dts: Change i2s compatible string on exynos5250" will break the i2s
driver.

So posting this patch now and will take care of posting other patch later after dependent
patches got merged.

 arch/arm/boot/dts/exynos5250.dtsi |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index ef57277..376090f 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -405,7 +405,7 @@
 	};
 
 	i2s0: i2s@03830000 {
-		compatible = "samsung,i2s-v5";
+		compatible = "samsung,s5pv210-i2s";
 		reg = <0x03830000 0x100>;
 		dmas = <&pdma0 10
 			&pdma0 9
@@ -415,16 +415,13 @@
 			<&clock_audss EXYNOS_I2S_BUS>,
 			<&clock_audss EXYNOS_SCLK_I2S>;
 		clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
-		samsung,supports-6ch;
-		samsung,supports-rstclr;
-		samsung,supports-secdai;
 		samsung,idma-addr = <0x03000000>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&i2s0_bus>;
 	};
 
 	i2s1: i2s@12D60000 {
-		compatible = "samsung,i2s-v5";
+		compatible = "samsung,s3c6410-i2s";
 		reg = <0x12D60000 0x100>;
 		dmas = <&pdma1 12
 			&pdma1 11>;
@@ -436,7 +433,7 @@
 	};
 
 	i2s2: i2s@12D70000 {
-		compatible = "samsung,i2s-v5";
+		compatible = "samsung,s3c6410-i2s";
 		reg = <0x12D70000 0x100>;
 		dmas = <&pdma0 12
 			&pdma0 11>;
-- 
1.7.4.4

WARNING: multiple messages have this Message-ID (diff)
From: padma.v@samsung.com (Padmavathi Venna)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5] ARM: dts: Change i2s compatible string on exynos5250
Date: Fri, 16 Aug 2013 09:56:18 +0530	[thread overview]
Message-ID: <1376627178-28649-1-git-send-email-padma.v@samsung.com> (raw)

This patch removes quirks from i2s node and change the i2s
compatible names.

Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
---

Changes since V4:
	- Mark Brown reverted the below two patches due to below build failure with
	  exynos_defconfig.
		"ARM: dts: exynos5250: move common i2s properties to exynos5 dtsi"
		"ARM: dts: Change i2s compatible string on exynos5250"

	  build error:
	  DTC     arch/arm/boot/dts/exynos5420-smdk5420.dtb
	  ERROR (phandle_references): Reference to non-existent node or label "pdma1"
	  ERROR (phandle_references): Reference to non-existent node or label "pdma1"
	  ERROR (phandle_references): Reference to non-existent node or label "pdma0"
	  ERROR (phandle_references): Reference to non-existent node or label "pdma0"

But with out "ARM: dts: Change i2s compatible string on exynos5250" will break the i2s
driver.

So posting this patch now and will take care of posting other patch later after dependent
patches got merged.

 arch/arm/boot/dts/exynos5250.dtsi |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index ef57277..376090f 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -405,7 +405,7 @@
 	};
 
 	i2s0: i2s at 03830000 {
-		compatible = "samsung,i2s-v5";
+		compatible = "samsung,s5pv210-i2s";
 		reg = <0x03830000 0x100>;
 		dmas = <&pdma0 10
 			&pdma0 9
@@ -415,16 +415,13 @@
 			<&clock_audss EXYNOS_I2S_BUS>,
 			<&clock_audss EXYNOS_SCLK_I2S>;
 		clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
-		samsung,supports-6ch;
-		samsung,supports-rstclr;
-		samsung,supports-secdai;
 		samsung,idma-addr = <0x03000000>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&i2s0_bus>;
 	};
 
 	i2s1: i2s at 12D60000 {
-		compatible = "samsung,i2s-v5";
+		compatible = "samsung,s3c6410-i2s";
 		reg = <0x12D60000 0x100>;
 		dmas = <&pdma1 12
 			&pdma1 11>;
@@ -436,7 +433,7 @@
 	};
 
 	i2s2: i2s at 12D70000 {
-		compatible = "samsung,i2s-v5";
+		compatible = "samsung,s3c6410-i2s";
 		reg = <0x12D70000 0x100>;
 		dmas = <&pdma0 12
 			&pdma0 11>;
-- 
1.7.4.4

             reply	other threads:[~2013-08-16  4:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16  4:26 Padmavathi Venna [this message]
2013-08-16  4:26 ` [PATCH V5] ARM: dts: Change i2s compatible string on exynos5250 Padmavathi Venna
2013-08-16  4:48 ` Olof Johansson
2013-08-16  4:48   ` Olof Johansson
2013-08-16  5:43   ` Kukjin Kim
2013-08-16  5:43     ` Kukjin Kim
2013-08-16  7:53     ` Tomasz Figa
2013-08-16  7:53       ` Tomasz Figa
2013-08-16  9:59       ` Mark Brown
2013-08-16  9:59         ` Mark Brown
2013-08-18 18:05       ` Kukjin Kim
2013-08-18 18:05         ` Kukjin Kim
2013-08-16  7:48   ` Tomasz Figa
2013-08-16  7:48     ` Tomasz Figa
2013-08-16 10:06 ` Mark Brown
2013-08-16 10:06   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376627178-28649-1-git-send-email-padma.v@samsung.com \
    --to=padma.v@samsung.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=padma.kvr@gmail.com \
    --cc=tushar.behera@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.