From: Doug Anderson <dianders@chromium.org>
To: Chris Ball <cjb@laptop.org>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
Seungwon Jeon <tgih.jun@samsung.com>,
James Hogan <james.hogan@imgtec.com>,
Grant Grundler <grundler@chromium.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Abhilash Kesavan <a.kesavan@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Olof Johansson <olof@lixom.net>,
Doug Anderson <dianders@chromium.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v6 3/3] mmc: dw_mmc: Set timeout to max upon resume
Date: Thu, 22 Aug 2013 09:19:08 -0700 [thread overview]
Message-ID: <1377188348-3418-4-git-send-email-dianders@chromium.org> (raw)
In-Reply-To: <1377188348-3418-1-git-send-email-dianders@chromium.org>
The TMOUT register is initted to 0xffffffff at probe time but isn't
initted after suspend/resume. Add an init of this value.
No problems were observed without this (it will also get initted in
__dw_mci_start_request if there is data to send), but it makes the
register dump before and after suspend cleaner.
Signed-off-by: Doug Anderson <dianders@chromium.org>
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/mmc/host/dw_mmc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index f6c7545..6a9a846 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -2506,6 +2506,9 @@ int dw_mci_resume(struct dw_mci *host)
/* Restore the old value at FIFOTH register */
mci_writel(host, FIFOTH, host->fifoth_val);
+ /* Put in max timeout */
+ mci_writel(host, TMOUT, 0xFFFFFFFF);
+
mci_writel(host, RINTSTS, 0xFFFFFFFF);
mci_writel(host, INTMASK, SDMMC_INT_CMD_DONE | SDMMC_INT_DATA_OVER |
SDMMC_INT_TXDR | SDMMC_INT_RXDR |
--
1.8.3
next prev parent reply other threads:[~2013-08-22 16:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 16:19 [PATCH v6 0/3] mmc: dw_mmc: fixes for suspend/resume on exynos Doug Anderson
2013-08-22 16:19 ` Doug Anderson
2013-08-22 16:19 ` [PATCH v6 1/3] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT Doug Anderson
2013-08-22 16:19 ` Doug Anderson
2013-08-22 16:19 ` [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock) Doug Anderson
2013-08-23 13:21 ` Jaehoon Chung
2013-08-23 20:40 ` Doug Anderson
2013-08-26 1:31 ` Jaehoon Chung
2013-08-26 3:38 ` Doug Anderson
2013-08-26 4:34 ` Seungwon Jeon
2013-08-26 9:06 ` Jaehoon Chung
2013-08-26 16:05 ` Doug Anderson
2013-08-29 7:04 ` Seungwon Jeon
2013-08-29 16:34 ` Doug Anderson
2013-08-30 3:55 ` Seungwon Jeon
2013-08-22 16:19 ` Doug Anderson [this message]
2013-08-23 12:56 ` [PATCH v6 3/3] mmc: dw_mmc: Set timeout to max upon resume Jaehoon Chung
2013-08-29 16:39 ` [PATCH v7 0/3] mmc: dw_mmc: fixes for suspend/resume on exynos Doug Anderson
2013-08-29 16:39 ` Doug Anderson
2013-08-29 16:39 ` Doug Anderson
2013-08-29 16:39 ` [PATCH v7 1/3] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT Doug Anderson
2013-08-29 16:39 ` Doug Anderson
2013-08-29 16:39 ` [PATCH v7 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock) Doug Anderson
2013-08-30 11:31 ` Seungwon Jeon
2013-08-29 16:39 ` [PATCH v7 3/3] mmc: dw_mmc: Set timeout to max upon resume Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377188348-3418-4-git-send-email-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=a.kesavan@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=cjb@laptop.org \
--cc=grundler@chromium.org \
--cc=james.hogan@imgtec.com \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=tgih.jun@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.