All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jason Wang <jasowang@redhat.com>
Subject: [PATCH V3 1/6] vhost_net: make vhost_zerocopy_signal_used() return void
Date: Mon,  2 Sep 2013 16:40:56 +0800	[thread overview]
Message-ID: <1378111261-14826-2-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1378111261-14826-1-git-send-email-jasowang@redhat.com>

None of its caller use its return value, so let it return void.

Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 drivers/vhost/net.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index 969a859..280ee66 100644
--- a/drivers/vhost/net.c
+++ b/drivers/vhost/net.c
@@ -276,8 +276,8 @@ static void copy_iovec_hdr(const struct iovec *from, struct iovec *to,
  * of used idx. Once lower device DMA done contiguously, we will signal KVM
  * guest used idx.
  */
-static int vhost_zerocopy_signal_used(struct vhost_net *net,
-				      struct vhost_virtqueue *vq)
+static void vhost_zerocopy_signal_used(struct vhost_net *net,
+				       struct vhost_virtqueue *vq)
 {
 	struct vhost_net_virtqueue *nvq =
 		container_of(vq, struct vhost_net_virtqueue, vq);
@@ -297,7 +297,6 @@ static int vhost_zerocopy_signal_used(struct vhost_net *net,
 	}
 	if (j)
 		nvq->done_idx = i;
-	return j;
 }
 
 static void vhost_zerocopy_callback(struct ubuf_info *ubuf, bool success)
-- 
1.7.1


WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/6] vhost_net: make vhost_zerocopy_signal_used() return void
Date: Mon,  2 Sep 2013 16:40:56 +0800	[thread overview]
Message-ID: <1378111261-14826-2-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1378111261-14826-1-git-send-email-jasowang@redhat.com>

None of its caller use its return value, so let it return void.

Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 drivers/vhost/net.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index 969a859..280ee66 100644
--- a/drivers/vhost/net.c
+++ b/drivers/vhost/net.c
@@ -276,8 +276,8 @@ static void copy_iovec_hdr(const struct iovec *from, struct iovec *to,
  * of used idx. Once lower device DMA done contiguously, we will signal KVM
  * guest used idx.
  */
-static int vhost_zerocopy_signal_used(struct vhost_net *net,
-				      struct vhost_virtqueue *vq)
+static void vhost_zerocopy_signal_used(struct vhost_net *net,
+				       struct vhost_virtqueue *vq)
 {
 	struct vhost_net_virtqueue *nvq =
 		container_of(vq, struct vhost_net_virtqueue, vq);
@@ -297,7 +297,6 @@ static int vhost_zerocopy_signal_used(struct vhost_net *net,
 	}
 	if (j)
 		nvq->done_idx = i;
-	return j;
 }
 
 static void vhost_zerocopy_callback(struct ubuf_info *ubuf, bool success)
-- 
1.7.1

  reply	other threads:[~2013-09-02  8:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-02  8:40 [PATCH V3 0/6] vhost code cleanup and minor enhancement Jason Wang
2013-09-02  8:40 ` Jason Wang
2013-09-02  8:40 ` Jason Wang [this message]
2013-09-02  8:40   ` [PATCH V3 1/6] vhost_net: make vhost_zerocopy_signal_used() return void Jason Wang
2013-09-02  8:40 ` [PATCH V3 2/6] vhost_net: use vhost_add_used_and_signal_n() in vhost_zerocopy_signal_used() Jason Wang
2013-09-02  8:40   ` Jason Wang
2013-09-02  8:40 ` [PATCH V3 3/6] vhost: switch to use vhost_add_used_n() Jason Wang
2013-09-02  8:40   ` Jason Wang
2013-09-02  8:40 ` [PATCH V3 4/6] vhost_net: determine whether or not to use zerocopy at one time Jason Wang
2013-09-02  8:40   ` Jason Wang
2013-09-04 11:59   ` Michael S. Tsirkin
2013-09-04 11:59     ` Michael S. Tsirkin
2013-09-05  2:54     ` Jason Wang
2013-09-05  2:54       ` Jason Wang
2013-09-23  7:16       ` Michael S. Tsirkin
2013-09-23  7:16         ` Michael S. Tsirkin
2013-09-26  4:30         ` Jason Wang
2013-09-26  4:30           ` Jason Wang
2013-09-29  9:36           ` Jason Wang
2013-09-29  9:36             ` Jason Wang
2013-09-02  8:41 ` [PATCH V3 5/6] vhost_net: poll vhost queue after marking DMA is done Jason Wang
2013-09-02  8:41 ` Jason Wang
2013-09-02  8:41 ` [PATCH V3 6/6] vhost_net: correctly limit the max pending buffers Jason Wang
2013-09-02  8:41   ` Jason Wang
2013-09-04  2:47 ` [PATCH V3 0/6] vhost code cleanup and minor enhancement David Miller
2013-09-04  2:47   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378111261-14826-2-git-send-email-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.