All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Gardiner <ben.l.gardiner@gmail.com>
To: grant.likely@secretlab.ca,
	spi-devel-general@lists.sourceforge.net,
	davinci-linux-open-source@linux.davincidsp.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] spi: spi-davinci: deassert CS on setup()
Date: Tue, 10 Sep 2013 13:10:22 -0400	[thread overview]
Message-ID: <1378833022-31046-1-git-send-email-ben.l.gardiner@gmail.com> (raw)

The mmc_spi driver's mmc_cs_off() function states that "chipselect will always
be inactive after setup()"; however, the spi-davinci driver's setup() leaves CS
state unchanged.

Add a call to davinci_spi_chipselect(spi, BITBANG_CS_INACTIVE) to the spi-
davinci drivers' setup() function.

Signed-off-by: Ben Gardiner <ben.l.gardiner@gmail.com>
---
 drivers/spi/spi-davinci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
index 707966b..f0f4dbd 100644
--- a/drivers/spi/spi-davinci.c
+++ b/drivers/spi/spi-davinci.c
@@ -404,6 +404,7 @@ static int davinci_spi_setup(struct spi_device *spi)
 		    (pdata->chip_sel[spi->chip_select] == SPI_INTERN_CS))
 			set_io_bits(dspi->base + SPIPC0, 1 << spi->chip_select);
 
+		davinci_spi_chipselect(spi, BITBANG_CS_INACTIVE);
 	}
 
 	if (spi->mode & SPI_READY)
-- 
1.8.1.2


             reply	other threads:[~2013-09-10 17:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10 17:10 Ben Gardiner [this message]
2013-09-11  2:44 ` [PATCH] spi: spi-davinci: deassert CS on setup() Trent Piepho
2013-09-11  2:44   ` Trent Piepho
2013-09-12 13:01   ` Ben Gardiner
2013-09-12 13:01     ` Ben Gardiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378833022-31046-1-git-send-email-ben.l.gardiner@gmail.com \
    --to=ben.l.gardiner@gmail.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.