All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/10] pwm-backlight: Add optional enable GPIO
Date: Mon, 23 Sep 2013 21:40:59 +0000	[thread overview]
Message-ID: <1379972467-11243-3-git-send-email-treding@nvidia.com> (raw)
In-Reply-To: <1379972467-11243-1-git-send-email-treding@nvidia.com>

To support a wider variety of backlight setups, introduce an optional
enable GPIO. Legacy users of the platform data already have a means of
supporting GPIOs by using the .init(), .exit() and .notify() hooks. DT
users however cannot use those, so an alternative method is required.

In order to ease the introduction of the optional enable GPIO, make it
available in the platform data first, so that existing users can be
converted. Once that has happened a second patch will add code to make
use of it in the driver.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 include/linux/pwm_backlight.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/pwm_backlight.h b/include/linux/pwm_backlight.h
index 56f4a86..2de2e27 100644
--- a/include/linux/pwm_backlight.h
+++ b/include/linux/pwm_backlight.h
@@ -6,6 +6,9 @@
 
 #include <linux/backlight.h>
 
+/* TODO: convert to gpiod_*() API once it has been merged */
+#define PWM_BACKLIGHT_GPIO_ACTIVE_LOW	(1 << 0)
+
 struct platform_pwm_backlight_data {
 	int pwm_id;
 	unsigned int max_brightness;
@@ -13,6 +16,8 @@ struct platform_pwm_backlight_data {
 	unsigned int lth_brightness;
 	unsigned int pwm_period_ns;
 	unsigned int *levels;
+	int enable_gpio;
+	unsigned long enable_gpio_flags;
 	int (*init)(struct device *dev);
 	int (*notify)(struct device *dev, int brightness);
 	void (*notify_after)(struct device *dev, int brightness);
-- 
1.8.4


WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Tony Lindgren <tony@atomide.com>,
	Eric Miao <eric.y.miao@gmail.com>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Ben Dooks <ben-linux@fluff.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Guan Xuetao <gxt@mprc.pku.edu.cn>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org, openezx-devel@lists.openezx.org,
	linux-samsung-soc@vger.kernel.org, linux-sh@vger.kernel.org,
	linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 02/10] pwm-backlight: Add optional enable GPIO
Date: Mon, 23 Sep 2013 23:40:59 +0200	[thread overview]
Message-ID: <1379972467-11243-3-git-send-email-treding@nvidia.com> (raw)
In-Reply-To: <1379972467-11243-1-git-send-email-treding@nvidia.com>

To support a wider variety of backlight setups, introduce an optional
enable GPIO. Legacy users of the platform data already have a means of
supporting GPIOs by using the .init(), .exit() and .notify() hooks. DT
users however cannot use those, so an alternative method is required.

In order to ease the introduction of the optional enable GPIO, make it
available in the platform data first, so that existing users can be
converted. Once that has happened a second patch will add code to make
use of it in the driver.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 include/linux/pwm_backlight.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/pwm_backlight.h b/include/linux/pwm_backlight.h
index 56f4a86..2de2e27 100644
--- a/include/linux/pwm_backlight.h
+++ b/include/linux/pwm_backlight.h
@@ -6,6 +6,9 @@
 
 #include <linux/backlight.h>
 
+/* TODO: convert to gpiod_*() API once it has been merged */
+#define PWM_BACKLIGHT_GPIO_ACTIVE_LOW	(1 << 0)
+
 struct platform_pwm_backlight_data {
 	int pwm_id;
 	unsigned int max_brightness;
@@ -13,6 +16,8 @@ struct platform_pwm_backlight_data {
 	unsigned int lth_brightness;
 	unsigned int pwm_period_ns;
 	unsigned int *levels;
+	int enable_gpio;
+	unsigned long enable_gpio_flags;
 	int (*init)(struct device *dev);
 	int (*notify)(struct device *dev, int brightness);
 	void (*notify_after)(struct device *dev, int brightness);
-- 
1.8.4


WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/10] pwm-backlight: Add optional enable GPIO
Date: Mon, 23 Sep 2013 23:40:59 +0200	[thread overview]
Message-ID: <1379972467-11243-3-git-send-email-treding@nvidia.com> (raw)
In-Reply-To: <1379972467-11243-1-git-send-email-treding@nvidia.com>

To support a wider variety of backlight setups, introduce an optional
enable GPIO. Legacy users of the platform data already have a means of
supporting GPIOs by using the .init(), .exit() and .notify() hooks. DT
users however cannot use those, so an alternative method is required.

In order to ease the introduction of the optional enable GPIO, make it
available in the platform data first, so that existing users can be
converted. Once that has happened a second patch will add code to make
use of it in the driver.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 include/linux/pwm_backlight.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/pwm_backlight.h b/include/linux/pwm_backlight.h
index 56f4a86..2de2e27 100644
--- a/include/linux/pwm_backlight.h
+++ b/include/linux/pwm_backlight.h
@@ -6,6 +6,9 @@
 
 #include <linux/backlight.h>
 
+/* TODO: convert to gpiod_*() API once it has been merged */
+#define PWM_BACKLIGHT_GPIO_ACTIVE_LOW	(1 << 0)
+
 struct platform_pwm_backlight_data {
 	int pwm_id;
 	unsigned int max_brightness;
@@ -13,6 +16,8 @@ struct platform_pwm_backlight_data {
 	unsigned int lth_brightness;
 	unsigned int pwm_period_ns;
 	unsigned int *levels;
+	int enable_gpio;
+	unsigned long enable_gpio_flags;
 	int (*init)(struct device *dev);
 	int (*notify)(struct device *dev, int brightness);
 	void (*notify_after)(struct device *dev, int brightness);
-- 
1.8.4

  parent reply	other threads:[~2013-09-23 21:40 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23 21:40 [PATCH 00/10] pwm-backlight: Add GPIO and power supply support Thierry Reding
2013-09-23 21:40 ` Thierry Reding
2013-09-23 21:40 ` Thierry Reding
2013-09-23 21:40 ` [PATCH 01/10] pwm-backlight: Refactor backlight power on/off Thierry Reding
2013-09-23 21:40   ` Thierry Reding
2013-09-23 21:40   ` Thierry Reding
2013-09-23 21:40   ` Thierry Reding
2013-10-01 18:26   ` Stephen Warren
2013-10-01 18:26     ` Stephen Warren
2013-10-01 18:26     ` Stephen Warren
2013-10-01 18:26     ` Stephen Warren
2013-10-01 20:34     ` Thierry Reding
2013-10-01 20:34       ` Thierry Reding
2013-10-01 20:34       ` Thierry Reding
2013-09-23 21:40 ` Thierry Reding [this message]
2013-09-23 21:40   ` [PATCH 02/10] pwm-backlight: Add optional enable GPIO Thierry Reding
2013-09-23 21:40   ` Thierry Reding
2013-09-23 21:41 ` [PATCH 03/10] ARM: OMAP: Initialize PWM backlight enable_gpio field Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41 ` [PATCH 04/10] ARM: pxa: " Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41 ` [PATCH 05/10] ARM: SAMSUNG: " Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-10-01 18:31   ` Stephen Warren
2013-10-01 18:31     ` Stephen Warren
2013-10-01 18:31     ` Stephen Warren
2013-10-01 20:43     ` Thierry Reding
2013-10-01 20:43       ` Thierry Reding
2013-10-01 20:43       ` Thierry Reding
2013-10-01 20:43       ` Thierry Reding
2013-10-01 20:58       ` Stephen Warren
2013-10-01 20:58         ` Stephen Warren
2013-10-01 20:58         ` Stephen Warren
2013-10-01 20:58         ` Stephen Warren
2013-10-01 21:23         ` Thierry Reding
2013-10-01 21:23           ` Thierry Reding
2013-10-01 21:23           ` Thierry Reding
2013-09-23 21:41 ` [PATCH 06/10] ARM: shmobile: " Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-25  5:40   ` Simon Horman
2013-09-25  5:40     ` Simon Horman
2013-09-25  5:40     ` Simon Horman
2013-09-23 21:41 ` [PATCH 07/10] unicore32: " Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41 ` [PATCH 08/10] pwm-backlight: Use new " Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-10-01 18:39   ` Stephen Warren
2013-10-01 18:39     ` Stephen Warren
2013-10-01 18:39     ` Stephen Warren
2013-10-01 18:39     ` Stephen Warren
2013-10-01 20:49     ` Thierry Reding
2013-10-01 20:49       ` Thierry Reding
2013-10-01 20:49       ` Thierry Reding
2013-09-23 21:41 ` [PATCH 09/10] pwm-backlight: Use an optional power supply Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-10-01 18:43   ` Stephen Warren
2013-10-01 18:43     ` Stephen Warren
2013-10-01 18:43     ` Stephen Warren
2013-10-01 20:53     ` Thierry Reding
2013-10-01 20:53       ` Thierry Reding
2013-10-01 20:53       ` Thierry Reding
2013-10-01 20:59       ` Stephen Warren
2013-10-01 20:59         ` Stephen Warren
2013-10-01 20:59         ` Stephen Warren
2013-10-01 21:31         ` Thierry Reding
2013-10-01 21:31           ` Thierry Reding
2013-10-01 21:31           ` Thierry Reding
2013-10-02 10:35           ` Mark Brown
2013-10-02 10:35             ` Mark Brown
2013-10-02 10:35             ` Mark Brown
2013-09-23 21:41 ` [PATCH 10/10] pwm-backlight: Allow backlight to remain disabled on boot Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-09-23 21:41   ` Thierry Reding
2013-10-01 18:50   ` Stephen Warren
2013-10-01 18:50     ` Stephen Warren
2013-10-01 18:50     ` Stephen Warren
2013-10-01 21:14     ` Thierry Reding
2013-10-01 21:14       ` Thierry Reding
2013-10-01 21:14       ` Thierry Reding
2013-10-02 17:45     ` Thierry Reding
2013-10-02 17:45       ` Thierry Reding
2013-10-02 17:45       ` Thierry Reding
2013-09-24  8:14 ` [PATCH 00/10] pwm-backlight: Add GPIO and power supply support Simon Horman
2013-09-24  8:14   ` Simon Horman
2013-09-24  8:14   ` Simon Horman
2013-09-24  9:00   ` Thierry Reding
2013-09-24  9:00     ` Thierry Reding
2013-09-24  9:00     ` Thierry Reding
2013-09-24  9:00     ` Thierry Reding
2013-09-25  5:39     ` Simon Horman
2013-09-25  5:39       ` Simon Horman
2013-09-25  5:39       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379972467-11243-3-git-send-email-treding@nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.