From: "Ivan T. Ivanov" <iivanov@mm-sol.com> To: balbi@ti.com Cc: rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org, ijc+devicetree@hellion.org.uk, rob@landley.net, davidb@codeaurora.org, dwalker@fifo99.com, bryanh@codeaurora.org, linux@arm.linux.org.uk, gregkh@linuxfoundation.org, grant.likely@linaro.org, jackp@codeaurora.org, mgautam@codeaurora.org, dsegal@codeaurora.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Ivan T. Ivanov" <iivanov@mm-sol.com> Subject: [PATCH v3 08/13] usb: phy: msm: Drop default usb_dr_mode from platform data. Date: Mon, 14 Oct 2013 18:24:35 +0300 [thread overview] Message-ID: <1381764280-28420-9-git-send-email-iivanov@mm-sol.com> (raw) In-Reply-To: <1381764280-28420-1-git-send-email-iivanov@mm-sol.com> From: "Ivan T. Ivanov" <iivanov@mm-sol.com> USB DT bindings states: "...In case this attribute isn't passed via DT, USB DRD controllers should default to OTG...", so remove redundand field. Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com> --- drivers/usb/phy/phy-msm-usb.c | 7 ------- include/linux/usb/msm_hsusb.h | 3 --- 2 files changed, 10 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 2aca042..4a23cfa 100644 --- a/drivers/usb/phy/phy-msm-usb.c +++ b/drivers/usb/phy/phy-msm-usb.c @@ -1067,15 +1067,8 @@ static void msm_otg_init_sm(struct msm_otg *motg) else clear_bit(B_SESS_VLD, &motg->inputs); } else if (pdata->otg_control == OTG_USER_CONTROL) { - if (pdata->default_mode == USB_DR_MODE_PERIPHERAL) { - set_bit(ID, &motg->inputs); - set_bit(B_SESS_VLD, &motg->inputs); - } else if (pdata->default_mode == USB_DR_MODE_HOST) { - clear_bit(ID, &motg->inputs); - } else { set_bit(ID, &motg->inputs); clear_bit(B_SESS_VLD, &motg->inputs); - } } break; case USB_DR_MODE_HOST: diff --git a/include/linux/usb/msm_hsusb.h b/include/linux/usb/msm_hsusb.h index f9d512e..72c5830 100644 --- a/include/linux/usb/msm_hsusb.h +++ b/include/linux/usb/msm_hsusb.h @@ -106,8 +106,6 @@ enum usb_chg_type { * @power_budget: VBUS power budget in mA (0 will be treated as 500mA). * @mode: Supported mode (OTG/peripheral/host). * @otg_control: OTG switch controlled by user/Id pin - * @default_mode: Default operational mode. Applicable only if - * OTG switch is controller by user. * @pclk_src_name: pclk is derived from ebi1_usb_clk in case of 7x27 and 8k * dfab_usb_hs_clk in case of 8660 and 8960. */ @@ -117,7 +115,6 @@ struct msm_otg_platform_data { unsigned power_budget; enum usb_dr_mode mode; enum otg_control_type otg_control; - enum usb_dr_mode default_mode; enum msm_usb_phy_type phy_type; void (*setup_gpio)(enum usb_otg_state state); char *pclk_src_name; -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: iivanov@mm-sol.com (Ivan T. Ivanov) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 08/13] usb: phy: msm: Drop default usb_dr_mode from platform data. Date: Mon, 14 Oct 2013 18:24:35 +0300 [thread overview] Message-ID: <1381764280-28420-9-git-send-email-iivanov@mm-sol.com> (raw) In-Reply-To: <1381764280-28420-1-git-send-email-iivanov@mm-sol.com> From: "Ivan T. Ivanov" <iivanov@mm-sol.com> USB DT bindings states: "...In case this attribute isn't passed via DT, USB DRD controllers should default to OTG...", so remove redundand field. Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com> --- drivers/usb/phy/phy-msm-usb.c | 7 ------- include/linux/usb/msm_hsusb.h | 3 --- 2 files changed, 10 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 2aca042..4a23cfa 100644 --- a/drivers/usb/phy/phy-msm-usb.c +++ b/drivers/usb/phy/phy-msm-usb.c @@ -1067,15 +1067,8 @@ static void msm_otg_init_sm(struct msm_otg *motg) else clear_bit(B_SESS_VLD, &motg->inputs); } else if (pdata->otg_control == OTG_USER_CONTROL) { - if (pdata->default_mode == USB_DR_MODE_PERIPHERAL) { - set_bit(ID, &motg->inputs); - set_bit(B_SESS_VLD, &motg->inputs); - } else if (pdata->default_mode == USB_DR_MODE_HOST) { - clear_bit(ID, &motg->inputs); - } else { set_bit(ID, &motg->inputs); clear_bit(B_SESS_VLD, &motg->inputs); - } } break; case USB_DR_MODE_HOST: diff --git a/include/linux/usb/msm_hsusb.h b/include/linux/usb/msm_hsusb.h index f9d512e..72c5830 100644 --- a/include/linux/usb/msm_hsusb.h +++ b/include/linux/usb/msm_hsusb.h @@ -106,8 +106,6 @@ enum usb_chg_type { * @power_budget: VBUS power budget in mA (0 will be treated as 500mA). * @mode: Supported mode (OTG/peripheral/host). * @otg_control: OTG switch controlled by user/Id pin - * @default_mode: Default operational mode. Applicable only if - * OTG switch is controller by user. * @pclk_src_name: pclk is derived from ebi1_usb_clk in case of 7x27 and 8k * dfab_usb_hs_clk in case of 8660 and 8960. */ @@ -117,7 +115,6 @@ struct msm_otg_platform_data { unsigned power_budget; enum usb_dr_mode mode; enum otg_control_type otg_control; - enum usb_dr_mode default_mode; enum msm_usb_phy_type phy_type; void (*setup_gpio)(enum usb_otg_state state); char *pclk_src_name; -- 1.7.9.5
next prev parent reply other threads:[~2013-10-14 15:24 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-10-14 15:24 [PATCH v3 00/13] usb: phy: msm: Fixes, cleanups and DT support Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` [PATCH v3 01/13] usb: phy: msm: Move mach depndend code to platform data Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 22:52 ` Felipe Balbi 2013-10-14 22:52 ` Felipe Balbi 2013-10-14 22:52 ` Felipe Balbi 2013-10-15 7:01 ` Ivan T. Ivanov 2013-10-15 7:01 ` Ivan T. Ivanov 2013-10-14 15:24 ` [PATCH v3 02/13] usb: phy: msm: Move global regulators variables to driver state Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 22:52 ` Felipe Balbi 2013-10-14 22:52 ` Felipe Balbi 2013-10-14 22:52 ` Felipe Balbi 2013-10-14 15:24 ` [PATCH v3 03/13] usb: phy: msm: Migrate to Managed Device Resource allocation Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` [PATCH v3 04/13] usb: phy: msm: Remove unnecessarily check for valid regulators Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` [PATCH v3 07/13] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov [this message] 2013-10-14 15:24 ` [PATCH v3 08/13] usb: phy: msm: Drop default usb_dr_mode from platform data Ivan T. Ivanov [not found] ` <1381764280-28420-1-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org> 2013-10-14 15:24 ` [PATCH v3 05/13] usb: phy: msm: Fix WARNING: quoted string split across lines Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` [PATCH v3 06/13] usb: phy: msm: Fix WARNING: Prefer seq_puts to seq_printf Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` [PATCH v3 09/13] usb: phy: msm: Remove unused pclk_src_name Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` [PATCH v3 10/13] usb: phy: msm: Switch clock consumer strings Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` [PATCH v3 12/13] usb: phy: msm: Properly check core interrupt number Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 22:59 ` Felipe Balbi 2013-10-14 22:59 ` Felipe Balbi 2013-10-14 22:59 ` Felipe Balbi 2013-10-15 7:12 ` Ivan T. Ivanov 2013-10-15 7:12 ` Ivan T. Ivanov 2013-10-15 7:12 ` Ivan T. Ivanov 2013-10-14 15:24 ` [PATCH v3 11/13] usb: phy: msm: Remove HSUSB prefix from requlator names Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov 2013-10-14 15:24 ` [PATCH v3 13/13] usb: phy: msm: Add device tree support and binding information Ivan T. Ivanov 2013-10-14 15:24 ` Ivan T. Ivanov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1381764280-28420-9-git-send-email-iivanov@mm-sol.com \ --to=iivanov@mm-sol.com \ --cc=balbi@ti.com \ --cc=bryanh@codeaurora.org \ --cc=davidb@codeaurora.org \ --cc=devicetree@vger.kernel.org \ --cc=dsegal@codeaurora.org \ --cc=dwalker@fifo99.com \ --cc=grant.likely@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jackp@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.rutland@arm.com \ --cc=mgautam@codeaurora.org \ --cc=pawel.moll@arm.com \ --cc=rob.herring@calxeda.com \ --cc=rob@landley.net \ --cc=swarren@wwwdotorg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.