All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <jhovold@gmail.com>
To: Richard Purdie <rpurdie@rpsys.net>, Jingoo Han <jg1.han@samsung.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <jhovold@gmail.com>
Subject: [PATCH 9/9] backlight: atmel-pwm-bl: use gpio_request_one
Date: Tue, 22 Oct 2013 19:26:59 +0200	[thread overview]
Message-ID: <1382462819-28576-10-git-send-email-jhovold@gmail.com> (raw)
In-Reply-To: <1382462819-28576-1-git-send-email-jhovold@gmail.com>

Use devm_gpio_request_one rather than requesting and setting direction
in two calls.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
 drivers/video/backlight/atmel-pwm-bl.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c
index 1277e0c..5ea2517 100644
--- a/drivers/video/backlight/atmel-pwm-bl.c
+++ b/drivers/video/backlight/atmel-pwm-bl.c
@@ -124,6 +124,7 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev)
 	const struct atmel_pwm_bl_platform_data *pdata;
 	struct backlight_device *bldev;
 	struct atmel_pwm_bl *pwmbl;
+	int flags;
 	int retval;
 
 	pdata = dev_get_platdata(&pdev->dev);
@@ -149,14 +150,14 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev)
 		return retval;
 
 	if (gpio_is_valid(pwmbl->gpio_on)) {
-		retval = devm_gpio_request(&pdev->dev, pwmbl->gpio_on,
-					"gpio_atmel_pwm_bl");
-		if (retval)
-			goto err_free_pwm;
-
 		/* Turn display off by default. */
-		retval = gpio_direction_output(pwmbl->gpio_on,
-				0 ^ pdata->on_active_low);
+		if (pdata->on_active_low)
+			flags = GPIOF_OUT_INIT_HIGH;
+		else
+			flags = GPIOF_OUT_INIT_LOW;
+
+		retval = devm_gpio_request_one(&pdev->dev, pwmbl->gpio_on,
+						flags, "gpio_atmel_pwm_bl");
 		if (retval)
 			goto err_free_pwm;
 	}
-- 
1.8.4


WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <jhovold@gmail.com>
To: Richard Purdie <rpurdie@rpsys.net>, Jingoo Han <jg1.han@samsung.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <jhovold@gmail.com>
Subject: [PATCH 9/9] backlight: atmel-pwm-bl: use gpio_request_one
Date: Tue, 22 Oct 2013 17:26:59 +0000	[thread overview]
Message-ID: <1382462819-28576-10-git-send-email-jhovold@gmail.com> (raw)
In-Reply-To: <1382462819-28576-1-git-send-email-jhovold@gmail.com>

Use devm_gpio_request_one rather than requesting and setting direction
in two calls.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
 drivers/video/backlight/atmel-pwm-bl.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c
index 1277e0c..5ea2517 100644
--- a/drivers/video/backlight/atmel-pwm-bl.c
+++ b/drivers/video/backlight/atmel-pwm-bl.c
@@ -124,6 +124,7 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev)
 	const struct atmel_pwm_bl_platform_data *pdata;
 	struct backlight_device *bldev;
 	struct atmel_pwm_bl *pwmbl;
+	int flags;
 	int retval;
 
 	pdata = dev_get_platdata(&pdev->dev);
@@ -149,14 +150,14 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev)
 		return retval;
 
 	if (gpio_is_valid(pwmbl->gpio_on)) {
-		retval = devm_gpio_request(&pdev->dev, pwmbl->gpio_on,
-					"gpio_atmel_pwm_bl");
-		if (retval)
-			goto err_free_pwm;
-
 		/* Turn display off by default. */
-		retval = gpio_direction_output(pwmbl->gpio_on,
-				0 ^ pdata->on_active_low);
+		if (pdata->on_active_low)
+			flags = GPIOF_OUT_INIT_HIGH;
+		else
+			flags = GPIOF_OUT_INIT_LOW;
+
+		retval = devm_gpio_request_one(&pdev->dev, pwmbl->gpio_on,
+						flags, "gpio_atmel_pwm_bl");
 		if (retval)
 			goto err_free_pwm;
 	}
-- 
1.8.4


  parent reply	other threads:[~2013-10-22 17:28 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22 17:26 [PATCH 0/9] backlight: atmel-pwm-bl: fixes and clean ups Johan Hovold
2013-10-22 17:26 ` Johan Hovold
2013-10-22 17:26 ` [PATCH 1/9] backlight: atmel-pwm-bl: fix reported brightness Johan Hovold
2013-10-22 17:26   ` Johan Hovold
2013-10-23  1:20   ` Jingoo Han
2013-10-23  1:20     ` Jingoo Han
2013-10-23  8:51     ` Johan Hovold
2013-10-23  8:51       ` Johan Hovold
2013-10-23  9:35       ` Jingoo Han
2013-10-23  9:35         ` Jingoo Han
2013-10-22 17:26 ` [PATCH 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove Johan Hovold
2013-10-22 17:26   ` Johan Hovold
2013-10-23  1:47   ` Jingoo Han
2013-10-23  1:47     ` Jingoo Han
2013-10-22 17:26 ` [PATCH 3/9] backlight: atmel-pwm-bl: fix module autoload Johan Hovold
2013-10-22 17:26   ` Johan Hovold
2013-10-23  1:48   ` Jingoo Han
2013-10-23  1:48     ` Jingoo Han
2013-10-22 17:26 ` [PATCH 4/9] backlight: atmel-pwm-bl: clean up probe error handling Johan Hovold
2013-10-22 17:26   ` Johan Hovold
2013-10-23  1:50   ` Jingoo Han
2013-10-23  1:50     ` Jingoo Han
2013-10-22 17:26 ` [PATCH 5/9] backlight: atmel-pwm-bl: clean up get_intensity Johan Hovold
2013-10-22 17:26   ` Johan Hovold
2013-10-23  1:51   ` Jingoo Han
2013-10-23  1:51     ` Jingoo Han
2013-10-22 17:26 ` [PATCH 6/9] backlight: atmel-pwm-bl: remove unused include Johan Hovold
2013-10-22 17:26   ` Johan Hovold
2013-10-23  1:51   ` Jingoo Han
2013-10-23  1:51     ` Jingoo Han
2013-10-22 17:26 ` [PATCH 7/9] backlight: atmel-pwm-bl: use gpio_is_valid Johan Hovold
2013-10-22 17:26   ` Johan Hovold
2013-10-23  1:52   ` Jingoo Han
2013-10-23  1:52     ` Jingoo Han
2013-10-22 17:26 ` [PATCH 8/9] backlight: atmel-pwm-bl: refactor gpio_on handling Johan Hovold
2013-10-22 17:26   ` Johan Hovold
2013-10-23  1:53   ` Jingoo Han
2013-10-23  1:53     ` Jingoo Han
2013-10-22 17:26 ` Johan Hovold [this message]
2013-10-22 17:26   ` [PATCH 9/9] backlight: atmel-pwm-bl: use gpio_request_one Johan Hovold
2013-10-23  1:54   ` Jingoo Han
2013-10-23  1:54     ` Jingoo Han
2013-10-23  1:19 ` [PATCH 0/9] backlight: atmel-pwm-bl: fixes and clean ups Jingoo Han
2013-10-23  1:19   ` Jingoo Han
2013-10-23  7:57   ` Nicolas Ferre
2013-10-23  7:57     ` Nicolas Ferre
2013-10-23  9:55 [PATCH RESEND " Johan Hovold
2013-10-23  9:55 ` [PATCH 9/9] backlight: atmel-pwm-bl: use gpio_request_one Johan Hovold
2013-10-23  9:55   ` Johan Hovold
2013-10-25 11:15   ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-25 11:15     ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-29 13:20     ` Johan Hovold
2013-10-29 13:20       ` Johan Hovold
2013-10-30 19:30       ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-30 19:30         ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382462819-28576-10-git-send-email-jhovold@gmail.com \
    --to=jhovold@gmail.com \
    --cc=jg1.han@samsung.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.