All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <jhovold@gmail.com>
To: Richard Purdie <rpurdie@rpsys.net>, Jingoo Han <jg1.han@samsung.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <jhovold@gmail.com>,
	stable@vger.kernel.org
Subject: [PATCH v2 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove
Date: Tue, 29 Oct 2013 17:27:37 +0100	[thread overview]
Message-ID: <1383064064-4983-3-git-send-email-jhovold@gmail.com> (raw)
In-Reply-To: <1383064064-4983-1-git-send-email-jhovold@gmail.com>

Make sure to honour gpio polarity also at remove so that the backlight
is actually disabled on boards with active-low enable pin.

Cc: stable@vger.kernel.org
Acked-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
 drivers/video/backlight/atmel-pwm-bl.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c
index 0971a8e..e21beb6 100644
--- a/drivers/video/backlight/atmel-pwm-bl.c
+++ b/drivers/video/backlight/atmel-pwm-bl.c
@@ -205,8 +205,10 @@ static int atmel_pwm_bl_remove(struct platform_device *pdev)
 {
 	struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev);
 
-	if (pwmbl->gpio_on != -1)
-		gpio_set_value(pwmbl->gpio_on, 0);
+	if (pwmbl->gpio_on != -1) {
+		gpio_set_value(pwmbl->gpio_on,
+					0 ^ pwmbl->pdata->on_active_low);
+	}
 	pwm_channel_disable(&pwmbl->pwmc);
 	pwm_channel_free(&pwmbl->pwmc);
 
-- 
1.8.4.2


WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <jhovold@gmail.com>
To: Richard Purdie <rpurdie@rpsys.net>, Jingoo Han <jg1.han@samsung.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <jhovold@gmail.com>,
	stable@vger.kernel.org
Subject: [PATCH v2 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove
Date: Tue, 29 Oct 2013 16:27:37 +0000	[thread overview]
Message-ID: <1383064064-4983-3-git-send-email-jhovold@gmail.com> (raw)
In-Reply-To: <1383064064-4983-1-git-send-email-jhovold@gmail.com>

Make sure to honour gpio polarity also at remove so that the backlight
is actually disabled on boards with active-low enable pin.

Cc: stable@vger.kernel.org
Acked-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
 drivers/video/backlight/atmel-pwm-bl.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c
index 0971a8e..e21beb6 100644
--- a/drivers/video/backlight/atmel-pwm-bl.c
+++ b/drivers/video/backlight/atmel-pwm-bl.c
@@ -205,8 +205,10 @@ static int atmel_pwm_bl_remove(struct platform_device *pdev)
 {
 	struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev);
 
-	if (pwmbl->gpio_on != -1)
-		gpio_set_value(pwmbl->gpio_on, 0);
+	if (pwmbl->gpio_on != -1) {
+		gpio_set_value(pwmbl->gpio_on,
+					0 ^ pwmbl->pdata->on_active_low);
+	}
 	pwm_channel_disable(&pwmbl->pwmc);
 	pwm_channel_free(&pwmbl->pwmc);
 
-- 
1.8.4.2


  parent reply	other threads:[~2013-10-29 16:28 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-23  9:55 [PATCH RESEND 0/9] backlight: atmel-pwm-bl: fixes and clean ups Johan Hovold
2013-10-23  9:55 ` Johan Hovold
2013-10-23  9:55 ` [PATCH 1/9] backlight: atmel-pwm-bl: fix reported brightness Johan Hovold
2013-10-23  9:55   ` Johan Hovold
2013-10-25 11:08   ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-25 11:08     ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-29 13:32     ` Johan Hovold
2013-10-29 13:32       ` Johan Hovold
2013-10-23  9:55 ` [PATCH 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove Johan Hovold
2013-10-23  9:55   ` Johan Hovold
2013-10-25 11:09   ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-25 11:09     ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-29 13:08     ` Johan Hovold
2013-10-29 13:08       ` Johan Hovold
2013-10-23  9:55 ` [PATCH 3/9] backlight: atmel-pwm-bl: fix module autoload Johan Hovold
2013-10-23  9:55   ` Johan Hovold
2013-10-23  9:55 ` [PATCH 4/9] backlight: atmel-pwm-bl: clean up probe error handling Johan Hovold
2013-10-23  9:55   ` Johan Hovold
2013-10-25 11:11   ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-25 11:11     ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-29 13:09     ` Johan Hovold
2013-10-29 13:09       ` Johan Hovold
2013-10-23  9:55 ` [PATCH 5/9] backlight: atmel-pwm-bl: clean up get_intensity Johan Hovold
2013-10-23  9:55   ` Johan Hovold
2013-10-25 11:12   ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-25 11:12     ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-23  9:55 ` [PATCH 6/9] backlight: atmel-pwm-bl: remove unused include Johan Hovold
2013-10-23  9:55   ` Johan Hovold
2013-10-23  9:55 ` [PATCH 7/9] backlight: atmel-pwm-bl: use gpio_is_valid Johan Hovold
2013-10-23  9:55   ` Johan Hovold
2013-10-23  9:55 ` [PATCH 8/9] backlight: atmel-pwm-bl: refactor gpio_on handling Johan Hovold
2013-10-23  9:55   ` Johan Hovold
2013-10-25 11:13   ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-25 11:13     ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-23  9:55 ` [PATCH 9/9] backlight: atmel-pwm-bl: use gpio_request_one Johan Hovold
2013-10-23  9:55   ` Johan Hovold
2013-10-25 11:15   ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-25 11:15     ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-29 13:20     ` Johan Hovold
2013-10-29 13:20       ` Johan Hovold
2013-10-30 19:30       ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-30 19:30         ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-29 16:27 ` [PATCH v2 0/9] backlight: atmel-pwm-bl: fixes and clean ups Johan Hovold
2013-10-29 16:27   ` Johan Hovold
2013-10-29 16:27   ` [PATCH v2 1/9] backlight: atmel-pwm-bl: fix reported brightness Johan Hovold
2013-10-29 16:27     ` Johan Hovold
2013-10-29 16:27   ` Johan Hovold [this message]
2013-10-29 16:27     ` [PATCH v2 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove Johan Hovold
2013-10-29 16:27   ` [PATCH v2 3/9] backlight: atmel-pwm-bl: fix module autoload Johan Hovold
2013-10-29 16:27     ` Johan Hovold
2013-10-29 16:27   ` [PATCH v2 4/9] backlight: atmel-pwm-bl: clean up probe error handling Johan Hovold
2013-10-29 16:27     ` Johan Hovold
2013-10-29 16:27   ` [PATCH v2 5/9] backlight: atmel-pwm-bl: clean up get_intensity Johan Hovold
2013-10-29 16:27     ` Johan Hovold
2013-10-29 16:27   ` [PATCH v2 6/9] backlight: atmel-pwm-bl: remove unused include Johan Hovold
2013-10-29 16:27     ` Johan Hovold
2013-10-29 16:27   ` [PATCH v2 7/9] backlight: atmel-pwm-bl: use gpio_is_valid Johan Hovold
2013-10-29 16:27     ` Johan Hovold
2013-10-29 16:27   ` [PATCH v2 8/9] backlight: atmel-pwm-bl: refactor gpio_on handling Johan Hovold
2013-10-29 16:27     ` Johan Hovold
2013-10-29 16:27   ` [PATCH v2 9/9] backlight: atmel-pwm-bl: use gpio_request_one Johan Hovold
2013-10-29 16:27     ` Johan Hovold
2013-10-31 17:57   ` [PATCH v3 0/9] backlight: atmel-pwm-bl: fixes and clean ups Johan Hovold
2013-10-31 17:57     ` Johan Hovold
2013-10-31 17:57     ` [PATCH v3 1/9] backlight: atmel-pwm-bl: fix reported brightness Johan Hovold
2013-10-31 17:57       ` Johan Hovold
2013-10-31 17:57     ` [PATCH v3 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove Johan Hovold
2013-10-31 17:57       ` Johan Hovold
2013-10-31 17:57     ` [PATCH v3 3/9] backlight: atmel-pwm-bl: fix module autoload Johan Hovold
2013-10-31 17:57       ` Johan Hovold
2013-10-31 17:57     ` [PATCH v3 4/9] backlight: atmel-pwm-bl: clean up probe error handling Johan Hovold
2013-10-31 17:57       ` Johan Hovold
2013-10-31 17:57     ` [PATCH v3 5/9] backlight: atmel-pwm-bl: clean up get_intensity Johan Hovold
2013-10-31 17:57       ` Johan Hovold
2013-10-31 17:57     ` [PATCH v3 6/9] backlight: atmel-pwm-bl: remove unused include Johan Hovold
2013-10-31 17:57       ` Johan Hovold
2013-10-31 17:57     ` [PATCH v3 7/9] backlight: atmel-pwm-bl: use gpio_is_valid Johan Hovold
2013-10-31 17:57       ` Johan Hovold
2013-10-31 17:57     ` [PATCH v3 8/9] backlight: atmel-pwm-bl: refactor gpio_on handling Johan Hovold
2013-10-31 17:57       ` Johan Hovold
2013-10-31 17:57     ` [PATCH v3 9/9] backlight: atmel-pwm-bl: use gpio_request_one Johan Hovold
2013-10-31 17:57       ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383064064-4983-3-git-send-email-jhovold@gmail.com \
    --to=jhovold@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jg1.han@samsung.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=rpurdie@rpsys.net \
    --cc=stable@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.