From: Li Wang <liwang@ubuntukylin.com>
To: ceph-devel@vger.kernel.org
Cc: Sage Weil <sage@inktank.com>, Li Wang <liwang@ubuntukylin.com>
Subject: [PATCH] ceph: Fix memory leak in chain_flistxattr()
Date: Wed, 30 Oct 2013 16:44:08 +0800 [thread overview]
Message-ID: <1383122648-19110-1-git-send-email-liwang@ubuntukylin.com> (raw)
Free allocated memory before return
Signed-off-by: Li Wang <liwang@ubuntukylin.com>
---
src/os/chain_xattr.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/os/chain_xattr.cc b/src/os/chain_xattr.cc
index 62733e3..d0a149c 100644
--- a/src/os/chain_xattr.cc
+++ b/src/os/chain_xattr.cc
@@ -401,7 +401,7 @@ int chain_flistxattr(int fd, char *names, size_t len) {
r = sys_flistxattr(fd, full_buf, total_len);
if (r < 0)
- return r;
+ goto done;
char *p = full_buf;
const char *end = full_buf + r;
--
1.7.9.5
reply other threads:[~2013-10-30 8:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383122648-19110-1-git-send-email-liwang@ubuntukylin.com \
--to=liwang@ubuntukylin.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.